Usability bugs in vbrfix; possible data loss/corruption

[Charles Cazabon]

I found a number of buglets in vbrfix (which doesn't appear to have changed from lucid through precise).

1. It appears to use a fixed intermediate tempfile name of "vbrfix.tmp" in its processing of any file. Presumably Bad Things will happen if two copies are run simultaneously, possibly resulting in lost or corrupted files?

2. The tempfile it creates is created in the current working directory, even if the input and output files are in other directories. The program fails if it cannot write to the current directory, so running it from scripts and similar can be problematic, especially in a server environment. There is also no cmdline option to specify an alternate location for its intermediate temp file.

3. It creates a 0-byte vbrfix.log file even when the -log option is not in use. The log file also tries to go to the current working directory, I believe.