MIR for vala

[Chris Coulson]

Vala is now required as a build dependency of tracker 0.7.x, which will land later in the karmic cycle.

https://wiki.ubuntu.com/UbuntuMainInclusionVala

[Kees Cook (kees)]

The debian/rules file does not fail if the test suite fails. If this is fixed, I would approve this MIR.

[Loïc Minier (lool)]

Is this really required? I ignore testsuite failures in a bunch of packages because I know the testsuite doesn't pass, but I want it documented in the build log. I see that currently the testsuite has various issues and doesn't pass, even on i386.

[Kees Cook (kees)]

Test suites failures shouldn't be ignored -- individual tests can perhaps
be marked "XFAIL", etc, if they are expected to fail. The goal is to
catch regressions due to SRUs and security updates. i.e. to be stronger
than just simply documentation.

[Jürg Billeter (j-bitron)]

The vala testsuite should not fail. I regularly verify that the testsuite passes on my system. Please file bugs if you find any issues.

[Chris Coulson (chrisccoulson)]

This is the failure from the build log. Seems we're missing a build-dependency with our package, so that's not your problem Jürg - I'll take a look at that later.

script: line 2: dbus-launch: command not found
client.vala:8.13-8.47: warning: unhandled error `DBus.Error'
 var conn = DBus.Bus.get (DBus.BusType.SESSION);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 1 warning(s)
server.vala:28.13-28.47: warning: unhandled error `DBus.Error'
 var conn = DBus.Bus.get (DBus.BusType.SESSION);
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
server.vala:32.29-32.75: warning: unhandled error `GLib.Error'
 uint request_name_result = bus.request_name ("org.example.Test", (uint) 0);
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
server.vala:40.3-40.100: warning: unhandled error `GLib.SpawnError'
  Process.spawn_async (null, { "client" }, null, SpawnFlags.DO_NOT_REAP_CHILD, null, out client_pid);
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
server.vala:3.5-3.23: warning: method `Test.test_int' never used
    public int test_int (int i, out int j) {
    ^^^^^^^^^^^^^^^^^^^
server.vala:9.5-9.29: warning: method `Test.test_string' never used
    public string test_string (string s, out string t) {
    ^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 5 warning(s)
process 12614: D-Bus library appears to be incorrectly set up; failed to read machine uuid: Failed to open "/var/lib/dbus/machine-id": No such file or directory
See the manual page for dbus-uuidgen to correct this issue.

** CRITICAL **: file server.c: line 301: uncaught error: Failed to execute dbus-launch to autolaunch D-Bus session
aborting...
script: line 8: 12614 Aborted ./server
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
FAIL: dbus/basic-types.test

[Chris Coulson (chrisccoulson)]

I've assigned this to me as I'm going to do the work to get the package in to shape. I'm not sure if I'm meant to assign a MIR to myself - please change this if I'm not

[Martin Pitt (pitti)]

I agree that a test suite for a programming language, which is supposed to succeed, should really succeed. If we can't fix it for maintenance capacity reasons, then it shouldn't be in main, so I think that Kees' requirement is justified.

[Chris Coulson (chrisccoulson)]

Here's a debdiff that fixes the existing test-suite failure and makes the test-suite failures fatal.

[Martin Pitt (pitti)]

vala (0.7.2-1ubuntu1) karmic; urgency=low

  * debian/control:
    - Build-depends on dbus-x11. dbus-launch is needed for part of the
      test-suite.
  * debian/rules:
    - Make test-suite failures fatal.

 -- Chris Coulson <email address hidden> Wed, 13 May 2009 00:06:59 +0100

Uploaded. Let's see how this builds. Thanks Chris!

[Chris Coulson (chrisccoulson)]

Thanks. That seems to have built ok:

make[4]: Entering directory `/build/buildd/vala-0.7.2/tests'
PASS: basic-types/integers.test
PASS: basic-types/floats.test
PASS: basic-types/strings.test
PASS: basic-types/arrays.test
PASS: basic-types/pointers.test
PASS: namespaces.test
PASS: methods/lambda.test
PASS: control-flow/break.test
PASS: control-flow/expressions-conditional.test
PASS: control-flow/for.test
PASS: control-flow/switch.test
PASS: control-flow/sideeffects.test
PASS: enums/enums.test
PASS: structs/structs.test
PASS: delegates/delegates.test
PASS: objects/classes.test
PASS: objects/fields.test
PASS: objects/interfaces.test
PASS: objects/methods.test
PASS: objects/properties.test
PASS: objects/signals.test
PASS: objects/test-025.test
PASS: objects/test-026.test
PASS: objects/test-029.test
PASS: objects/test-034.test
PASS: errors/errors.test
PASS: dbus/basic-types.test
===================
All 27 tests passed
===================

I've also reported the missing build-dep to Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=528561

[Kees Cook (kees)]

Approved! :) Thanks for all the work on this.

[Martin Pitt (pitti)]

Great. Will be promoted as soon as tracker lands and wants to pull it in.

[Martin Pitt (pitti)]

Chris, seems that current tracker still doesn't depend on vala, so this will stay in universe until it does.

[Martin Pitt (pitti)]

Please note that this will not be promoted unless something in main or the seeds require it. Please make this a (build)-dependency of something, otherwise we will just "time out" and close this MIR.

Thank you!

[Martin Pitt (pitti)]

Closing as per Chris' request on IRC.

[Martin Pitt (pitti)]

Required as a build dependency after all, promoted (valac binary already was in main)