| 2021-06-02 19:27:05 |
Ben Reaves |
bug |
|
|
added bug |
| 2021-06-02 19:27:05 |
Ben Reaves |
attachment added |
|
_usr_bin_budgie-panel.1001.crash https://bugs.launchpad.net/bugs/1930615/+attachment/5501965/+files/_usr_bin_budgie-panel.1001.crash |
|
| 2021-06-02 19:28:59 |
Ben Reaves |
description |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012 |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
A working compiled version has been created by @fossfreedom, David Mohammad, here.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
Here is the diff.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012 |
|
| 2021-06-02 19:31:59 |
Ben Reaves |
description |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
A working compiled version has been created by @fossfreedom, David Mohammad, here.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
Here is the diff.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012 |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498
https://github.com/microsoft/vscode/issues/125012 |
|
| 2021-06-02 19:32:21 |
Ben Reaves |
description |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498
https://github.com/microsoft/vscode/issues/125012 |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
|
| 2021-06-03 03:15:29 |
Ben Reaves |
summary |
VS Code crashes Vala Appmenu |
VS Code crashes Vala Appmenu - patch included |
|
| 2021-06-03 03:16:14 |
Ben Reaves |
description |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
|
| 2021-06-03 12:04:03 |
fossfreedom |
vala-panel-appmenu (Ubuntu): importance |
Undecided |
Medium |
|
| 2021-06-03 12:04:07 |
fossfreedom |
vala-panel-appmenu (Ubuntu): assignee |
|
fossfreedom (fossfreedom) |
|
| 2021-06-03 12:06:19 |
fossfreedom |
nominated for series |
|
Ubuntu Focal |
|
| 2021-06-03 12:06:19 |
fossfreedom |
bug task added |
|
vala-panel-appmenu (Ubuntu Focal) |
|
| 2021-06-03 12:06:19 |
fossfreedom |
nominated for series |
|
Ubuntu Groovy |
|
| 2021-06-03 12:06:19 |
fossfreedom |
bug task added |
|
vala-panel-appmenu (Ubuntu Groovy) |
|
| 2021-06-03 12:07:04 |
fossfreedom |
vala-panel-appmenu (Ubuntu Groovy): importance |
Undecided |
Medium |
|
| 2021-06-03 12:07:07 |
fossfreedom |
vala-panel-appmenu (Ubuntu Groovy): assignee |
|
fossfreedom (fossfreedom) |
|
| 2021-06-03 12:07:09 |
fossfreedom |
vala-panel-appmenu (Ubuntu Focal): assignee |
|
fossfreedom (fossfreedom) |
|
| 2021-06-03 12:07:12 |
fossfreedom |
vala-panel-appmenu (Ubuntu Focal): importance |
Undecided |
Medium |
|
| 2021-06-03 12:55:40 |
fossfreedom |
bug |
|
|
added subscriber fossfreedom |
| 2021-06-03 12:55:46 |
Launchpad Janitor |
vala-panel-appmenu (Ubuntu): status |
New |
Confirmed |
|
| 2021-06-03 12:55:46 |
Launchpad Janitor |
vala-panel-appmenu (Ubuntu Focal): status |
New |
Confirmed |
|
| 2021-06-03 12:55:46 |
Launchpad Janitor |
vala-panel-appmenu (Ubuntu Groovy): status |
New |
Confirmed |
|
| 2021-06-03 12:55:53 |
fossfreedom |
vala-panel-appmenu (Ubuntu): status |
Confirmed |
Triaged |
|
| 2021-06-03 12:56:26 |
fossfreedom |
summary |
VS Code crashes Vala Appmenu - patch included |
VS Code crashes Vala Appmenu |
|
| 2021-06-03 13:15:43 |
fossfreedom |
description |
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
SRU In progress
[Impact]
The appmenu provides a in-panel global menu implementation for a number of desktop environments.
With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed.
This upload backport a series of upstream patches designated by the maintainer as a resolution of this issue.
This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes.
In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue.
[Test Plan]
* If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
[Where problems could occur]
* Think about what the upload changes in the software. Imagine the change is
wrong or breaks something else: how would this show up?
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This must '''never''' be "None" or "Low", or entirely an argument as to why
your upload is low risk.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
* and address these questions in advance
----
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
|
| 2021-06-03 22:43:12 |
fossfreedom |
description |
SRU In progress
[Impact]
The appmenu provides a in-panel global menu implementation for a number of desktop environments.
With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed.
This upload backport a series of upstream patches designated by the maintainer as a resolution of this issue.
This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes.
In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue.
[Test Plan]
* If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
[Where problems could occur]
* Think about what the upload changes in the software. Imagine the change is
wrong or breaks something else: how would this show up?
* It is assumed that any SRU candidate patch is well-tested before
upload and has a low overall risk of regression, but it's important
to make the effort to think about what ''could'' happen in the
event of a regression.
* This must '''never''' be "None" or "Low", or entirely an argument as to why
your upload is low risk.
* This both shows the SRU team that the risks have been considered,
and provides guidance to testers in regression-testing the SRU.
[Other Info]
* Anything else you think is useful to include
* Anticipate questions from users, SRU, +1 maintenance, security teams and the Technical Board
* and address these questions in advance
----
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
[Impact]
The appmenu provides a in-panel global menu implementation for a number of desktop environments.
With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed.
This upload backport a series of upstream patches designated by the maintainer as a resolution of this issue.
This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes.
In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue.
[Test Plan]
* If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* Next enable the proposed repository and install the following package:
For budgie-desktop budgie-appmenu-applet
For mate-desktop mate-applet-appmenu
For xfce-desktop xfce4-appmenu-plugin
* Logout and login
* Repeat the vscode tests above - note this time that the panel crash actions do not occur.
* Next confirm that no additional panel instabilities occur with the following application types
Libreoffice
Gtk based game such as Aislerot (solitaire) that do have menus
CSD based apps such as GNOME Calculator that dont have global menu support
Try a broad range of apps found on your desktop menu.
[Where problems could occur]
* Any potential issues with this upload is strictly limited to the package itself - there will be no regression in any other components since the package (per desktop) is self contained.
* As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability.
* To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched.
* The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed.
* Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed.
[Other Info]
* N/A
----
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
|
| 2021-06-03 22:47:28 |
fossfreedom |
description |
[Impact]
The appmenu provides a in-panel global menu implementation for a number of desktop environments.
With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed.
This upload backport a series of upstream patches designated by the maintainer as a resolution of this issue.
This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes.
In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue.
[Test Plan]
* If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* Next enable the proposed repository and install the following package:
For budgie-desktop budgie-appmenu-applet
For mate-desktop mate-applet-appmenu
For xfce-desktop xfce4-appmenu-plugin
* Logout and login
* Repeat the vscode tests above - note this time that the panel crash actions do not occur.
* Next confirm that no additional panel instabilities occur with the following application types
Libreoffice
Gtk based game such as Aislerot (solitaire) that do have menus
CSD based apps such as GNOME Calculator that dont have global menu support
Try a broad range of apps found on your desktop menu.
[Where problems could occur]
* Any potential issues with this upload is strictly limited to the package itself - there will be no regression in any other components since the package (per desktop) is self contained.
* As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability.
* To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched.
* The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed.
* Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed.
[Other Info]
* N/A
----
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
[Impact]
The appmenu provides a in-panel global menu implementation for a number of desktop environments.
With QT apps such as VSCode, performing certain functions makes the appmenu produce a segmentation fault. Under Budgie, the panel restarts - and does cause the whole user session to be restarted. Under XFCE a dialog is displayed indicating that the appmenu has crashed.
This upload backports a series of upstream patches designated by the maintainer as a resolution of this issue (https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/327)
This occurs with the v0.7.3 series of appmenu uploaded to focal and groovy. v0.7.6 that is included with hirsute already contains the fixes.
In addition whilst developing this patch it was found that the package itself FTBFS. A patch from upstream is included to resolve this issue.
[Test Plan]
* If using the snap version of vscode, start vscode and observe the menu in the panel. Click on the panel menu option. If using Budgie, observe that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* If using the deb version of vscode, start vscode and observe the menu in the panel. Click on the File menu and attempt to open a folder. If using Budgie, bbserve that the panel restarts i.e. crashes. If using XFCE observe a dialog displayed indicating a crash.
* Next enable the proposed repository and install the following package:
For budgie-desktop budgie-appmenu-applet
For mate-desktop mate-applet-appmenu
For xfce-desktop xfce4-appmenu-plugin
* Logout and login
* Repeat the vscode tests above - note this time that the panel crash actions do not occur.
* Next confirm that no additional panel instabilities occur with the following application types
Libreoffice
Gtk based game such as Aislerot (solitaire) that do have menus
CSD based apps such as GNOME Calculator that dont have global menu support
Try a broad range of apps found on your desktop menu.
[Where problems could occur]
* Any potential issues with this upload is strictly limited to the package itself - there will be no regression in any other components since the package (per desktop) is self contained.
* As to the package itself - I suppose the worse case scenario is that not all the patches have been identified and cherry-picked and potentially there could be a further regression causing panel instability.
* To mitigate this I have carefully reviewed the commits released since 0.7.3 was released by upstream and I haven't identified any commits specifically in this area of code that has been patched.
* The worse case scenario is that the global menu for a users desktop will have to be removed by the user if any additional regressions are identified over and beyond the issues being fixed.
* Additional mitigation of the risks are the additional regression tests added to the test plan to cover a broader range to application types beyond the Qt apps crash issue being fixed.
[Other Info]
* N/A
----
$lsb_release -rd
Description: Ubuntu 20.04.2 LTS
Release: 20.04
Opening VS Code, particularly folders, causes the Vala-panel-appmenu to have segment fault on xfce4 and in the case of Budgie ends the entire user session as the budgie-panel cannot handle it. Backporting commits from 0.7.5 into the current release appears to fix the issue, I believe fossfreedom also backported another commit to aid in building the source properly.
The crash log of Budgie-panel caused by vala-panel-appmenu has been attached.
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu
diff patch
https://launchpad.net/~ubuntubudgie-dev/+archive/ubuntu/appmenu/+files/vala-panel-appmenu_0.7.3+dfsg1-2_0.7.3+dfsg1-2ubuntu1~ppa1.diff.gz
More information can be found here
https://github.com/UbuntuBudgie/budgie-desktop/issues/68#issuecomment-852748452
https://github.com/solus-project/budgie-desktop/issues/2112
https://gitlab.com/vala-panel-project/vala-panel-appmenu/-/issues/347
https://github.com/microsoft/vscode/issues/125012
https://gitlab.xfce.org/xfce/xfce4-panel/-/issues/498 |
|
| 2021-06-03 22:51:16 |
fossfreedom |
vala-panel-appmenu (Ubuntu Groovy): status |
Confirmed |
In Progress |
|
| 2021-06-03 22:54:24 |
fossfreedom |
attachment added |
|
Focal debdiff https://bugs.launchpad.net/ubuntu/+source/vala-panel-appmenu/+bug/1930615/+attachment/5502255/+files/focal.debdiff |
|
| 2021-06-04 00:32:00 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2021-06-08 21:55:38 |
Brian Murray |
vala-panel-appmenu (Ubuntu Groovy): status |
In Progress |
Fix Committed |
|
| 2021-06-08 21:55:41 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-06-08 21:55:44 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2021-06-08 21:55:50 |
Brian Murray |
tags |
patch |
patch verification-needed verification-needed-groovy |
|
| 2021-06-08 22:46:50 |
Brian Murray |
vala-panel-appmenu (Ubuntu Focal): status |
Confirmed |
Fix Committed |
|
| 2021-06-08 22:46:58 |
Brian Murray |
tags |
patch verification-needed verification-needed-groovy |
patch verification-needed verification-needed-focal verification-needed-groovy |
|
| 2021-06-09 17:29:36 |
Jacob Vlijm |
tags |
patch verification-needed verification-needed-focal verification-needed-groovy |
patch verification-done-focal verification-needed verification-needed-groovy |
|
| 2021-06-09 18:53:15 |
fossfreedom |
tags |
patch verification-done-focal verification-needed verification-needed-groovy |
patch verification-done verification-done-focal verification-done-groovy |
|
| 2021-06-16 05:04:12 |
Launchpad Janitor |
vala-panel-appmenu (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-06-16 05:04:17 |
Chris Halse Rogers |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-06-16 05:08:48 |
Launchpad Janitor |
vala-panel-appmenu (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
