libblkid: no bcache UUID due to ambivalent detection of bcache and xfs_external_log for regular xfs in bcache backing device

Bug #1858802 reported by Mauricio Faria de Oliveira
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
util-linux (Debian)
Fix Released
Unknown
util-linux (Ubuntu)
Medium
Mauricio Faria de Oliveira
Xenial
Medium
Mauricio Faria de Oliveira
Bionic
Medium
Mauricio Faria de Oliveira
Disco
Medium
Mauricio Faria de Oliveira
Eoan
Medium
Mauricio Faria de Oliveira
Focal
Medium
Mauricio Faria de Oliveira

Bug Description

[Impact]

 * Users with an XFS filesystem on top of bcache
   (this is seen on some ceph, cloud deployments)
   might fail to reference the bcache device by
   UUID or other udev properties.

 * The journal of the regular XFS filesystem in
   the bcache device is incorrectly detected as
   an XFS external log; so two superblocks are
   detected (bcache and xfs_external_log).

 * Thus blkid fails with ambivalent superblocks
   detected then doesn't provide the usual udev
   properties (UUID, etc.)

 * The fix improves the probe function for XFS
   external log so it detects it's regular XFS
   and bails out.

[Test Case]

 * See test steps detailed in comment #7 and later.
   - Create an XFS filesystem with the journal/log
     in the beginning of the bcache device (< 256K).
   - Stop the bcache device.
   - Run '$ blkid -o udev -p $BCACHE_BACKING_DEVICE'.

   $ sudo make-bcache -B $BACKING_DEV
   $ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
   $ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop
   $ sudo blkid -o udev -p $BACKING_DEV

[Regression Potential]

 * The patch only changes the detection function
   for XFS external log to be more general about
   the sector where the magic of regular XFS may
   be found (which is shifted inside the bcache.)

 * It still checks at sector zero (the only one
   checked previously), so this behavior didn't
   change.

 * Possible regressions are actual XFS external
   log devices that are not anymore detected as
   such. (Although that would probably indicate
   a different bug in libblkid.)

[Other Info]
 * upstream commit:
   https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=d756af7d640c51ce8d1414607bd3f17eeecf2424

Changed in util-linux (Ubuntu):
status: New → In Progress
assignee: nobody → Mauricio Faria de Oliveira (mfo)
summary: libblkid: no bcache UUID due to ambivalent detection of bcache and
- xfs_external_log for regular xfs in bcache device
+ xfs_external_log for regular xfs in bcache backing device
Changed in util-linux (Ubuntu Focal):
importance: Undecided → Medium
Changed in util-linux (Ubuntu Eoan):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Mauricio Faria de Oliveira (mfo)
Changed in util-linux (Ubuntu Disco):
status: New → Invalid
Changed in util-linux (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Mauricio Faria de Oliveira (mfo)
Changed in util-linux (Ubuntu Xenial):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Mauricio Faria de Oliveira (mfo)
tags: added: sts sts-sponsor-mfo
Changed in util-linux (Ubuntu Disco):
status: Invalid → In Progress
importance: Undecided → Medium
assignee: nobody → Mauricio Faria de Oliveira (mfo)
description: updated
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Attaching the debdiffs for X/B/D/E/F for reference.

The package built successfully on all architectures
for all releases considered (X/B/D/E/F) in PPA [1].

The test results are positive: (see next comments)

- the latest version in -updates (X/B/D/F) or -proposed (E) fails
  with ambivalent results detected (bcache + xfs external log)
  and no UUID/other variables are printed.

- the version with the patch/from the PPA [1] succeeds
  with only bcache detected, and prints the UUID/other variables.

The autopkgtest results ran against the PPA are positive.
All of them have a 'exitcode' of zero. (see next comments)

(Note: there's an util-linux in eoan-proposed that needs
work on its autopkgtest failures before this is uploaded,
which will be worked first. Eoan debdiff is on top of it.)

[1] https://launchpad.net/~mfo/+archive/ubuntu/lp1858802-sru/

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test Steps:
---

# Document versions
lsb_release -cs
uname -rv
dpkg -s bcache-tools xfsprogs | grep -i version

# Create disk image
DISK_IMG=disk.img
rm -f $DISK_IMG
dd if=/dev/zero of=$DISK_IMG bs=1G count=0 seek=1

# Create bcache backing device from disk image
BACKING_DEV=$(sudo losetup --find --show $DISK_IMG)
sudo make-bcache -B $BACKING_DEV
echo $BACKING_DEV | sudo tee /sys/fs/bcache/register # for Disco only.
sleep 1

# Create xfs on its bcache device
BCACHE_DEV="$(readlink -e /sys/block/$(basename $BACKING_DEV)/bcache/dev)"
BCACHE_DEV="/dev/$(basename $BCACHE_DEV)"
sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
sleep 1

# Stop bcache device to flush (needed)
echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop
sleep 1

# Check signatures for XFS and XFS journal (both before 0x40000 / 256K)
sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'

# Test old version
dpkg -s libblkid1 | grep -i version
sudo blkid -o udev -p $BACKING_DEV

# Install new version
sudo add-apt-repository ppa:mfo/lp1858802-sru
sudo apt update
sudo apt install -y libblkid1

# Test new version
dpkg -s libblkid1 | grep -i version
sudo blkid -o udev -p $BACKING_DEV

# Stop loop/backing device
sudo losetup -d $BACKING_DEV

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test :: focal

$ lsb_release -cs
focal

$ uname -rv
5.4.0-9-generic #12-Ubuntu SMP Mon Dec 16 22:34:19 UTC 2019

$ dpkg -s bcache-tools xfsprogs | grep -i version
Version: 1.0.8-3
Version: 5.2.1-1ubuntu1

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00008000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

Before:

$ dpkg -s libblkid1 | grep -i version
Version: 2.34-0.1ubuntu4

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

After:

$ dpkg -s libblkid1 | grep -i version
Version: 2.34-0.1ubuntu5

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=dc12092f-0bf6-48f7-913c-6249c8506dab
ID_FS_UUID_ENC=dc12092f-0bf6-48f7-913c-6249c8506dab
ID_FS_TYPE=bcache
ID_FS_USAGE=other

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test :: eoan

$ lsb_release -cs
eoan

$ uname -rv
5.3.0-26-generic #28-Ubuntu SMP Wed Dec 18 05:37:46 UTC 2019

$ dpkg -s bcache-tools xfsprogs | grep -i version
Version: 1.0.8-3
Version: 5.0.0-1ubuntu1

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

Before:

$ dpkg -s libblkid1 | grep -i version
Version: 2.34-0.1ubuntu2.1

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

After:

$ dpkg -s libblkid1 | grep -i version
Version: 2.34-0.1ubuntu2.2

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=b42bee00-cc30-4966-8f09-6cddf2ebddf8
ID_FS_UUID_ENC=b42bee00-cc30-4966-8f09-6cddf2ebddf8
ID_FS_TYPE=bcache
ID_FS_USAGE=other

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test :: disco

$ lsb_release -cs
disco

$ uname -rv
5.0.0-37-generic #40-Ubuntu SMP Thu Nov 14 00:14:01 UTC 2019

$ dpkg -s bcache-tools xfsprogs | grep -i version
Version: 1.0.8-3
Version: 4.15.1-1ubuntu1

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

Before:

$ dpkg -s libblkid1 | grep -i version
Version: 2.33.1-0.1ubuntu3

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

After:

$ dpkg -s libblkid1 | grep -i version
Version: 2.33.1-0.1ubuntu4

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=c3c22fe2-cb68-4966-8cde-aba13a079201
ID_FS_UUID_ENC=c3c22fe2-cb68-4966-8cde-aba13a079201
ID_FS_TYPE=bcache
ID_FS_USAGE=other

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test :: bionic

$ lsb_release -cs
bionic

$ uname -rv
4.15.0-72-generic #81-Ubuntu SMP Tue Nov 26 12:20:02 UTC 2019

$ dpkg -s bcache-tools xfsprogs | grep -i version
Version: 1.0.8-2build1
Version: 4.9.0+nmu1ubuntu2

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

Before:

$ dpkg -s libblkid1 | grep -i version
Version: 2.31.1-0.4ubuntu3.4

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

After:

$ dpkg -s libblkid1 | grep -i version
Version: 2.31.1-0.4ubuntu3.5

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=46a3afa8-2c87-41b0-9c35-b766e0dddd6c
ID_FS_UUID_ENC=46a3afa8-2c87-41b0-9c35-b766e0dddd6c
ID_FS_TYPE=bcache
ID_FS_USAGE=other

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Test :: xenial

$ lsb_release -cs
xenial

$ uname -rv
4.4.0-171-generic #200-Ubuntu SMP Tue Dec 3 11:04:55 UTC 2019

$ dpkg -s bcache-tools xfsprogs | grep -i version
Version: 1.0.8-2
Version: 4.3.0+nmu1ubuntu1.1

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 00 14 |................|

Before:

$ dpkg -s libblkid1 | grep -i version
Version: 2.27.1-6ubuntu3.9

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

After:

$ dpkg -s libblkid1 | grep -i version
Version: 2.27.1-6ubuntu3.10

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=9dd54115-df08-4e6d-99eb-fb322fcfc04e
ID_FS_UUID_ENC=9dd54115-df08-4e6d-99eb-fb322fcfc04e
ID_FS_TYPE=bcache
ID_FS_USAGE=other

description: updated
tags: added: patch
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Eric Desrochers (slashd)
tags: added: sts-sponsor-slashd-focal
Revision history for this message
Eric Desrochers (slashd) wrote :

Sponsored in focal.

* Fix approved upstream
* Bug reported and patch submitted to upstream Debian.

Please keep an eye on the excuses page for util-linux.

- Eric

tags: removed: sts-sponsor-slashd-focal
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

The autopkgtest failures for focal are unrelated to this upload.

- piuparts/1.1.0:

There's changes from piuparts 1.1.0 to 1.1.1 (released a few hours ago) that resolved the issues, as seen in the autopkgtests page for piuparts. Requested re-runs.

- openjdk:

The failing test timed-out on armhf and is reported as FLAKY in the log; requested re-run.
(openjdk probably is not checking for XFS filesystems on bcache devices :)

  autopkgtest [09:28:36]: ERROR: timed out on command "<...>
  autopkgtest [09:28:36]: test jdk: -----------------------]
  autopkgtest [09:28:40]: test jdk: - - - - - - - - - - results - - - - - - - - - -
  jdk FLAKY timed out

- cmake-extras/1.3+17.04.20170310-5:

There's changes in focal-proposed (cmake-extras 1.3+17.04.20170310-7) that address autopkgtest failures, but looking at its test log, it fixed 1 of 2 failures (fixed 'copyrighttest' but not 'includechecker', and regressed 'findgmock'. so _not_ requesting re-runs.
Thus apparently not quite there yet; but anyway, not XFS/bcache either.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

The uploads to stable releases are blocked on LP#1845529 currently in eoan-proposed.
It was pending analysis of autopkgtest failures as well, and I provided those today.
(cyphermox removed the tag 'verification-needed' from that bug, so maybe it'll move.)

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

LP#1845529 is now fix released (thanks @sil2100), and the SRUs for E/B/X have been uploaded.
(The SRU for D is skipped as D will be EOL in 7 days, the time needed to stay in -proposed.)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package util-linux - 2.34-0.1ubuntu5

---------------
util-linux (2.34-0.1ubuntu5) focal; urgency=medium

  * d/p/libblkid-xfs-log-check-for-reg-xfs-on-more-sectors.patch:
    fix ambivalent detection of bcache and xfs_external_log
    due to regular xfs on bcache backing device. (LP: #1858802)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 08 Jan 2020 16:03:19 -0300

Changed in util-linux (Ubuntu Focal):
status: In Progress → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Mauricio, or anyone else affected,

Accepted util-linux into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/util-linux/2.34-0.1ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in util-linux (Ubuntu Eoan):
status: In Progress → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Mauricio, or anyone else affected,

Accepted util-linux into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/util-linux/2.31.1-0.4ubuntu3.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in util-linux (Ubuntu Bionic):
status: In Progress → Fix Committed
Changed in util-linux (Ubuntu Xenial):
status: In Progress → Fix Committed
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Mauricio, or anyone else affected,

Accepted util-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/util-linux/2.27.1-6ubuntu3.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in util-linux (Ubuntu Disco):
status: In Progress → Won't Fix
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done on eoan-proposed.
Now libblkid1 detects only the bcache superblock and prints udev/uuid variables.

$ lsb_release -cs
eoan

$ DISK_IMG=disk.img
$ rm -f $DISK_IMG
$ dd if=/dev/zero of=$DISK_IMG bs=1G count=0 seek=1
$ BACKING_DEV=$(sudo losetup --find --show $DISK_IMG)
$ sudo make-bcache -B $BACKING_DEV
$ BCACHE_DEV="$(readlink -e /sys/block/$(basename $BACKING_DEV)/bcache/dev)"
$ BCACHE_DEV="/dev/$(basename $BCACHE_DEV)"
$ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
$ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

eoan-updates:
---

$ dpkg -s libblkid1 | grep -i version:
Version: 2.34-0.1ubuntu2.1

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

eoan-proposed:
---

$ apt-cache madison libblkid1 | grep proposed
 libblkid1 | 2.34-0.1ubuntu2.2 | http://archive.ubuntu.com/ubuntu eoan-proposed/main amd64 Packages

$ sudo apt install libblkid1 -y

$ dpkg -s libblkid1 | grep -i version:
Version: 2.34-0.1ubuntu2.2

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=55bac736-a3dc-4d9a-80e9-330ba46dd97d
ID_FS_UUID_ENC=55bac736-a3dc-4d9a-80e9-330ba46dd97d
ID_FS_TYPE=bcache
ID_FS_USAGE=other

tags: added: verification-done-eoan
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done on bionic-proposed.
Now libblkid1 detects only the bcache superblock and prints udev/uuid variables.

$ lsb_release -cs
bionic

$ DISK_IMG=disk.img
$ rm -f $DISK_IMG
$ dd if=/dev/zero of=$DISK_IMG bs=1G count=0 seek=1
$ BACKING_DEV=$(sudo losetup --find --show $DISK_IMG)
$ sudo make-bcache -B $BACKING_DEV
$ BCACHE_DEV="$(readlink -e /sys/block/$(basename $BACKING_DEV)/bcache/dev)"
$ BCACHE_DEV="/dev/$(basename $BCACHE_DEV)"
$ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
$ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 02 00 |................|

bionic-updates:
---

$ dpkg -s libblkid1 | grep -i version
Version: 2.31.1-0.4ubuntu3.4

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

bionic-proposed:
---

$ apt-cache madison libblkid1 | grep proposed
 libblkid1 | 2.31.1-0.4ubuntu3.5 | http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages

$ sudo apt install libblkid1 -y

$ dpkg -s libblkid1 | grep -i version:
Version: 2.31.1-0.4ubuntu3.5

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=7879f264-a1e6-4b7f-8fd0-2565c10adc44
ID_FS_UUID_ENC=7879f264-a1e6-4b7f-8fd0-2565c10adc44
ID_FS_TYPE=bcache
ID_FS_USAGE=other

tags: added: verification-done-bionic
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done on xenial-proposed.
Now libblkid1 detects only the bcache superblock and prints udev/uuid variables.

$ lsb_release -cs
xenial

$ DISK_IMG=disk.img
$ rm -f $DISK_IMG
$ dd if=/dev/zero of=$DISK_IMG bs=1G count=0 seek=1
$ BACKING_DEV=$(sudo losetup --find --show $DISK_IMG)
$ sudo make-bcache -B $BACKING_DEV
$ BCACHE_DEV="$(readlink -e /sys/block/$(basename $BACKING_DEV)/bcache/dev)"
$ BCACHE_DEV="/dev/$(basename $BCACHE_DEV)"
$ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
$ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop

$ sudo hexdump -C $BACKING_DEV | grep -m2 -e XFSB -e 'fe ed ba be'
00002000 58 46 53 42 00 00 10 00 00 00 00 00 00 03 f0 00 |XFSB............|
00007000 fe ed ba be 00 00 00 01 00 00 00 02 00 00 00 14 |................|

xenial-updates:
---

$ dpkg -s libblkid1 | grep -i version
Version: 2.27.1-6ubuntu3.9

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_AMBIVALENT=other:bcache other:xfs_external_log

xenial-proposed:
---

$ apt-cache madison libblkid1 | grep proposed
 libblkid1 | 2.27.1-6ubuntu3.10 | http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages

$ sudo apt install libblkid1 -y

$ dpkg -s libblkid1 | grep -i version
Version: 2.27.1-6ubuntu3.10

$ sudo blkid -o udev -p $BACKING_DEV
ID_FS_UUID=6cdf846c-52ea-4f24-8554-7302c41bca8f
ID_FS_UUID_ENC=6cdf846c-52ea-4f24-8554-7302c41bca8f
ID_FS_TYPE=bcache
ID_FS_USAGE=other

tags: added: verification-done-xenial
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (util-linux/2.27.1-6ubuntu3.10)

All autopkgtests for the newly accepted util-linux (2.27.1-6ubuntu3.10) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

nplan/0.32~16.04.7 (amd64)
mysql-5.7/5.7.28-0ubuntu0.16.04.2 (i386, ppc64el, amd64)
zfs-linux/0.6.5.6-0ubuntu28 (ppc64el)
lxd/2.0.11-0ubuntu1~16.04.4 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#util-linux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (util-linux/2.31.1-0.4ubuntu3.5)

All autopkgtests for the newly accepted util-linux (2.31.1-0.4ubuntu3.5) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

lxcfs/3.0.3-0ubuntu1~18.04.1 (s390x)
gnocchi/4.2.5-0ubuntu1 (armhf)
systemd/237-3ubuntu10.33 (amd64)
postgresql-10/10.10-0ubuntu0.18.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#util-linux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (util-linux/2.34-0.1ubuntu2.2)

All autopkgtests for the newly accepted util-linux (2.34-0.1ubuntu2.2) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:

tracker/2.3.0-1 (armhf)
kopanocore/8.7.0-3build2 (armhf)
mir/1.4.0-0ubuntu3 (armhf)
ola/unknown (armhf)
systemd/242-7ubuntu3.2 (s390x)
glib2.0/2.62.1-1 (i386)
openjdk-lts/11.0.5+10-0ubuntu1.1 (armhf, arm64)
sbd/1.4.0-18-g5e3283c-1ubuntu1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/eoan/update_excuses.html#util-linux

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

SRU team,

The autopkgtests regressions reported for the three releases (xenial/bionic/eoan)
were all* transient issues resolved with re-runs (see 'pass' status records below).

(*) The only the exception (not a transient issue) is gnocchi/bionic/armhf,
which is _not_ a regression either as the same error happens with -updates
(see both 'fail' status records below, with versions in -proposed/-updates.)

The updated status (passing tests) is already reflected in pending-sru [1].

Thanks,
Mauricio

[1] https://people.canonical.com/~ubuntu-archive/pending-sru.html

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

xenial:

- nplan/0.32~16.04.7 (amd64)
  - 0.32~16.04.7 util-linux/2.27.1-6ubuntu3.10 2020-01-28 11:12:12 UTC 0h 24m 52s mfo pass

- mysql-5.7/5.7.28-0ubuntu0.16.04.2 (i386, ppc64el, amd64)
  - (new version in -updates fixed issues.)
  - 5.7.29-0ubuntu0.16.04.1 util-linux/2.27.1-6ubuntu3.10 2020-01-28 11:36:59 UTC 0h 50m 56s mfo pass
  - 5.7.29-0ubuntu0.16.04.1 util-linux/2.27.1-6ubuntu3.10 2020-01-28 11:07:56 UTC 0h 25m 01s mfo pass
  - 5.7.29-0ubuntu0.16.04.1 util-linux/2.27.1-6ubuntu3.10 2020-01-28 11:07:56 UTC 0h 25m 01s mfo pass

- zfs-linux/0.6.5.6-0ubuntu28 (ppc64el)
  - 0.6.5.6-0ubuntu28 util-linux/2.27.1-6ubuntu3.10 2020-01-28 10:42:41 UTC 0h 07m 43s mfo pass

- lxd/2.0.11-0ubuntu1~16.04.4 (s390x)
  - 2.0.11-0ubuntu1~16.04.4 util-linux/2.27.1-6ubuntu3.10 2020-01-28 10:36:48 UTC 0h 04m 46s mfo pass

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

bionic:

- lxcfs/3.0.3-0ubuntu1~18.04.1 (s390x)
  - 3.0.3-0ubuntu1~18.04.1 util-linux/2.31.1-0.4ubuntu3.5 2020-01-28 11:07:15 UTC 0h 02m 02s mfo pass

- gnocchi/4.2.5-0ubuntu1 (armhf)
  - (same failure in -updates too, not a regression introduced in -proposed)
  - 4.2.5-0ubuntu1 util-linux/2.31.1-0.4ubuntu3.4 2020-01-28 13:48:01 UTC 0h 29m 16s mfo fail
  - 4.2.5-0ubuntu1 util-linux/2.31.1-0.4ubuntu3.5 2020-01-28 11:31:54 UTC 0h 30m 53s mfo fail

- systemd/237-3ubuntu10.33 (amd64)
  - 237-3ubuntu10.33 util-linux/2.31.1-0.4ubuntu3.5 2020-01-28 15:04:17 UTC 0h 38m 03s mfo pass

- postgresql-10/10.10-0ubuntu0.18.04.1 (armhf)
  - 10.10-0ubuntu0.18.04.1 util-linux/2.31.1-0.4ubuntu3.5 2020-01-28 11:14:19 UTC 0h 11m 04s mfo pass

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

eoan:

- tracker/2.3.0-1 (armhf)
  - 2.3.0-1 util-linux/2.34-0.1ubuntu2.2 2020-01-28 13:29:26 UTC 0h 09m 34s mfo pass

- kopanocore/8.7.0-3build2 (armhf)
  - 8.7.0-3build2 util-linux/2.34-0.1ubuntu2.2 2020-01-28 11:22:03 UTC 0h 09m 49s mfo pass

- mir/1.4.0-0ubuntu3 (armhf)
  - 1.4.0-0ubuntu3 util-linux/2.34-0.1ubuntu2.2 2020-01-28 11:13:28 UTC 0h 04m 03s mfo pass

- ola/unknown (armhf)
  - 0.10.7.nojsmin-2 util-linux/2.34-0.1ubuntu2.2 2020-01-28 11:25:11 UTC 0h 13m 43s mfo pass

- systemd/242-7ubuntu3.2 (s390x)
  - 237-3ubuntu10.33 util-linux/2.31.1-0.4ubuntu3.5 2020-01-28 15:04:17 UTC 0h 38m 03s mfo pass

- glib2.0/2.62.1-1 (i386)
  - 2.62.1-1 util-linux/2.34-0.1ubuntu2.2 2020-01-28 11:30:50 UTC 0h 12m 25s mfo pass

- openjdk-lts/11.0.5+10-0ubuntu1.1 (armhf, arm64)
  - FLAKY timed out (both archs)

- sbd/1.4.0-18-g5e3283c-1ubuntu1 (i386)
  - 1.4.0-18-g5e3283c-1ubuntu1 util-linux/2.34-0.1ubuntu2.2 2020-01-28 16:03:28 UTC 0h 14m 10s mfo pass

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for util-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package util-linux - 2.31.1-0.4ubuntu3.5

---------------
util-linux (2.31.1-0.4ubuntu3.5) bionic; urgency=medium

  * d/p/libblkid-xfs-log-check-for-reg-xfs-on-more-sectors.patch:
    fix ambivalent detection of bcache and xfs_external_log
    due to regular xfs on bcache backing device. (LP: #1858802)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 08 Jan 2020 15:31:23 -0300

Changed in util-linux (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package util-linux - 2.27.1-6ubuntu3.10

---------------
util-linux (2.27.1-6ubuntu3.10) xenial; urgency=medium

  * d/p/libblkid-xfs-log-check-for-reg-xfs-on-more-sectors.patch:
    fix ambivalent detection of bcache and xfs_external_log
    due to regular xfs on bcache backing device. (LP: #1858802)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 08 Jan 2020 11:00:18 -0300

Changed in util-linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package util-linux - 2.34-0.1ubuntu2.2

---------------
util-linux (2.34-0.1ubuntu2.2) eoan; urgency=medium

  * d/p/libblkid-xfs-log-check-for-reg-xfs-on-more-sectors.patch:
    fix ambivalent detection of bcache and xfs_external_log
    due to regular xfs on bcache backing device. (LP: #1858802)

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 08 Jan 2020 15:59:37 -0300

Changed in util-linux (Ubuntu Eoan):
status: Fix Committed → Fix Released
Changed in util-linux (Debian):
status: Unknown → New
Changed in util-linux (Debian):
status: New → Confirmed
Changed in util-linux (Debian):
status: Confirmed → Fix Released
tags: removed: sts-sponsor-mfo
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.