Fsck Check Doesn't Remove All Text After Finished

Bug #219867 reported by belak on 2008-04-20
8
Affects Status Importance Assigned to Milestone
e2fsprogs (Ubuntu)
Undecided
Unassigned
usplash (Ubuntu)
Low
Unassigned
usplash-theme-ubuntu (Ubuntu)
Low
Unassigned

Bug Description

When I start up and Fsck runs (Thank goodness not very often...) it used to display the text in the terminal when it ran, exiting out of usplash. It's good that finally got fixed, but now, when Fsck ends, it leaves the "Checking Drive Press Esc to Cancel" (or whatever it says on the left side).

I know this really isn't important, but I figured that you wouldn't want to leave this there. It is kinda ugly, having that show up throughout the whole boot.

Theodore Ts'o (tytso) wrote :

This isn't an e2fsprogs bug; the message "Checking Drive Press Esc. to Cancel" isn't printed by e2fsprogs.

belak (kaleb-elwert) wrote :

Well, I don't know what it's in, but I'd think it was e2fsprogs...

I guess not.

This is in initscripts.
I would assume it effects the following files: /lib/init/usplash-fsck-functions.sh, and /etc/init.d/checkfs.sh.

I don't know if I missed any relevant files.
Any fixes?

Theodore Ts'o (tytso) wrote :

Message is not printed by e2fsprogs. Reassigning to usplash where this bug has a better chance of being paid attention to....

Changed in e2fsprogs:
status: New → Invalid
Andrea Gasparini (gaspa) wrote :

Confirmed. draw_status() of libusplash overflow with a status string too long.

Changed in usplash:
assignee: nobody → gaspa
status: New → Confirmed
Colin Watson (cjwatson) wrote :

As well as fixing usplash's behaviour on overflow, it seems to me that perhaps initscripts (/lib/init/usplash-fsck-functions.sh) ought to use shorter strings if we know that longer ones will overflow usplash.

Andrea Gasparini (gaspa) wrote :

colin: maybe it could be made some sort of magic in initscripts.

But it could be not so simple, as the "status_width" is a theme specific parameter. (if we're lucky they're all the same... but if not... :P )

Martin Pitt (pitti) wrote :

The best solution IMHO is to just make the status column wide enough to hold the entire string. That should be a trivial change in the theme. Andrea said he'd look into this, thanks!

Andrea Gasparini (gaspa) on 2008-10-17
Changed in usplash-theme-ubuntu:
assignee: nobody → gaspa
status: New → Confirmed
Andrea Gasparini (gaspa) wrote :

Hi,
there's a patch for the size of the theme: I enlarged status_width from 35 to 200. 35 it's definitely too few for a something different than [ok] or [fail]... besides I don't see any strong reason to have a little statuswidth.
It's IMHO up to the scripts that use usplash to use TEXT and STATUS that doesn't overlap each other.

I tested it that length with the longest TEXT string I found in /lib/init/usplash-fsck-functions.sh and found a text_x and text_width that could make fit with the longest STATUS string.
Strings are:
TEXT: "Routine check of drives: /dev/hda6..."
and
STATUS: "100% (stage 5/5, 12345678/123456789)"

Andrea Gasparini (gaspa) wrote :

As well of the theme patch, I think that usplash should truncate too long status lines.
Attached a patch that do exactly this.

Andrea Gasparini (gaspa) on 2008-10-17
Changed in usplash:
assignee: gaspa → pitti
Changed in usplash-theme-ubuntu:
assignee: gaspa → pitti
Martin Pitt (pitti) wrote :

Thanks Andrea! Your theme patch needs some further tweaking, the text column is way too small now and generates a lot of overflows (try booting without quiet). I'll have a look into it.

Changed in usplash:
status: Confirmed → In Progress
Changed in usplash-theme-ubuntu:
status: Confirmed → In Progress
Martin Pitt (pitti) wrote :

I played around some more, and it's not easy to patch all themes in a consistent fashion so that it doesn't look worse than now (non-centered, etc) as well as avoid all the overflows. But the latter aren't really so bad, so I don't think we should rush this into intrepid at this point. We should fix this in a better way in jaunty, maybe by using the main text column instead of the status bar, and adding functionality to usplash to replace already existing text in the main text column.

Changed in usplash-theme-ubuntu:
status: In Progress → Confirmed
Bryce Harrington (bryce) on 2008-11-03
Changed in usplash-theme-ubuntu:
importance: Undecided → Low
Changed in usplash:
importance: Undecided → Low
Martin Pitt (pitti) wrote :

I unsubscribed sponsoring team for now, since the patch isn't sufficient.

Martin Pitt (pitti) on 2009-01-27
Changed in usplash-theme-ubuntu:
assignee: pitti → nobody
Changed in usplash:
assignee: pitti → nobody
status: In Progress → Triaged
Phillip Susi (psusi) wrote :

The usplash package has been superseded by plymouth and has been removed from the Ubuntu archive. Closing all related bugs.

Changed in usplash (Ubuntu):
status: Triaged → Invalid
Phillip Susi (psusi) wrote :

The usplash-theme-ubuntu package has been removed from Ubuntu. Closing all related bugs.

Changed in usplash-theme-ubuntu (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers