Should unmount at the end of installation.

Bug #457510 reported by Evan on 2009-10-21
This bug affects 1 person
Affects Status Importance Assigned to Milestone
usb-creator (Ubuntu)

Bug Description

Binary package hint: usb-creator

usb-creator was made to not unmount the filesystem in karmic because I was worried that we'd be ripping the mount point out from under the user if they had a nautilus window open. However, there are problems with this. Calling sync rather than umount has the disadvantage that it will flush buffers for all block devices. Even running sync does not appear to be sufficient for some cases (run KVM with the device just after running usb-creator).

The user shouldn't be mucking about with the disk while it's installing anyway. In lucid, lets switch back to unmounting the filesystem. We can retain the "flushing writes to the disk" message and just use it to describe the umount call. However, this message should also contain a pulsing progress bar, rather than one fixed at a certain percentage.

Evan (ev) on 2009-10-21
Changed in usb-creator (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Evan (ev) on 2009-10-22
description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-creator - 0.2.13

usb-creator (0.2.13) lucid; urgency=low

  [ Evan Dandrea ]
  * Set the install window as translatable. Thanks Milo Casagrande
    (LP: #414742).
  * Fix a typo in the Windows frontend (LP: #454926).
  * Use a close button instead of a quit button in the GTK+ frontend
    (LP: #285916).
  * Change the program title (not the program name) to "Startup Disk
    Creator" as usb-creator writes to more than just USB disks these days
    (LP: #275138).
  * In the GTK+ frontend, scan the download directory on startup and add
    all the CD and disk images (LP: #441104).
  * Expand the path provided by the -i option to its absolute
    (LP: #458497).
  * Unmount the target device rather than calling sync (LP: #457510).

  [ Martin Pitt ]
  * bin/usb-creator-helper: Supply start-time in the PolicyKit subject struct,
    so that this also works with current polkit-1 in lucid.
 -- Martin Pitt <email address hidden> Tue, 08 Dec 2009 10:51:37 +0100

Changed in usb-creator (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers