Comment 4 for bug 1413494

Yu Ning (yuningdodo) wrote :

Brian, thanks for the review, here is the declaration of unmount_all():

def unmount_all(udisks, parent):
    '''Unmounts the device or any partitions of the device.'''

As you can see the last param is expected to be parent, and in my test if we pass "dev" to it it can't unmount properly, so I think this may be a typo of "parent_dev".

BTW, let me propose a merge request with this patch for better reviewing.