upstart test suite assumes no inherited fds

Bug #926473 reported by Steve Langasek on 2012-02-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
upstart (Ubuntu)
Medium
Steve Langasek

Bug Description

When building under bzr-builddeb, upstart's test suite fails consistently:

...ensure sane fds with no console, no script
BAD: fd 3 is unexpected valid
        at tests/test_job_process.c:1164 (test_run).
/bin/bash: line 5: 19389 Aborted (core dumped) ${dir}$tst
FAIL: test_job_process

The test suite seems to assume no file descriptors are open when the test starts, but that seems to not be the case here.

The test passes consistently when not running under bzr bd.

The test suite should close its file descriptors before running the test, to ensure a clean environment.

Related branches

Steve Langasek (vorlon) on 2012-02-04
Changed in upstart (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
assignee: nobody → James Hunt (jamesodhunt)
Steve Langasek (vorlon) on 2012-02-15
Changed in upstart (Ubuntu):
assignee: James Hunt (jamesodhunt) → Steve Langasek (vorlon)
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package upstart - 1.4-0ubuntu7

---------------
upstart (1.4-0ubuntu7) precise; urgency=low

  * debian/manpages/upstart-events.7: Added missing events 'container' and
    'not-container'.
  * Update 'runlevel' event emission time in upstart-events(7) (LP: #921501).
  * Merge of important upstream log fixes to avoid spinning when a job
    which leaks fds (such as 'sshd -D') is stopped (LP: #926468).
  * Merge of lp:~jamesodhunt/upstart/early-job-log-flush to allow jobs that
    _end_ very early in the boot to have their output logged.
  * debian/conf/flush-early-job-log.conf: Upstart job to force flushing of
    early job log output data when disk becomes writeable.
  * Re-enable job logging by default.

  [ Steve Langasek ]
  * init/tests/test_job_process.c: close all fds before running tests that
    check for unexpected open fds, so that files leaked from the environment
    don't cause the test suite to fail gratuitously. LP: #926473.
  * bump debhelper compat to 9 and adjust debian/rules to use the
    dpkg-buildflags interfaces, so that upstart can be cross-compiled and
    also so we pick up any future hardening flags for free.
 -- Steve Langasek <email address hidden> Thu, 16 Feb 2012 07:52:11 +0000

Changed in upstart (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers