devpts is mounted incorrectly in the non-initrd case

Bug #1244763 reported by Adam Conrad on 2013-10-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
upstart
Medium
Steve Langasek
upstart (Ubuntu)
Medium
Steve Langasek

Bug Description

In most places in Ubuntu, devpts is mounted correctly with gid=5,mode=620, however upstart itself mounts it incorrectly in the cases when it's not already mounted by something else:

init/main.c: if (system_mount ("devpts", "/dev/pts", (MS_NOEXEC | MS_NOSUID)) < 0)

Compare to, say, systemd, which does this:

#ifndef TTY_GID
#define TTY_GID 5
#endif
[...]
src/core/mount-setup.c: { "devpts", "/dev/pts", "devpts", "mode=620,gid=" STRINGIFY(TTY_GID), MS_NOSUID|MS_NOEXEC,

Please fix this up, as this will explode in special and fun ways when pt_chown goes away and we stop falling back on it as a crutch when the devpts permissions are wrong.

Related branches

Steve Langasek (vorlon) wrote :

Marking 'medium' since this code path is only used in initramfsless systems, which are not the common case.

Changed in upstart:
status: New → In Progress
Changed in upstart (Ubuntu):
status: New → In Progress
Changed in upstart:
assignee: nobody → Steve Langasek (vorlon)
Changed in upstart (Ubuntu):
assignee: nobody → Steve Langasek (vorlon)
Changed in upstart:
importance: Undecided → Medium
Changed in upstart (Ubuntu):
importance: Undecided → Medium
Changed in upstart:
status: In Progress → Fix Committed
Adam Conrad (adconrad) wrote :

This appears to have been fixed both upstream and in Ubuntu, but without the bug being twiddled.

Changed in upstart (Ubuntu):
status: In Progress → Fix Released
Changed in upstart:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers