upstart-local-bridge clobbers $PATH with its events

Bug #1235480 reported by Steve Langasek on 2013-10-04
This bug affects 1 person
Affects Status Importance Assigned to Milestone
James Hunt
upstart (Ubuntu)
Steve Langasek
Steve Langasek

Bug Description

The dbus bridge was recently fixed to not clobber $PATH in its events, but it turns out the same bug affects the local bridge.

        var = NIH_MUST (nih_sprintf (NULL, "PATH=%s", socket_path));
        NIH_MUST (nih_str_array_addp (&env, NULL, NULL, var));

This should be fixed to be called e.g. SOCKET_PATH instead. Or maybe just dropped? I'm not sure there's really a need to include this info in the event.

Related branches

Steve Langasek (vorlon) wrote :

This obviously makes the file bridge unusable for any real purposes until it's fixed.

Changed in upstart (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in upstart (Ubuntu Saucy):
assignee: nobody → James Hunt (jamesodhunt)
assignee: James Hunt (jamesodhunt) → Steve Langasek (vorlon)
Changed in upstart:
assignee: nobody → James Hunt (jamesodhunt)
Steve Langasek (vorlon) on 2013-10-04
Changed in upstart:
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package upstart - 1.10-0ubuntu6

upstart (1.10-0ubuntu6) saucy; urgency=low

  * extra/upstart-local-bridge.c: use SOCKET_PATH in our event
    environment, instead of clobbering PATH. (LP: #1235480)
 -- Steve Langasek <email address hidden> Fri, 04 Oct 2013 14:45:40 -0700

Changed in upstart (Ubuntu Saucy):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers