update-notifier can run flashplugin-installer right after the package has been updated

Bug #988531 reported by Brian Murray
58
This bug affects 12 people
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Triaged
Low
Unassigned

Bug Description

In the event that both update-notifier-common and package that uses it like flashplugin-installer are upgraded during the same run update-notifier-common will also download and install the flashplugin which is redundant and unnecessary.

Here's what Steve says about it:

09:57 <slangasek> yeah, I think I understand it now; it's specific to the two
                  packages being upgraded in the same run and u-n-c getting
                  configured first
09:58 <slangasek> oh, except I can't understand why u-n-c processes
                  flashplugin-installer at all on line 12194
10:04 <slangasek> ah yes
10:04 <slangasek> because we do a timestamp check
10:05 <slangasek> so because the hook is newer than the stamp, we process
                  unconditionally; then flashplugin-installer removes the stamp
                  file, but update-notifier-common was not configured at the
                  time flashplugin-installer was unpacked, so there's no
                  trigger; and the cron job re-downloads unnecessarily
10:06 <slangasek> but in spite of the extra cron download, flashplugin-installer
                  is configured as of the end of the apt run
10:06 <slangasek> s/configured/usable/

Tags: precise trusty
Revision history for this message
Brian Murray (brian-murray) wrote :

For reference from /var/log/apt/term.log:

Setting up update-notifier-common (0.119ubuntu8.1) ...^M
flashplugin-installer: downloading http://archive.canonical.com/pool/partner/a/adobe-flashplugin/adobe-flashplugin_11.2.202.233.orig.tar.gz^M
Installing from local file /tmp/tmpcZmnVS.gz^M
Flash Plugin installed.^M
Setting up update-notifier (0.119ubuntu8.1) ...^M
....
Setting up flashplugin-installer (11.2.202.233ubuntu2) ...^M
Setting up flashplugin-downloader:i386 (11.2.202.233ubuntu2) ...^M
...
Log ended: 2012-04-20 07:03:47

Then a cronjob email I received:

Date: Fri, 20 Apr 2012 08:27:06 -0700 (PDT)
From: Anacron <email address hidden>
To: <email address hidden>
Subject: Anacron job 'cron.daily' on flash

/etc/cron.daily/update-notifier-common:
flashplugin-installer: downloading http://archive.canonical.com/pool/partner/a/adobe-flashplugin/adobe-flashplugin_11.2.202.233.orig.tar.gz
Installing from local file /tmp/tmpgbBI__.gz
Flash Plugin installed.

tags: added: precise
Changed in update-notifier (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Jethro Beekman (jethrogb) wrote :

It is not only redundant and unnecessary, update-notifier should never install packages by itself if not configured to.

Changed in update-notifier (Ubuntu):
status: Triaged → Confirmed
Changed in update-notifier (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Chris Good (chris-good) wrote :

Still a problem in trusty.

tags: added: trusty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.