TrayIcon-Code is suboptimal

[Sven Herzberg]

The tray icon code leaves a 1 pixel wide bar in the tray area, which should not happen. The attached screenshots show two states: Updates and Notes available (while seeing the printer notification), and no updates, notes and printing available.

As you can see the printing notification (gnome-cups-icon) gets hidden completely while the update icons are replaces by one pixel bars.

[Sven Herzberg (herzi)]

Here you can see:

* printing
* music
* im
* update note
* available updates

[Sven Herzberg (herzi)]

Here you can't see:
* printing

And you can see:
* music
* im
* a thin bar
* another thin bar

[Sven Herzberg (herzi)]

It looks like you should call gtk_widget_hide() in the tray icon, not only on its content.

[Michael Vogt (mvo)]

Thanks for your bugreport.

The code calls gtk_widget_hide() on the complete EggTrayIcon. I updated to the latest version of EggTrayIcon with the recent upload, does that fix the problem for you? If not, how I reproduce those little one pixel bars?

Thanks,
 Miachel

[Sven Herzberg (herzi)]

Which package version should be the fixed one?

[Michael Vogt (mvo)]

The small lines can be seen when the panel is set to transparent.

[Crispin Flowerday (crispin-flowerday-deactivatedaccount)]

I don't see what info this bug is waiting on, so setting to Confirmed, I can see this too.

[Crispin Flowerday (crispin-flowerday-deactivatedaccount)]

I have been looking at this (it has annoyed me for a while), basically, the eggtrayicon code doesn't remove the icon from the tray when it is just hidden, you have to unrealize the icon to really get rid of it.

This patch ensures that when we call gtk_widget_hide() on a tray icon, we also call gtk_widget_unrealize(). This seems to work much better, and although it could be classed as a hack, hopefully the need for it will dissappear when gtk 2.10 comes out with the built-in object for doing this.

[Sitsofe Wheeler (sitsofe)]

Will this fix Bug #4405 ?

[Michael Vogt (mvo)]

Thanks for the patch and sorry for the long reply. I applied the patch to my bzr repository and it will be part of the next upload.

Cheers,
 Michael

[Ricardo Pérez López (ricardo)]

I think now the notification icon is too close to the icon next to it.

Maybe it could be better if the developers puts a little space around the icon.

[Ricardo Pérez López (ricardo)]

In this screenshot, you can see the notification icon very close to the amule icon.

[Sven Herzberg (herzi)]

I updated yesterday, I have now a new updates-available-icon. But unfortunately I have one thin line again (one of those lines described above). Killing update-notifier makes that line disappear.

[Michael Vogt (mvo)]

It seems that the new code leaves a (single?) thin line when it was shown and is hidden then (e.g. after applying all updates).

[Crispin Flowerday (crispin-flowerday-deactivatedaccount)]

Right, the problem is that the 'update.c' hunk from my patch is missing from the new version.

[Michael Vogt (mvo)]

*cough* Thanks!

I fixed this localy now and it will be part of the next upload.

Cheers,
 Michael

[Michael Vogt (mvo)]

The missing bit of the patch was applied and uploaded (update-notifier_0.42.1_source.changes)

[Alexander Jones (alex-weej)]

There is still hunks of space being allocated in the Notification area - something is still broken here.