2023-01-06 18:08:28 |
Renan Rodrigo |
bug |
|
|
added bug |
2023-01-06 18:09:05 |
Renan Rodrigo |
nominated for series |
|
Ubuntu Jammy |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
bug task added |
|
update-notifier (Ubuntu Jammy) |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
nominated for series |
|
Ubuntu Lunar |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
bug task added |
|
update-notifier (Ubuntu Lunar) |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
nominated for series |
|
Ubuntu Bionic |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
bug task added |
|
update-notifier (Ubuntu Bionic) |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
nominated for series |
|
Ubuntu Xenial |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
bug task added |
|
update-notifier (Ubuntu Xenial) |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
nominated for series |
|
Ubuntu Focal |
|
2023-01-06 18:09:05 |
Renan Rodrigo |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
2023-01-06 18:17:28 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~renanrodrigo/update-notifier/+git/update-notifier/+merge/435293 |
|
2023-01-06 18:19:20 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~renanrodrigo/update-notifier/+git/update-notifier/+merge/435294 |
|
2023-01-06 18:20:33 |
Renan Rodrigo |
merge proposal linked |
|
https://code.launchpad.net/~renanrodrigo/update-notifier/+git/update-notifier/+merge/435295 |
|
2023-01-06 18:21:03 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~renanrodrigo/update-notifier/+git/update-notifier/+merge/435296 |
|
2023-01-19 10:58:50 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~renanrodrigo/ubuntu/+source/update-notifier/+git/update-notifier/+merge/436035 |
|
2023-01-19 11:38:11 |
Renan Rodrigo |
description |
[ Impact ]
Currently, the Pro Client sets up ESM sources in the system's APT configuration to advertise ESM updates even when the service is disabled. This is undesired, as described in
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1990378
The next version of ubuntu-advantage-client will not bring this configuration anymore, and will remove it from systems where it exists.
Update Notifier relies on those unauthenticated ESM sources. It needs instead to rely on the Pro Client ESM apt cache to provide this information.
If this is not changes, users will not see any ESM update or advertisement if they don't have the services enabled.
The change in the reporting strategy will land in ubuntu-advantage-tools and will be SRUed back to Xenial, Bionic, Focal and Jammy.
[ Test Plan ]
In a Ubuntu LTS system (Xenial for esm-infra, bionic/focal for esm-apps):
- Verify that the ubuntu-advantage-tools version installed is greater than 27.12
- Verify that no ESM updates are reported when running /usr/lib/update-notifier/apt-check --human-readable
- Install a version of update-notifier with the change (from -proposed, or from the MR branch if not uploaded yet)
- Verify that ESM updates are when running /usr/lib/update-notifier/apt-check --human-readable
[ Where problems could occur ]
In the event of the change being implemented in a wrong/incomplete way, the side-effect is that users would not see the ESM updates, same as not implementing the change. However, it is simple enough to verify if this happens, and it is highly improbable that it does.
[ Other Info ]
Instead of reading the esm apt cache from the Pro Client, update-notifier could query the 'packages' API provided in the Client itself. However, for that to happen, it would make sense for the package to depend (or at least recommend) ubuntu-advantage-tools.
Even using the esm apt cache would be a fair reason for update-notifier to recommend ubuntu-advantage-tools - but it is the same kind of coupling (relying on implementation) as reading the "never" pin from esm repositories, so there is no hard requirement to add the soft dependency. |
[ Impact ]
Currently, the Pro Client sets up ESM sources in the system's APT configuration to advertise ESM updates even when the service is disabled. This is undesired, as described in
https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1990378
The next version of ubuntu-advantage-client will not bring this configuration anymore, and will remove it from systems where it exists.
Update Notifier relies on those unauthenticated ESM sources. It needs instead to rely on the Pro Client ESM apt cache to provide this information.
If this is not changes, users will not see any ESM update or advertisement if they don't have the services enabled.
The change in the reporting strategy will land in ubuntu-advantage-tools and will be SRUed back to Xenial, Bionic, Focal and Jammy.
[ Test Plan ]
In a Ubuntu LTS system (Xenial for esm-infra, bionic/focal for esm-apps):
- Verify that the ubuntu-advantage-tools version installed is greater than 27.12
- Verify that no ESM updates are reported when running /usr/lib/update-notifier/apt-check --human-readable
- Install a version of update-notifier with the change (from -proposed, or from the MR branch if not uploaded yet)
- Verify that ESM updates are when running /usr/lib/update-notifier/apt-check --human-readable
[ Where problems could occur ]
In the event of the change being implemented in a wrong/incomplete way, the side-effect is that users would not see the ESM updates, same as not implementing the change. However, it is simple enough to verify if this happens, and it is highly improbable that it does.
[ Other Info ]
Instead of reading the esm apt cache from the Pro Client, update-notifier could query the 'packages' API provided in the Client itself. However, for that to happen, it would make sense for the package to depend (or at least recommend) ubuntu-advantage-tools.
Even using the esm apt cache would be a fair reason for update-notifier to recommend ubuntu-advantage-tools - but it is the same kind of coupling (relying on implementation) as reading the "never" pin from esm repositories, so there is no hard requirement to add the soft dependency.
There is no upload to Kinetic because there are no ESM packages there. There is no report of ESM data today, and there will be no report even if this lands there.
For future changes, we want to redesign how this interaction between ubuntu-advantage-tools and update-notificer works, and then the definitive solution should land on all supported releases. |
|
2023-01-20 16:03:21 |
Launchpad Janitor |
update-notifier (Ubuntu Lunar): status |
New |
Fix Released |
|
2023-01-24 22:51:36 |
Andreas Hasenack |
update-notifier (Ubuntu Jammy): status |
New |
Fix Committed |
|
2023-01-24 22:51:39 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2023-01-24 22:51:41 |
Andreas Hasenack |
bug |
|
|
added subscriber SRU Verification |
2023-01-24 22:51:44 |
Andreas Hasenack |
tags |
|
verification-needed verification-needed-jammy |
|
2023-01-24 22:53:46 |
Andreas Hasenack |
update-notifier (Ubuntu Focal): status |
New |
Fix Committed |
|
2023-01-24 22:53:52 |
Andreas Hasenack |
tags |
verification-needed verification-needed-jammy |
verification-needed verification-needed-focal verification-needed-jammy |
|
2023-01-25 17:38:08 |
Andreas Hasenack |
update-notifier (Ubuntu Bionic): status |
New |
Fix Committed |
|
2023-01-25 17:38:15 |
Andreas Hasenack |
tags |
verification-needed verification-needed-focal verification-needed-jammy |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy |
|
2023-01-25 17:53:32 |
Andreas Hasenack |
update-notifier (Ubuntu Xenial): status |
New |
Fix Committed |
|
2023-01-25 17:53:38 |
Andreas Hasenack |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-xenial |
|
2023-01-26 19:39:47 |
Renan Rodrigo |
attachment added |
|
test-2002168-xenial https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2002168/+attachment/5643627/+files/test-2002168-xenial |
|
2023-01-26 19:40:02 |
Renan Rodrigo |
attachment added |
|
test-2002168-bionic https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2002168/+attachment/5643628/+files/test-2002168-bionic |
|
2023-01-26 19:40:22 |
Renan Rodrigo |
attachment added |
|
test-2002168-focal https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2002168/+attachment/5643629/+files/test-2002168-focal |
|
2023-01-26 19:40:36 |
Renan Rodrigo |
attachment added |
|
test-2002168-jammy https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/2002168/+attachment/5643630/+files/test-2002168-jammy |
|
2023-01-26 19:47:53 |
Renan Rodrigo |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-jammy verification-needed-xenial |
verification-done verification-done-bionic verification-done-focal verification-done-jammy verification-done-xenial |
|
2023-02-02 18:03:36 |
Launchpad Janitor |
update-notifier (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
2023-02-02 18:03:41 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
2023-02-02 18:04:00 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
2023-02-02 18:04:17 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
2023-02-02 18:04:38 |
Launchpad Janitor |
update-notifier (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|