| 2022-12-16 14:40:52 |
Andreas Hasenack |
bug |
|
|
added bug |
| 2022-12-16 14:41:07 |
Andreas Hasenack |
summary |
bionic branch fails to build: missing autoconf files |
bionic upstream branch fails to build: missing autoconf files |
|
| 2022-12-16 17:03:39 |
Andreas Hasenack |
description |
The bionic upstream branch of update-notifier[1] currently FTBFSs.
Compared to the source package in the ubuntu bionic archive, it's missing the generated autoconf files:
$ git diff pkg/ubuntu/bionic-devel..upstream/bionic|diffstat|grep -v /po
Makefile.in | 808 ---
aclocal.m4 | 2290 ----------
b/.gitignore | 31
b/debian/changelog | 10
b/debian/control | 2
compile | 347 -
configure | 9127 -------------------------------------------
data/Makefile.in | 649 ---
depcomp | 791 ---
install-sh | 508 --
missing | 215 -
pixmaps/16x16/Makefile.in | 494 --
pixmaps/22x22/Makefile.in | 494 --
pixmaps/24x24/Makefile.in | 494 --
pixmaps/48x48/Makefile.in | 494 --
pixmaps/Makefile.in | 617 --
pixmaps/scalable/Makefile.in | 494 --
po/Makefile.in.in | 221 -
src/Makefile.in | 715 ---
ui/Makefile.in | 494 --
153 files changed, 17378 insertions(+), 32241 deletions(-)
All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
$ git diff upstream/bionic..upstream/focal -- debian/rules
diff --git a/debian/rules b/debian/rules
index c67232ec..73fe23e5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
%:
- dh $@ --with python3
+ dh $@ --with python3 --with autoreconf
+
+override_dh_autoreconf:
+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
+
+override_dh_auto_configure:
+ dh_auto_configure -- --libdir=/usr/lib
override_dh_auto_test:
cd tests && python3 test_package-data-downloader.py
+ cd tests && python3 test_motd.py
+
We should either generate these files at build time, like the other upstream branches, or include them in the bionic repository, like the current package in the bionic ubuntu archive has it[1]
1. https://git.launchpad.net/ubuntu/+source/update-notifier/tree/?h=ubuntu/bionic-devel |
The bionic upstream branch of update-notifier[1] currently FTBFSs.
Compared to the source package in the ubuntu bionic archive (which builds just fine), it's missing the generated autoconf files:
$ git diff pkg/ubuntu/bionic-devel..upstream/bionic|diffstat|grep -v /po
Makefile.in | 808 ---
aclocal.m4 | 2290 ----------
b/.gitignore | 31
b/debian/changelog | 10
b/debian/control | 2
compile | 347 -
configure | 9127 -------------------------------------------
data/Makefile.in | 649 ---
depcomp | 791 ---
install-sh | 508 --
missing | 215 -
pixmaps/16x16/Makefile.in | 494 --
pixmaps/22x22/Makefile.in | 494 --
pixmaps/24x24/Makefile.in | 494 --
pixmaps/48x48/Makefile.in | 494 --
pixmaps/Makefile.in | 617 --
pixmaps/scalable/Makefile.in | 494 --
po/Makefile.in.in | 221 -
src/Makefile.in | 715 ---
ui/Makefile.in | 494 --
153 files changed, 17378 insertions(+), 32241 deletions(-)
All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
$ git diff upstream/bionic..upstream/focal -- debian/rules
diff --git a/debian/rules b/debian/rules
index c67232ec..73fe23e5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
%:
- dh $@ --with python3
+ dh $@ --with python3 --with autoreconf
+
+override_dh_autoreconf:
+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
+
+override_dh_auto_configure:
+ dh_auto_configure -- --libdir=/usr/lib
override_dh_auto_test:
cd tests && python3 test_package-data-downloader.py
+ cd tests && python3 test_motd.py
+
We should either generate these files at build time, like the other upstream branches, or include them in the bionic repository, like the current package in the bionic ubuntu archive has it[1]
1. https://git.launchpad.net/ubuntu/+source/update-notifier/tree/?h=ubuntu/bionic-devel |
|
| 2023-01-24 14:42:58 |
Andreas Hasenack |
nominated for series |
|
Ubuntu Bionic |
|
| 2023-01-24 14:42:58 |
Andreas Hasenack |
bug task added |
|
update-notifier (Ubuntu Bionic) |
|
| 2023-01-24 14:43:07 |
Andreas Hasenack |
update-notifier (Ubuntu): status |
New |
Invalid |
|
| 2023-01-25 17:37:57 |
Andreas Hasenack |
update-notifier (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2023-01-25 17:37:58 |
Andreas Hasenack |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-01-25 17:38:00 |
Andreas Hasenack |
bug |
|
|
added subscriber SRU Verification |
| 2023-01-25 17:38:03 |
Andreas Hasenack |
tags |
|
verification-needed verification-needed-bionic |
|
| 2023-01-25 17:48:35 |
Lucas Albuquerque Medeiros de Moura |
description |
The bionic upstream branch of update-notifier[1] currently FTBFSs.
Compared to the source package in the ubuntu bionic archive (which builds just fine), it's missing the generated autoconf files:
$ git diff pkg/ubuntu/bionic-devel..upstream/bionic|diffstat|grep -v /po
Makefile.in | 808 ---
aclocal.m4 | 2290 ----------
b/.gitignore | 31
b/debian/changelog | 10
b/debian/control | 2
compile | 347 -
configure | 9127 -------------------------------------------
data/Makefile.in | 649 ---
depcomp | 791 ---
install-sh | 508 --
missing | 215 -
pixmaps/16x16/Makefile.in | 494 --
pixmaps/22x22/Makefile.in | 494 --
pixmaps/24x24/Makefile.in | 494 --
pixmaps/48x48/Makefile.in | 494 --
pixmaps/Makefile.in | 617 --
pixmaps/scalable/Makefile.in | 494 --
po/Makefile.in.in | 221 -
src/Makefile.in | 715 ---
ui/Makefile.in | 494 --
153 files changed, 17378 insertions(+), 32241 deletions(-)
All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
$ git diff upstream/bionic..upstream/focal -- debian/rules
diff --git a/debian/rules b/debian/rules
index c67232ec..73fe23e5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
%:
- dh $@ --with python3
+ dh $@ --with python3 --with autoreconf
+
+override_dh_autoreconf:
+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
+
+override_dh_auto_configure:
+ dh_auto_configure -- --libdir=/usr/lib
override_dh_auto_test:
cd tests && python3 test_package-data-downloader.py
+ cd tests && python3 test_motd.py
+
We should either generate these files at build time, like the other upstream branches, or include them in the bionic repository, like the current package in the bionic ubuntu archive has it[1]
1. https://git.launchpad.net/ubuntu/+source/update-notifier/tree/?h=ubuntu/bionic-devel |
[Original Description]
The bionic upstream branch of update-notifier[1] currently FTBFSs.
Compared to the source package in the ubuntu bionic archive (which builds just fine), it's missing the generated autoconf files:
$ git diff pkg/ubuntu/bionic-devel..upstream/bionic|diffstat|grep -v /po
Makefile.in | 808 ---
aclocal.m4 | 2290 ----------
b/.gitignore | 31
b/debian/changelog | 10
b/debian/control | 2
compile | 347 -
configure | 9127 -------------------------------------------
data/Makefile.in | 649 ---
depcomp | 791 ---
install-sh | 508 --
missing | 215 -
pixmaps/16x16/Makefile.in | 494 --
pixmaps/22x22/Makefile.in | 494 --
pixmaps/24x24/Makefile.in | 494 --
pixmaps/48x48/Makefile.in | 494 --
pixmaps/Makefile.in | 617 --
pixmaps/scalable/Makefile.in | 494 --
po/Makefile.in.in | 221 -
src/Makefile.in | 715 ---
ui/Makefile.in | 494 --
153 files changed, 17378 insertions(+), 32241 deletions(-)
All other upstream branches in update-notifier have those files removed, but d/rules was adapted to generate them:
$ git diff upstream/bionic..upstream/focal -- debian/rules
diff --git a/debian/rules b/debian/rules
index c67232ec..73fe23e5 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,7 +3,15 @@ export CFLAGS += -Wall -g -O$(if $(findstring noopt,$(DEB_BUILD_OPTIONS)),0,2)
export LDFLAGS += -Wl,-z,defs -Wl,-O1 -Wl,--as-needed
%:
- dh $@ --with python3
+ dh $@ --with python3 --with autoreconf
+
+override_dh_autoreconf:
+ NOCONFIGURE=1 dh_autoreconf ./autogen.sh
+
+override_dh_auto_configure:
+ dh_auto_configure -- --libdir=/usr/lib
override_dh_auto_test:
cd tests && python3 test_package-data-downloader.py
+ cd tests && python3 test_motd.py
+
We should either generate these files at build time, like the other upstream branches, or include them in the bionic repository, like the current package in the bionic ubuntu archive has it[1]
1. https://git.launchpad.net/ubuntu/+source/update-notifier/tree/?h=ubuntu/bionic-devel
[Impact]
This will fix FTBFSs errors when building the package by bringing the autoconf file from the package in archive
[Test Case]
Check if the package can now build without FTBFSs errors
[Regression Potential]
We are just bringing autoconf files directly from the package in archive. Because of that, we believe regressions here are very unlikely. However,
if we have a problem, we believe this will affect the package build directly, which will prevent this SRU for taking place.
[Discussion]
In the previous SRU, those files were manually imported by the reviewer to make the build pass. Since we want to avoid this step in the future, we are bringing those files for this SRU now.
[Changelog]
* po/*.po: do no translate template variable needed for
package-data-downloader script (LP: #2003543)
* Bring generated autoconf files from the archive package (LP: #1999897) |
|
| 2023-02-01 14:19:24 |
Lucas Albuquerque Medeiros de Moura |
tags |
verification-needed verification-needed-bionic |
verification-done verification-done-bionic |
|
| 2023-02-02 18:04:17 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2023-02-02 18:04:23 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
