update-notifier should not alert users about esm-apps in a ESM machine

Bug #1926990 reported by Lucas Albuquerque Medeiros de Moura on 2021-05-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Undecided
Lucas Albuquerque Medeiros de Moura
Xenial
Undecided
Unassigned
Bionic
Undecided
Unassigned
Focal
Undecided
Unassigned

Bug Description

[Impact]
When users are running an ESM distro and looking at motd message they may be trigger by an alert generated by update-notifier that both esm-infra and esm-apps could be enable in the machine to receive future updates. However, esm-apps will not bring much to an ESM distro. This means that
users will be receiving alerts for esm-apps that are not necessary

[Test case]

To reproduce the issue, you can:

1. Launch a xenial container
2. create the file /etc/ubuntu-advantage/uaclient.conf with the following content:

# Ubuntu-Advantage client config file.
contract_url: 'https://contracts.canonical.com'
security_url: 'https://ubuntu.com/security'
data_dir: /var/lib/ubuntu-advantage
log_level: debug
log_file: /var/log/ubuntu-advantage.log
features:
  allow_beta: true

3. install ubuntu-advantage-client from this ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily

PS: Make sure to not allow the installation to override the config file you have just created.

4. Update the version of update-notifier to the one in proposed
5. Run `/usr/lib/update-notifier/apt-check --human-readable`
6. Verify that both esm-infra and esm-apps alerts appear in the end of the message

To verify that the error is fixed:

1. Run the past scenario until step 3
2. Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/
3. Run `/usr/lib/update-notifier/apt-check --human-readable`
4. Verify that only esm-infra is now showing an alert message at the end

[Where problems could occur]

We are only changing here the condition to output esm-apps alerts. If that condition is not right we may miss to display those messages to users that
need them.

[Discussion]
When running /usr/lib/update-notifier/apt-check on a ESM machine, we could alert the user about the existence of both esm-infra and esm-apps if the system has unauthenticated source file for both services. Therefore, we would display a message like that in the system:

--------------------------
Enable UA Apps: ESM to receive additional future security updates.
See https://ubuntu.com/security/esm or run: sudo ua status

Enable UA Infra: ESM to receive additional future security updates.
See https://ubuntu.com/security/esm or run: sudo ua status
----------------------------------

This is not ideal, since ESM machine will not gain much from esm-apps.
Also, this messaging may hide the importance of using esm-infra on ESM
machines, since the users will not know beforehand which service to
prioritize.

== Changelog ==

  * data/apt_check.py
    - do not show esm-apps alerts on esm distros

description: updated
summary: - update-notifier should not alert users about esm-infra in a ESM machine
+ update-notifier should not alert users about esm-apps in a ESM machine
Changed in update-notifier (Ubuntu):
assignee: nobody → Lucas Albuquerque Medeiros de Moura (lamoura)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers