| 2021-05-01 01:12:07 |
Aaron Thompson |
bug |
|
|
added bug |
| 2021-05-01 01:12:07 |
Aaron Thompson |
attachment added |
|
0001-apt_check.py-Fix-empty-output-in-the-no-ESM-up-to-da.patch https://bugs.launchpad.net/bugs/1926819/+attachment/5493997/+files/0001-apt_check.py-Fix-empty-output-in-the-no-ESM-up-to-da.patch |
|
| 2021-05-01 03:34:48 |
Aaron Thompson |
summary |
Empty MOTD on update-to-date focal systems (includes fix) |
Empty MOTD on up-to-date focal systems (includes fix) |
|
| 2021-05-01 03:35:22 |
Aaron Thompson |
summary |
Empty MOTD on up-to-date focal systems (includes fix) |
Empty MOTD on up-to-date systems (includes fix) |
|
| 2021-05-01 04:28:13 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2021-05-01 04:28:22 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2021-05-03 14:25:59 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
New |
Confirmed |
|
| 2021-05-05 09:34:20 |
Sebastien Bacher |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2021-05-05 09:47:20 |
Sebastien Bacher |
tags |
patch |
patch regression-update rls-ff-incoming |
|
| 2021-05-05 09:47:29 |
Sebastien Bacher |
bug |
|
|
added subscriber Lucas Albuquerque Medeiros de Moura |
| 2021-05-05 09:47:43 |
Sebastien Bacher |
bug |
|
|
added subscriber Bryce Harrington |
| 2021-05-05 09:50:52 |
Sebastien Bacher |
update-notifier (Ubuntu): importance |
Undecided |
High |
|
| 2021-05-05 13:06:22 |
Robie Basak |
bug |
|
|
added subscriber Robie Basak |
| 2021-05-06 08:50:20 |
Tony Vroon |
bug |
|
|
added subscriber Tony Vroon |
| 2021-05-07 19:44:18 |
Lucas Albuquerque Medeiros de Moura |
update-notifier (Ubuntu): status |
Confirmed |
In Progress |
|
| 2021-05-07 19:44:22 |
Lucas Albuquerque Medeiros de Moura |
update-notifier (Ubuntu): assignee |
|
Lucas Albuquerque Medeiros de Moura (lamoura) |
|
| 2021-05-11 19:12:29 |
Adolfo Jayme Barrientos |
update-notifier (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2021-05-19 19:38:30 |
Marc Marc |
bug |
|
|
added subscriber Marc Marc |
| 2021-05-19 19:38:33 |
Marc Marc |
removed subscriber Marc Marc |
|
|
|
| 2021-05-19 19:38:34 |
Marc Marc |
bug |
|
|
added subscriber Marc Marc |
| 2021-05-20 15:22:22 |
Matthieu Clemenceau |
tags |
patch regression-update rls-ff-incoming |
fr-1400 patch regression-update rls-ff-incoming |
|
| 2021-05-20 18:12:02 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2021-05-20 22:23:53 |
Brian Murray |
nominated for series |
|
Ubuntu Focal |
|
| 2021-05-20 22:23:53 |
Brian Murray |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
| 2021-05-20 22:24:19 |
Brian Murray |
update-notifier (Ubuntu Focal): importance |
Undecided |
High |
|
| 2021-05-31 17:10:05 |
Łukasz Zemczak |
description |
Starting with update-notifier-common 3.192.30.7 (focal), my up-to-date systems are showing this MOTD on login:
Welcome to Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-72-generic x86_64)
user@host:~$
I've attached a patch that fixes this issue and adds more test cases. |
[Impact]
On a system without updates to be installed, not showing any message in motd feels that something went wrong in the backend. Also, currently we are printing unwanted white spaces in that scenario, which is not a good user experience here.
[Test case]
To reproduce the issue, you can:
1. Launch a xenial container
2. Remove ubuntu-advantage-tools from the system
This package will make update-notifier show more messages which are not needed in that test
3. Run an apt update
4. Install update-notifier
5. Run apt upgrade
6. Run /usr/lib/update-notifier/apt_check.py --human-readable
7. Verify we deliver an empty message
To verify that the error is fixed:
1. Run the past scenario until step 4
2. Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa/
3. Run `/usr/lib/update-notifier/apt-check --human-readable`
4. Verify that the command print the following message:
0 updates can be applied immediately.
[Where problems could occur]
We are bringing back a behavior that was already present in the package, but removed in the last version of it. We will now be impacting users that may not be relying in that message anymore. But we believe this should not be a huge issue if that happens, since users were already relying on the old behavior.
[Discussion]
Currently, motd will not output a message if the system does not have any updates to apply. However, this is not ideal since this may cause the impression that there is something wrong with motd or the system. Also, the empty message we produce in that scenario is not completely empty, it does contain some white spaces on it, which is completely unnecessary.
Because of that, we are bringing back the behavior of printing the message:
0 updates can be applied immediately.
If no updates need to be applied in the system.
[Original description]
Starting with update-notifier-common 3.192.30.7 (focal), my up-to-date systems are showing this MOTD on login:
Welcome to Ubuntu 20.04.2 LTS (GNU/Linux 5.4.0-72-generic x86_64)
user@host:~$
I've attached a patch that fixes this issue and adds more test cases. |
|
| 2021-05-31 17:16:12 |
Łukasz Zemczak |
update-notifier (Ubuntu Hirsute): status |
New |
Fix Committed |
|
| 2021-05-31 17:16:15 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-05-31 17:16:17 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2021-05-31 17:16:20 |
Łukasz Zemczak |
tags |
fr-1400 patch regression-update rls-ff-incoming |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-hirsute |
|
| 2021-05-31 17:24:46 |
Łukasz Zemczak |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2021-05-31 17:25:28 |
Łukasz Zemczak |
update-notifier (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2021-05-31 17:25:37 |
Łukasz Zemczak |
tags |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-hirsute |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-focal verification-needed-hirsute |
|
| 2021-05-31 17:36:37 |
Łukasz Zemczak |
update-notifier (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2021-05-31 17:36:44 |
Łukasz Zemczak |
tags |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-focal verification-needed-hirsute |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
|
| 2021-05-31 17:38:36 |
Łukasz Zemczak |
update-notifier (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2021-05-31 17:38:43 |
Łukasz Zemczak |
tags |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-xenial |
|
| 2021-06-01 21:08:08 |
Lucas Albuquerque Medeiros de Moura |
tags |
fr-1400 patch regression-update rls-ff-incoming verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-xenial |
fr-1400 patch regression-update rls-ff-incoming verification-done verification-done-bionic verification-done-focal verification-done-hirsute verification-done-xenial |
|
| 2021-06-08 07:56:07 |
Launchpad Janitor |
update-notifier (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-06-08 07:56:19 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-06-08 07:58:20 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-06-08 07:59:00 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2021-06-08 17:19:37 |
Launchpad Janitor |
update-notifier (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2022-09-22 16:48:02 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430317 |
|
| 2022-09-22 16:48:57 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430318 |
|
