| 2021-04-26 20:34:17 |
Lucas Albuquerque Medeiros de Moura |
bug |
|
|
added bug |
| 2021-04-26 20:34:55 |
Lucas Albuquerque Medeiros de Moura |
description |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the following old version of a xenial container:
lxc launch ubuntu:f4c4c60a6b752a381288ae72a1689a9da00f8e03b732c8d1b8a8fcd1a8890800 dev-x
2. Run apt update and install the updated version of update-notifier-common
3. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
4. Install ubuntu-advantage-tools
5. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
6. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
7. Run apt update
8. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
9. Run /usr/lib/update-notifier/apt-check --human-readable
10. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 8
2 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
3. Run /usr/lib/update-notifier/apt-check --human-readable
4. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Run apt update and install the updated version of update-notifier-common
3. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
4. Install ubuntu-advantage-tools
5. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
6. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
7. Run apt update
8. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
9. Run /usr/lib/update-notifier/apt-check --human-readable
10. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 8
2 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
3. Run /usr/lib/update-notifier/apt-check --human-readable
4. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
|
| 2021-04-26 20:59:47 |
Lucas Albuquerque Medeiros de Moura |
description |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Run apt update and install the updated version of update-notifier-common
3. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
4. Install ubuntu-advantage-tools
5. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
6. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
7. Run apt update
8. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
9. Run /usr/lib/update-notifier/apt-check --human-readable
10. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 8
2 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
3. Run /usr/lib/update-notifier/apt-check --human-readable
4. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Run apt update and install the updated version of update-notifier-common
3. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
4. Install ubuntu-advantage-tools
5. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
6. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
7. Run apt update
8. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
9. Run /usr/lib/update-notifier/apt-check --human-readable
10. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 8
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
|
| 2021-04-26 21:12:23 |
Lucas Albuquerque Medeiros de Moura |
description |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Run apt update and install the updated version of update-notifier-common
3. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
4. Install ubuntu-advantage-tools
5. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
6. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
7. Run apt update
8. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
9. Run /usr/lib/update-notifier/apt-check --human-readable
10. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 8
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
3. Install ubuntu-advantage-tools
4. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
5. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
6. Run apt update
7. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
8. Run /usr/lib/update-notifier/apt-check --human-readable
9. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 7
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
|
| 2021-04-26 21:14:11 |
Lucas Albuquerque Medeiros de Moura |
description |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
3. Install ubuntu-advantage-tools
4. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/
5. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
6. Run apt update
7. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
8. Run /usr/lib/update-notifier/apt-check --human-readable
9. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 7
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
3. Install ubuntu-advantage-tools
4. Attach to ua subscription
5. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
6. Run apt update
7. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
8. Run /usr/lib/update-notifier/apt-check --human-readable
9. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enable4. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/d.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 7
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
|
| 2021-04-27 02:15:34 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401473 |
|
| 2021-04-27 02:15:41 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401653 |
|
| 2021-04-27 02:15:49 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401657 |
|
| 2021-04-27 02:15:56 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401662 |
|
| 2021-04-27 02:16:03 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401826 |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Groovy |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Groovy) |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Bionic |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Bionic) |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Xenial |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Xenial) |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Focal |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Impish |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Impish) |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
nominated for series |
|
Ubuntu Hirsute |
|
| 2021-04-27 02:17:16 |
Bryce Harrington |
bug task added |
|
update-notifier (Ubuntu Hirsute) |
|
| 2021-04-27 02:17:25 |
Bryce Harrington |
update-notifier (Ubuntu Xenial): status |
New |
In Progress |
|
| 2021-04-27 02:17:27 |
Bryce Harrington |
update-notifier (Ubuntu Bionic): status |
New |
In Progress |
|
| 2021-04-27 02:17:31 |
Bryce Harrington |
update-notifier (Ubuntu Focal): status |
New |
In Progress |
|
| 2021-04-27 02:17:33 |
Bryce Harrington |
update-notifier (Ubuntu Hirsute): status |
New |
In Progress |
|
| 2021-04-27 02:17:35 |
Bryce Harrington |
update-notifier (Ubuntu Impish): status |
New |
In Progress |
|
| 2021-04-27 02:17:37 |
Bryce Harrington |
update-notifier (Ubuntu Impish): importance |
Undecided |
High |
|
| 2021-04-27 02:17:39 |
Bryce Harrington |
update-notifier (Ubuntu Hirsute): importance |
Undecided |
High |
|
| 2021-04-27 02:17:41 |
Bryce Harrington |
update-notifier (Ubuntu Focal): importance |
Undecided |
High |
|
| 2021-04-27 02:17:43 |
Bryce Harrington |
update-notifier (Ubuntu Bionic): importance |
Undecided |
High |
|
| 2021-04-27 02:17:45 |
Bryce Harrington |
update-notifier (Ubuntu Xenial): importance |
Undecided |
High |
|
| 2021-04-27 02:17:57 |
Bryce Harrington |
update-notifier (Ubuntu Xenial): assignee |
|
Lucas Albuquerque Medeiros de Moura (lamoura) |
|
| 2021-04-27 02:18:06 |
Bryce Harrington |
update-notifier (Ubuntu Bionic): assignee |
|
Lucas Albuquerque Medeiros de Moura (lamoura) |
|
| 2021-04-27 02:18:14 |
Bryce Harrington |
update-notifier (Ubuntu Focal): assignee |
|
Lucas Albuquerque Medeiros de Moura (lamoura) |
|
| 2021-04-27 02:18:21 |
Bryce Harrington |
update-notifier (Ubuntu Hirsute): assignee |
|
Chad Smith (chad.smith) |
|
| 2021-04-27 02:18:29 |
Bryce Harrington |
update-notifier (Ubuntu Impish): assignee |
|
Chad Smith (chad.smith) |
|
| 2021-04-27 17:22:49 |
Brian Murray |
description |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
3. Install ubuntu-advantage-tools
4. Attach to ua subscription
5. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
6. Run apt update
7. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
8. Run /usr/lib/update-notifier/apt-check --human-readable
9. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enable4. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/d.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 7
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
[Impact]
When users are looking at MOTD messages, they might find the text confusing, since we don't explicitly say that the security updates count are taking into consideration both standard security pockets and ESM pockets.
[Test Case]
1. Launch the a xenial container
2. Add the ubuntu-advantage-tools ppa:
https://code.launchpad.net/~ua-client/+archive/ubuntu/daily
3. Install ubuntu-advantage-tools
4. Attach to ua subscription
5. Comment out all mentions of xenial-security/xenial-updates in /etc/apt/source.list
6. Run apt update
7. Install libkrad0:
apt install libkrad0=1.13.2+dfsg-5
8. Run /usr/lib/update-notifier/apt-check --human-readable
9. See a message like this:
UA Infra: Extended Security Maintenance (ESM) is not enabled. Install the latest version of uaclient from the stable ppa:
https://launchpad.net/~ua-client/+archive/ubuntu/stable/d.
UA Infra: Extended Security Maintenance (ESM) is enabled.
3 packages can be updated.
1 of these updates is fixed through UA Infra: ESM.
1 of these updates is a security update.
To see these additional updates run: apt list --upgradable
To verify that the error is fixed:
1.Perform all the stages above until step 7
2. Bring back xenial-security on source.list (we need because of the python3-distro-info dependency of update-notifier-common)
3 Install the new update-notifier from this ppa:
https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa
4. Remove xenial-security from source.list again
5. Run /usr/lib/update-notifier/apt-check --human-readable and see a message like this:
UA Infra: Extended Security Maintenance (ESM) is enabled.
4 updates can be installed immediately.
1 of these updates are UA Infra: ESM security updates.
To see these additional updates run: apt list --upgradable
That is now correct.
[Where problems could occur]
The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displaying incorrect standard security messages to the user.
[Discussion]
Currently, we treat the upgrades coming from standard security pocket and ESM service with the same packaging count. This could be confusing, since we don't point that out in the current message that we have:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
5 of these updates are security updates
We believe this will be better if the message stated:
5 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
And if we had a situation like that:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
8 of these updates are security updates
We would change it to:
10 updates can be installed immediately.
5 of these updates are provide through UA Infrastructure ESM
3 of these updates are standard security updates |
|
| 2021-04-27 17:36:59 |
Brian Murray |
update-notifier (Ubuntu Hirsute): status |
In Progress |
Fix Committed |
|
| 2021-04-27 17:37:01 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-04-27 17:37:03 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2021-04-27 17:37:06 |
Brian Murray |
tags |
|
verification-needed verification-needed-hirsute |
|
| 2021-04-27 17:41:03 |
Brian Murray |
update-notifier (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2021-04-27 17:41:10 |
Brian Murray |
tags |
verification-needed verification-needed-hirsute |
verification-needed verification-needed-focal verification-needed-hirsute |
|
| 2021-04-27 17:44:55 |
Brian Murray |
update-notifier (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2021-04-27 17:45:01 |
Brian Murray |
tags |
verification-needed verification-needed-focal verification-needed-hirsute |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
|
| 2021-04-27 17:51:41 |
Brian Murray |
update-notifier (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2021-04-27 17:51:49 |
Brian Murray |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-xenial |
|
| 2021-04-28 14:02:51 |
Lucas Albuquerque Medeiros de Moura |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-xenial |
verification-done verification-done-bionic verification-done-focal verification-done-hirsute verification-done-xenial |
|
| 2021-04-28 19:01:48 |
Launchpad Janitor |
update-notifier (Ubuntu Impish): status |
In Progress |
Fix Released |
|
| 2021-04-29 20:31:48 |
Launchpad Janitor |
update-notifier (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-04-29 20:32:02 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-04-29 20:33:16 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-04-29 20:33:48 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2021-04-29 20:33:58 |
Launchpad Janitor |
update-notifier (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2022-09-22 16:48:02 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430317 |
|
| 2022-09-22 16:48:57 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430318 |
|
