| 2020-12-01 17:52:21 |
Chad Smith |
bug |
|
|
added bug |
| 2020-12-02 00:23:05 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394164 |
|
| 2020-12-02 00:33:18 |
Chad Smith |
description |
Cherry-picking upstream changes for ESM Product renaming and messaging 1901627 triggered autopkgtest failures on Xenial and Bionic during SRU review. Also changes in the base cloud-images used for testing dropped pep8 package from the build environment and unittests rely on calling pep8 on Cenial and Bionic. minimally a build-depends on pep8 needs to be added and pep8 test failures addresssed.
This does not directly affect Focal or later because update-notifier moved to pycodestyle validation in tests instead of using pep8.
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. The backport of these commits introduced pep8 linter errors in unittests that broke autopkgtests for xenial version 3.168.11 and bionic version 3.192.1.8.
The failed autopkgtests pointed to a need for an explicit build-depends on pep8 package because cloud-images:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
In order to publish to xenial and bionic, introduce pep8 biuld-depends and fix pep8 lints
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
# sources:
# ua.proposed:
# source: deb http://ppa.launchpad.net/canonical-server/ua-client-daily/ubuntu \$RELEASE main
# keyid: 94E187AD53A59D1847E4880F8A295C4FB8B190B7
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in xenial bionic focal groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
echo "--- Install a downgraded hello package which ESM-focal delivers"
lxc exec ${vm} -- apt-get install hello=2.10-2ubuntu2
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes only here in data/apt_check.py, data/hooks.py and test_package-data-downloader.py. Only need to confirm that current apt-hook logic remains functional and that motd messaging is present without tracebacks using /usr/lib/update-notifier/apt-check --human-readable
[Other Info]
[Original Description]
Cherry-picking upstream changes for ESM Product renaming and messaging 1901627 triggered autopkgtest failures on Xenial and Bionic during SRU review. Also changes in the base cloud-images used for testing dropped pep8 package from the build environment and unittests rely on calling pep8 on Cenial and Bionic. minimally a build-depends on pep8 needs to be added and pep8 test failures addresssed.
This does not directly affect Focal or later because update-notifier moved to pycodestyle validation in tests instead of using pep8.
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
|
| 2020-12-02 04:36:26 |
Chad Smith |
summary |
Resolve autopkgtest failures Pep8 on Xenial and Bionic |
Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic |
|
| 2020-12-02 04:37:40 |
Chad Smith |
description |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. The backport of these commits introduced pep8 linter errors in unittests that broke autopkgtests for xenial version 3.168.11 and bionic version 3.192.1.8.
The failed autopkgtests pointed to a need for an explicit build-depends on pep8 package because cloud-images:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
In order to publish to xenial and bionic, introduce pep8 biuld-depends and fix pep8 lints
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
# sources:
# ua.proposed:
# source: deb http://ppa.launchpad.net/canonical-server/ua-client-daily/ubuntu \$RELEASE main
# keyid: 94E187AD53A59D1847E4880F8A295C4FB8B190B7
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in xenial bionic focal groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
echo "--- Install a downgraded hello package which ESM-focal delivers"
lxc exec ${vm} -- apt-get install hello=2.10-2ubuntu2
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes only here in data/apt_check.py, data/hooks.py and test_package-data-downloader.py. Only need to confirm that current apt-hook logic remains functional and that motd messaging is present without tracebacks using /usr/lib/update-notifier/apt-check --human-readable
[Other Info]
[Original Description]
Cherry-picking upstream changes for ESM Product renaming and messaging 1901627 triggered autopkgtest failures on Xenial and Bionic during SRU review. Also changes in the base cloud-images used for testing dropped pep8 package from the build environment and unittests rely on calling pep8 on Cenial and Bionic. minimally a build-depends on pep8 needs to be added and pep8 test failures addresssed.
This does not directly affect Focal or later because update-notifier moved to pycodestyle validation in tests instead of using pep8.
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
Cherry-picking upstream changes for ESM Product renaming and messaging 1901627 triggered autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes) during SRU review.
Also changes in the Xenial base cloud-images used for testing dropped pep8 package from the build environment and unittests rely on calling pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be added and pep8 test failures addresssed for Xenial. Bionic also needs minor pyflakes fixes from master.
This does not directly affect Focal or later because update-notifier moved to pycodestyle validation in tests instead of using pep8.
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
|
| 2020-12-02 04:42:19 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394161 |
|
| 2020-12-02 11:55:22 |
Christian Ehrhardt |
description |
Cherry-picking upstream changes for ESM Product renaming and messaging 1901627 triggered autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes) during SRU review.
Also changes in the Xenial base cloud-images used for testing dropped pep8 package from the build environment and unittests rely on calling pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be added and pep8 test failures addresssed for Xenial. Bionic also needs minor pyflakes fixes from master.
This does not directly affect Focal or later because update-notifier moved to pycodestyle validation in tests instead of using pep8.
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
[Impact]
- autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes)
- Cherry-picking upstream changes for ESM Product renaming and messaging
for bug 1901627 trigger these issues.
- Also changes in the Xenial base cloud-images used for testing dropped
pep8 package from the build environment and unittests rely on calling
pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be
added and pep8 test failures addresssed for Xenial. Bionic also needs
minor pyflakes fixes from master.
[Test Case]
* Testing is "implicit", build time and autopkgtest tests have to
succeed as we'd expect anyway.
[Where problems could occur]
* These are whitespace/indent/style changes that should (tm) be totally
without an effect other than for the code-checker. Never the less by
changing code always something could happen. In this case the changes
are local to apt_check, package-data-downloader, backend_helper and
hooks. So in these subfunctions of update-notifier issue would be
expected.
[Other Info]
* This does not directly affect Focal or later because update-notifier
moved to pycodestyle validation in tests instead of using pep8.
--- ---
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
|
| 2020-12-04 17:44:49 |
Timo Aaltonen |
update-notifier (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2020-12-04 17:44:51 |
Timo Aaltonen |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-12-04 17:44:53 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
| 2020-12-04 17:44:57 |
Timo Aaltonen |
tags |
regression-proposed |
regression-proposed verification-needed verification-needed-bionic |
|
| 2020-12-04 17:56:13 |
Timo Aaltonen |
update-notifier (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2020-12-04 17:56:17 |
Timo Aaltonen |
tags |
regression-proposed verification-needed verification-needed-bionic |
regression-proposed verification-needed verification-needed-bionic verification-needed-xenial |
|
| 2020-12-10 23:11:50 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/395179 |
|
| 2020-12-10 23:18:44 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/395181 |
|
| 2020-12-11 06:07:19 |
Mathew Hodson |
update-notifier (Ubuntu): status |
New |
Fix Released |
|
| 2020-12-14 11:12:20 |
Christian Ehrhardt |
description |
[Impact]
- autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes)
- Cherry-picking upstream changes for ESM Product renaming and messaging
for bug 1901627 trigger these issues.
- Also changes in the Xenial base cloud-images used for testing dropped
pep8 package from the build environment and unittests rely on calling
pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be
added and pep8 test failures addresssed for Xenial. Bionic also needs
minor pyflakes fixes from master.
[Test Case]
* Testing is "implicit", build time and autopkgtest tests have to
succeed as we'd expect anyway.
[Where problems could occur]
* These are whitespace/indent/style changes that should (tm) be totally
without an effect other than for the code-checker. Never the less by
changing code always something could happen. In this case the changes
are local to apt_check, package-data-downloader, backend_helper and
hooks. So in these subfunctions of update-notifier issue would be
expected.
[Other Info]
* This does not directly affect Focal or later because update-notifier
moved to pycodestyle validation in tests instead of using pep8.
--- ---
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
[Impact]
- autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes)
- Cherry-picking upstream changes for ESM Product renaming and messaging
for bug 1901627 trigger these issues.
- Also changes in the Xenial base cloud-images used for testing dropped
pep8 package from the build environment and unittests rely on calling
pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be
added and pep8 test failures addresssed for Xenial. Bionic also needs
minor pyflakes fixes from master.
[Test Case]
* Testing is "implicit", build time and autopkgtest tests have to
succeed as we'd expect anyway.
[Where problems could occur]
* These are whitespace/indent/style changes that should (tm) be totally
without an effect other than for the code-checker. Never the less by
changing code always something could happen. In this case the changes
are local to apt_check, package-data-downloader, backend_helper and
hooks. So in these subfunctions of update-notifier issue would be
expected.
[Other Info]
* This does not directly affect Focal or later because update-notifier
moved to pycodestyle validation in tests instead of using pep8.
* The Xenial upload will throw errors of some epxect-to-fail tests that
are misleading. We've spent too many iterations on looking at these so
they are silenced while fixing the test anyway.
--- ---
Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:
Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
File "/usr/lib/python3.5/subprocess.py", line 557, in call
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
restore_signals, start_new_session)
File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'
Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic
./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....
autopackage test failure logs showing missing pep8 dependency:
xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz
bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz
focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic. |
|
| 2021-01-04 15:57:32 |
Chad Smith |
tags |
regression-proposed verification-needed verification-needed-bionic verification-needed-xenial |
regression-proposed verification-done verification-done-bionic verification-done-xenial |
|
| 2021-01-04 17:12:48 |
Chad Smith |
tags |
regression-proposed verification-done verification-done-bionic verification-done-xenial |
verification-done verification-done-bionic verification-done-xenial |
|
| 2021-01-05 19:22:59 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-01-05 19:22:48 |
Launchpad Janitor |
update-notifier (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2021-01-05 19:25:17 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2022-09-22 16:48:02 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430317 |
|
| 2022-09-22 16:48:57 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430318 |
|
