apt-check updates package list even when calling in apt update hook

[Balint Reczey]

Running apt-get -q update right after creating a multipass VM may take quite long since apt-check updates package list again. It seems to be stuck in lock-wait, but I have to triage that fully.

Found the issue when using ubuntu bartender.

multipass@cunning-halibut-ubuntu-bartender:~$ top

top - 12:37:11 up 12 min, 1 user, load average: 2.21, 1.83, 1.08
Tasks: 112 total, 3 running, 109 sleeping, 0 stopped, 0 zombie
%Cpu(s): 35.6 us, 3.6 sy, 0.7 ni, 0.0 id, 0.0 wa, 0.0 hi, 59.8 si, 0.3 st
KiB Mem : 8175088 total, 7685532 free, 113940 used, 375616 buff/cache
KiB Swap: 0 total, 0 free, 0 used. 7801576 avail Mem

  PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND
 1757 multipa+ 20 0 92796 3952 2984 R 86.6 0.0 8:54.22 sshd
    3 root 20 0 0 0 0 S 10.5 0.0 0:58.22 ksoftirqd/0
 2145 root 39 19 114936 54396 11372 R 1.3 0.7 0:03.78 apt-check
 2355 multipa+ 20 0 40500 3588 3012 R 1.0 0.0 0:00.13 top
 1103 root 10 -10 5716 3508 2424 S 0.3 0.0 0:00.39 iscsid
 2126 root 20 0 0 0 0 S 0.3 0.0 0:00.38 kworker/u2:1
 2191 multipa+ 20 0 92796 3412 2484 S 0.3 0.0 0:00.33 sshd
 2302 root 20 0 0 0 0 S 0.3 0.0 0:00.27 kworker/0:2
    1 root 20 0 38064 5896 3888 S 0.0 0.1 0:04.10 systemd
    2 root 20 0 0 0 0 S 0.0 0.0 0:00.00 kthreadd
    4 root 20 0 0 0 0 S 0.0 0.0 0:00.45 kworker/0:0
    5 root 0 -20 0 0 0 S 0.0 0.0 0:00.00 kworker/0:0H
    7 root 20 0 0 0 0 S 0.0 0.0 0:00.21 rcu_sched
    8 root 20 0 0 0 0 S 0.0 0.0 0:00.00 rcu_bh
    9 root rt 0 0 0 0 S 0.0 0.0 0:00.00 migration/0
   10 root rt 0 0 0 0 S 0.0 0.0 0:00.00 watchdog/0
   11 root 20 0 0 0 0 S 0.0 0.0 0:00.00 kdevtmpfs
   12 root 0 -20 0 0 0 S 0.0 0.0 0:00.00 netns
   13 root 0 -20 0 0 0 S 0.0 0.0 0:00.00 perf
   14 root 20 0 0 0 0 S 0.0 0.0 0:00.00 khungtaskd
   15 root 0 -20 0 0 0 S 0.0 0.0 0:00.00 writeback
   16 root 25 5 0 0 0 S 0.0 0.0 0:00.00 ksmd
   17 root 39 19 0 0 0 S 0.0 0.0 0:00.00 khugepaged
multipass@cunning-halibut-ubuntu-bartender:~$ pstree
systemd─┬─accounts-daemon─┬─{gdbus}
        │ └─{gmain}
        ├─acpid
        ├─2*[agetty]
        ├─atd
        ├─cron
        ├─dbus-daemon
        ├─dhclient
        ├─2*[iscsid]
        ├─lvmetad
        ├─lxcfs───2*[{lxcfs}]
        ├─lxd───7*[{lxd}]
        ├─lxd-bridge-prox───2*[{lxd-bridge-prox}]
        ├─mdadm
        ├─polkitd─┬─{gdbus}
        │ └─{gmain}
        ├─rsyslogd─┬─{in:imklog}
        │ ├─{in:imuxsock}
        │ └─{rs:main Q:Reg}
        ├─sshd─┬─sshd───sshd───bash───sudo───apt-get───apt-get───sh───update-motd-upd───apt-check
        │ └─sshd───sshd───bash───pstree
        ├─systemd───(sd-pam)
        ├─systemd-journal
        ├─systemd-logind
        ├─systemd-timesyn───{sd-resolve}
        ├─systemd-udevd
        └─unattended-upgr───{gmain}
multipass@cunning-halibut-ubuntu-bartender:~$ ps -ef | grep apt
root 1895 1758 0 12:30 ? 00:00:00 sudo apt-get -q update
root 1896 1895 0 12:30 ? 00:00:00 apt-get -q update
root 2127 1896 0 12:32 ? 00:00:00 apt-get -q update
root 2145 2131 1 12:32 ? 00:00:04 /usr/bin/python3 /usr/lib/update-notifier/apt-check --human-readable
multipa+ 2359 2192 0 12:38 pts/0 00:00:00 grep --color=auto apt
multipass@cunning-halibut-ubuntu-bartender:~$ /usr/bin/python3 /usr/lib/update-notifier/apt-check --human-readable
^C^C^C^C^C^C^C^CError in function update
E: Unknown Error: '<class 'KeyboardInterrupt'>' ()^C^C^C^C
multipass@cunning-halibut-ubuntu-bartender:~$ ^C
multipass@cunning-halibut-ubuntu-bartender:~$ ^C
multipass@cunning-halibut-ubuntu-bartender:~$ ^C
multipass@cunning-halibut-ubuntu-bartender:~$ /usr/bin/python3 /usr/lib/update-notifier/apt-check --human-readable
^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^C^CError in function upda