Doesn't communicate about applied livepatch on start
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
update-notifier (Ubuntu) |
Fix Released
|
Medium
|
Andrea Azzarone | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
* Impact
The "livepatch updates have been applied" notifications might be missing if the event happened before the user logged in
* Test case
The real testcase is to make sure that a notification is displayed when a livepatch update is applied.
That can also be simulated by writting "applied 1" in /var/snap/
* Regression potential
The code change are in the livepatch notifications handling, just make sure those are displayed as expected
-------
The update-notifier livepatch code seems to only react to event, but since it's slow to start (it's in the graphical session and delayed by 60s) it's likely that livepatch refresh is done before update-notifier is ready and such the user feedback is never send.
We should probably change update-notifier to do send the notification on start if there is any applied change (it's going to nag at every login but that's somewhat a feature/better, since it reassure to the user that he has those fixes in place)
Wdyt?
Related branches
- Iain Lane: Approve
- Sebastien Bacher: Approve
-
Diff: 129 lines (+75/-13)3 files modifieddebian/changelog (+7/-0)
src/livepatch.c (+63/-13)
src/update-notifier.c (+5/-0)
Changed in update-notifier (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Andrea Azzarone (azzar1) |
importance: | Undecided → Medium |
description: | updated |
From the discussion on IRC, the status might be wrong after reboot since it's only updated when livepatch apply changes
Ideally
- livepatch should delete/update that file on refresh if the status is that there is update (to check if that's not the case today)
- if the state might be wrong after reboot/new kernel deb is applied, then maybe compare uptime to timestamp of the file
- the status should maybe be deleted on reboot since the status is resetted on reboot?
Some of those issues should probably be fix to the livepatch snap