Restart required dialogue issues

[Bruce Cowan]

Binary package hint: update-manager

The "Restart Required" dialogue has a few issues.

1. It isn't set as a primary window, which it should be thanks to it not being spawned by a primary window. This leads to it not being displayed in the window list.
2. 1 being the case, it should have a window title.
3. The icon in "Restart Now" is inappropriate (bug 391383).
4. The 2nd paragraph is a run on sentence. The comma between "applied" and "newly" ought to be a semicolon.

[Bruce Cowan (bruce89-deactivatedaccount)]

This is the dialogue in question.

[Mackenzie Morgan (maco.m)]

Confirming this usability bug. This is one of those windows that pops up and is easily lost behind other windows (especially when using focus-follows-mouse) with no easy way to find it again.

[Jean-Baptiste Lallement (jibel)]

Thanks for your report. This is still an issue in jaunty. affecting to update-notifier.

[Jean-Baptiste Lallement (jibel)]

don't hesitate to submit any new bug.

[Gabor Kelemen (kelemeng)]

1, The window now has title: http://bazaar.launchpad.net/~ubuntu-core-dev/update-notifier/ubuntu/revision/439
However, I feel it's now somewhat redundant, as the same words are on the title and the first line of the message. Perhaps the "In order to complete the update of your system it needs to be restarted." sentence should be the primary text?
2, <property name="type">GTK_WINDOW_TOPLEVEL</property> - this is what we have, I think this is correct, isn't?
3, I'm attaching a patch to change the icon.

[Gabor Kelemen (kelemeng)]

This patch replaces the title with the former first sentence, so redundancy is gone. Also the suggested semicolon is there, and I shortened the new primary text a bit. Any comments welcome.

[Gabor Kelemen (kelemeng)]

Also, there is bug #201865, which is almost identical to this, except that it says
3. "Restart required" seems a bit harsh, I'd suggest "Restart suggested".
Umm, I don't know if it's too harsh, or just enough, what does the maintainer think? :)

[Bruce Cowan (bruce89-deactivatedaccount)]

The GNOME HIG suggests that alert dialogues don't have titles. Also, they should have primary and secondary text.

See http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en

[Matthew Paul Thomas (mpt)]

The current alert is not perfect, but it fixes all the problems described in this bug report.