| 2018-02-05 19:38:13 |
Andreas Hasenack |
bug |
|
|
added bug |
| 2018-02-05 21:17:45 |
Steve Langasek |
bug |
|
|
added subscriber Tyler Hicks |
| 2018-02-06 16:27:07 |
David Britton |
bug |
|
|
added subscriber David Britton |
| 2020-05-15 01:56:02 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
New |
Confirmed |
|
| 2020-05-15 01:56:04 |
David Coronel |
bug |
|
|
added subscriber David Coronel |
| 2020-05-15 15:43:22 |
David Coronel |
cve linked |
|
2018-10323 |
|
| 2020-05-15 15:43:22 |
David Coronel |
cve linked |
|
2018-10840 |
|
| 2020-07-06 12:39:43 |
David Coronel |
attachment added |
|
Suggested flowchart of how the decision to reboot should be when using livepatch https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1747499/+attachment/5390197/+files/livepatch-flowchart-davecore-suggestion.png |
|
| 2020-11-19 18:59:11 |
Jordi Gimenez |
bug |
|
|
added subscriber Jordi Gimenez |
| 2022-01-14 06:53:58 |
Nikos Mavrogiannopoulos |
bug |
|
|
added subscriber Brian Murray |
| 2022-04-25 13:34:34 |
Olivier Gayot |
bug task added |
|
unattended-upgrades (Ubuntu) |
|
| 2022-04-26 15:51:24 |
Olivier Gayot |
bug |
|
|
added subscriber Olivier Gayot |
| 2022-04-26 16:00:15 |
Olivier Gayot |
attachment added |
|
debdiff for unattended-upgrades (focal) https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1747499/+attachment/5583991/+files/1-unattended-upgrades-2.3ubuntu0.1-2.3ubuntu1.debdiff |
|
| 2022-04-26 16:00:45 |
Olivier Gayot |
attachment added |
|
debdiff for update-notifier (focal) https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1747499/+attachment/5583992/+files/1-update-notifier-3.192.30.10.3.192.30.11.debdiff |
|
| 2022-04-26 16:01:06 |
Olivier Gayot |
unattended-upgrades (Ubuntu): status |
New |
Confirmed |
|
| 2022-04-26 16:22:20 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2022-04-26 16:22:26 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2022-04-26 16:49:03 |
Olivier Gayot |
description |
If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in.
That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel.
There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot-required.pkgs
Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update.
For (a), one can use the command "ubuntu-advantage is-livepatch-enabled" and check $?. That is in the ubuntu-advantage-tools package. |
[Impact]
* If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in.
* Livepatch is available on LTS releases. Thus, the users can be confused following a kernel update on 20.04.
* The upload prevents update-notifier and unattended-ugprades hooks from adding "system restart"-related messages to motd when Livepatch is enabled.
Livepatch, when enabled, already contributes to the motd message so there is no need to have duplicate (and sometimes contradictory) information.
[Test Plan]
* how to reproduce the bug:
1. Install and boot a 20.04 server VM
2. Make sure it runs a generic kernel (or another flavour that supports Livepatch)
3. Enable Livepatch using the following command:
$ ua attach <token> # replace <token> by an actual contract token
4. Upgrade the kernel (if you are already running the latest available kernel update, you can install a different flavour)
5. Upon logging in again, the motd will show ***System restart required***.
* other testing appropriate to perform before landing this update:
* Making sure that the patch has no impact when livepatch is not enabled.
* The motd should show ***System restart required*** after upgrading the kernel if livepatch is not enabled.
[Where problems could occur]
* The change updates a hook script in /etc/kernel/postinst.d/. Scripts in this directory are executing when upgrading / installing a kernel. If somehow the script is broken, it can prevent dpkg for succeeding when upgrading / installing the kernel.
* If the implementation is wrong, we might end up "losing" the ***System restart required*** message when livepatch is disabled
[Original bug description]
If a system is using canonical livepatch, has it enabled, and patches are applied, it could be confusing for a user to receive a "system restart required" messages in the MOTD when logging in.
That message, when present, is printed by 98-reboot-required which essentially just cats /var/run/reboot-required to stdout. That file is placed by packages that require a reboot so that they are properly used in their updated versions. Examples that come to mind are libc and the kernel.
There is a secondary file that can be created which says which packages requested the reboot. That would be /var/run/reboot-required.pkgs
Ideally that script should not print out the reboot required message if a) livepatch is installed and enabled; b) the only trigger for the reboot is a kernel update.
For (a), one can use the command "ubuntu-advantage is-livepatch-enabled" and check $?. That is in the ubuntu-advantage-tools package. |
|
| 2022-04-27 09:43:08 |
Łukasz Zemczak |
nominated for series |
|
Ubuntu Focal |
|
| 2022-04-27 09:43:08 |
Łukasz Zemczak |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
| 2022-04-27 09:43:08 |
Łukasz Zemczak |
bug task added |
|
unattended-upgrades (Ubuntu Focal) |
|
| 2022-04-29 10:08:32 |
Olivier Gayot |
tags |
patch |
fr-1788 patch |
|
| 2022-04-29 10:40:21 |
Lukas Märdian |
removed subscriber Ubuntu Sponsors Team |
|
|
|
| 2022-04-29 10:40:29 |
Lukas Märdian |
update-notifier (Ubuntu Focal): status |
New |
In Progress |
|
| 2022-04-29 10:40:32 |
Lukas Märdian |
unattended-upgrades (Ubuntu Focal): status |
New |
In Progress |
|
| 2022-04-29 15:55:34 |
Olivier Gayot |
unattended-upgrades (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2022-04-29 15:55:37 |
Olivier Gayot |
update-notifier (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2022-05-10 20:52:35 |
Brian Murray |
update-notifier (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2022-05-10 20:52:37 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2022-05-10 20:52:39 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2022-05-10 20:52:44 |
Brian Murray |
tags |
fr-1788 patch |
fr-1788 patch verification-needed verification-needed-focal |
|
| 2022-05-10 20:55:10 |
Brian Murray |
unattended-upgrades (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2022-06-28 09:15:14 |
Olivier Gayot |
tags |
fr-1788 patch verification-needed verification-needed-focal |
fr-1788 patch verification-done-focal verification-needed |
|
| 2022-07-04 09:41:20 |
Launchpad Janitor |
unattended-upgrades (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-07-04 09:41:25 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2022-07-04 09:41:28 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2024-04-16 14:26:52 |
Robie Basak |
tags |
fr-1788 patch verification-done-focal verification-needed |
fr-1788 patch reboot-required verification-done-focal verification-needed |
|
