update-motd-fsck-at-reboot claims that partitions will be checked even if check is disabled in fstab

Bug #1282760 reported by Nils Kassube on 2014-02-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Medium
Brian Murray

Bug Description

When I login remotely I get a message that a partition will be checked at next reboot. This message will appear even after the next reboot because in my /etc/fstab that partition is marked as not to check (last field = 0). Either that message should not appear or it should be different to indicate that the partition will not be checked automatically but should be checked.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: update-notifier-common 0.152
ProcVersionSignature: Ubuntu 3.13.0-11.31-generic 3.13.3
Uname: Linux 3.13.0-11-generic x86_64
ApportVersion: 2.13.2-0ubuntu5
Architecture: amd64
Date: Thu Feb 20 21:17:12 2014
PackageArchitecture: all
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: update-notifier
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Nils Kassube (kassube) wrote :
Nils Kassube (kassube) wrote :

And here is an alternative patch

The attachment "This patch disables the faulty message" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Changed in update-notifier (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Brian Murray (brian-murray) wrote :

Thanks for you work on this patch but, I think the cut command is incorrect "cut -s -f 2,6", I believe you want "cut -s -f 1,6". I say this as ext_partitions is the following on my system:

 $ mount | awk '$5 ~ /^ext(2|3|4)$/ { print $1 }'
/dev/mapper/ubuntu--vg-root
/dev/mapper/virtual--vg-sec--machine
/dev/sda1

and

 $ grep -v '^#' /etc/fstab | tr -s ' ' '\t' | cut -s -f 2,6
/ 1
/boot 2
none 0
none 0
/mnt/sec-machines 1

while:

 $ grep -v '^#' /etc/fstab | tr -s ' ' '\t' | cut -s -f 1,6
/dev/mapper/ubuntu--vg-root 1
UUID=1422b209-8540-4bf6-9852-bb5a1181ce54 2
/dev/mapper/ubuntu--vg-swap_1 0
/dev/mapper/cryptswap1 0
/dev/mapper/virtual--vg-sec--machine 1

Does that make sense to you?

Changed in update-notifier (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
status: Triaged → Incomplete
Nils Kassube (kassube) wrote :

Thanks for the review. With the cut command I want to select the mount point and not the device. The device is known inside the loop from "$part" but there are several ways to name the device in /etc/fstab (device, UUID, label). It is unknown which version is used for the partition in question. On your last output you can see the problem with several device names and one UUID. Therefore it is easier to determine the fstab line using the mount point, and that is at field 2. So the output of

grep -v '^#' /etc/fstab | tr -s ' ' '\t' | cut -s -f 2,6

should be the mount points and the pass numbers.

Brian Murray (brian-murray) wrote :

Ah, I see what I missed now. Thanks for the clarification, I'll get your change added shortly.

Changed in update-notifier (Ubuntu):
status: Incomplete → In Progress
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-notifier - 0.154

---------------
update-notifier (0.154) trusty; urgency=medium

  * Do not say that a partition will be checked when the check is disabled in
    fstab. Thanks to Nils Kassube for the patch. (LP: #1282760)
  * Use print function instead of statement (LP: #1256759)
  * Increase the poll interval from 5 seconds to 180 (LP: #1227000)
 -- Brian Murray <email address hidden> Fri, 14 Mar 2014 15:14:23 -0700

Changed in update-notifier (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers