| 2008-08-22 16:34:29 |
Dustin Kirkland |
bug |
|
|
added bug |
| 2008-08-23 07:30:42 |
Greg A |
None: bugtargetdisplayname |
Ubuntu |
update-motd (Ubuntu) |
|
| 2008-08-23 07:30:42 |
Greg A |
None: bugtargetname |
ubuntu |
update-motd (Ubuntu) |
|
| 2008-08-23 07:30:42 |
Greg A |
None: statusexplanation |
|
|
|
| 2008-08-23 07:30:42 |
Greg A |
None: title |
Bug #260443 in Ubuntu: "main inclusion request: update-motd" |
Bug #260443 in update-motd (Ubuntu): "main inclusion request: update-motd" |
|
| 2008-09-09 18:27:02 |
Mathias Gug |
bug |
|
|
added subscriber MIR approval team |
| 2008-09-11 19:22:40 |
Dustin Kirkland |
update-motd: status |
New |
Confirmed |
|
| 2008-09-11 19:22:40 |
Dustin Kirkland |
update-motd: importance |
Undecided |
Medium |
|
| 2008-09-11 19:22:40 |
Dustin Kirkland |
update-motd: milestone |
|
intrepid-alpha-6 |
|
| 2008-09-12 16:19:57 |
Martin Pitt |
update-motd: status |
Confirmed |
Incomplete |
|
| 2008-09-12 16:19:57 |
Martin Pitt |
update-motd: statusexplanation |
|
The configuration file handling in here needs to be fixed. At the moment, the init script does
sed "s/FREQ_IN_MIN/$FREQ_IN_MIN/" "/usr/share/update-motd/update-motd.cron" > /etc/cron.d/update-motd
unconditionally. This overwrites the admin's changes without checking or confirmation.
If you ask me, I would ship /etc/cron.d/update-motd as a conffile, so that the admin can change it directly, without any dynamic magic. If you don't want to do that for some reason, you should do an ucf-like approach, create the config file in the postinst if it doesn't exist yet, or use ucf to manage it on package install/upgrades if it exists and was modified. I don't really see the need to do it in the init script. No other package does it that way, and it is higly unusal and also pretty brittle. |
|
| 2008-09-13 14:51:21 |
Dustin Kirkland |
bug |
|
|
added subscriber Rick Clark |
| 2008-09-16 18:53:09 |
Dustin Kirkland |
update-motd: status |
Incomplete |
In Progress |
|
| 2008-09-16 18:53:09 |
Dustin Kirkland |
update-motd: statusexplanation |
The configuration file handling in here needs to be fixed. At the moment, the init script does
sed "s/FREQ_IN_MIN/$FREQ_IN_MIN/" "/usr/share/update-motd/update-motd.cron" > /etc/cron.d/update-motd
unconditionally. This overwrites the admin's changes without checking or confirmation.
If you ask me, I would ship /etc/cron.d/update-motd as a conffile, so that the admin can change it directly, without any dynamic magic. If you don't want to do that for some reason, you should do an ucf-like approach, create the config file in the postinst if it doesn't exist yet, or use ucf to manage it on package install/upgrades if it exists and was modified. I don't really see the need to do it in the init script. No other package does it that way, and it is higly unusal and also pretty brittle. |
|
|
| 2008-09-18 16:37:39 |
Martin Pitt |
update-motd: status |
In Progress |
Fix Released |
|
| 2008-09-18 16:37:39 |
Martin Pitt |
update-motd: statusexplanation |
|
Some review comments:
- postinst: use lt-nl instead of lt for --compare-versions
- prerm: You should be able to drop this entirely; conffiles are automatically removed on purge
- there should be a preinst which makes sure you don't get a dpkg conffile conflict question on intra-intrepid upgrades, but don't worry too much about it; developers should be able to figure that out.
- any reason why you use both dh_install and "install" in debian/rules to install files? ideally they would all use dh_install
Promoted to main. |
|
