Disable 'Check' action when there is no network

[Jean-Baptiste Lallement]

When there is no network (no interface set or network is disabled), the action 'Check' is still enabled. When the user clicks on it, it fails of course.

---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: update-manager 1:0.151.6
ProcVersionSignature: Ubuntu 3.0-1.2-generic 3.0.0-rc3
Uname: Linux 3.0-1-generic i686
Architecture: i386
Date: Mon Jun 27 11:23:39 2011
EcryptfsInUse: Yes
GConfNonDefault:
 /apps/update-manager/check_new_release_ignore=
 /apps/update-manager/first_run=false
 /apps/update-manager/show_details=true
 /apps/update-manager/window_size=(622,690)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, user)
 LANG=en_US.utf8
 LC_MESSAGES=en_US.utf8
 SHELL=/bin/bash
SourcePackage: update-manager
UpgradeStatus: Upgraded to oneiric on 2011-06-26 (0 days ago)

[Brendan Donegan (brendan-donegan)]

This isn't really Oneiric specific, it's always been the case that Check is enabled even if you don't have a connection. The warning message 'You may not be able to check for updates or download new updates' still appears. This is because updates can be available locally (for example in a CD). I won't say the bug is Invalid yet, but I think just disabling the Check button if no connection is available would break the scenario where packages are available offline.

[Jean-Baptiste Lallement (jibel)]

There is no warning message displayed.
Then if there is no network available, 'Check' should try refresh the package list from the network and end with an 'Failed to download repository information' error dialog

[Brendan Donegan (brendan-donegan)]

There is a warning message displayed just above the Check button in update-manager version 0.151.6, are you using the same version? This would be a bug if there is some circumstance in which it isn't. That is assuming the network is not available (shown as disconnected in NM)

I agree there should be some kind of failure message rather than it just failing 'silently' though.

[RedSingularity (redsingularity)]

Confirmed this occurrence many times on my machines.
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

[Robert Roth (evfool)]

Based on the discussion from the comments and the title, I can't decide which one is right: the title says that the Check action should be disabled when there's no network, but based on the comments, it seems that it has to be kept as enabled to use it for updating from offline sources. If the latter is the real problem, the title and description should be updated to show that the real problem is that the "you might not be able to check for updates" warning is not displayed.
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad