Clicking "Check" fails with error: self.emit("action-done", action) TypeError: 2 parameters needed for signal action-done; 1 given

[Jean-Baptiste Lallement]

Binary package hint: update-manager

Discovered during a mago run.

In Natty, fully updated:
1. Launch update-manager
2. Click on 'Check'

Result:
- u-m does the check
- after the check the popup disappears and the main UI is not reenabled.
The following error is displayed on the console:
$ update-manager
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/UpdateManager/backend/InstallBackendSynaptic.py", line 37, in _on_synaptic_exit
    self.emit("action-done", action)
TypeError: 2 parameters needed for signal action-done; 1 given

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: update-manager 1:0.145.1
ProcVersionSignature: Ubuntu 2.6.37-2.10-generic 2.6.37-rc1
Uname: Linux 2.6.37-2-generic i686
Architecture: i386
Date: Thu Nov 11 15:29:18 2010
EcryptfsInUse: Yes
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: update-manager

[Barry Warsaw (barry)]

Well, the googles are so unhelpful for finding out exactly what details are expected for the action-done signal. Or maybe my google-fu sucks.

[Barry Warsaw (barry)]

The duck hunt continues.

[Jean-Baptiste Lallement (jibel)]

Barry, the second argument is a boolean indicating is the action was successful or not. For the aptdaemon backend its set to false if the use is not authorized to do the check. I dont know if we can get this information for the synaptic backend. We can assume that its always true for synaptic since it can only run as root. A possible patch would be:

--- /usr/lib/python2.7/dist-packages/UpdateManager/backend/InstallBackendSynaptic.py 2010-09-07 17:30:58.000000000 +0200
+++ UpdateManager/backend/InstallBackendSynaptic.py 2010-11-11 19:24:34.000000000 +0100
@@ -34,7 +34,7 @@
         action, tempf = data
         if tempf:
             tempf.close()
- self.emit("action-done", action)
+ self.emit("action-done", action,True)

     def update(self):
         opt = ["--update-at-startup"]

[Jean-Baptiste Lallement (jibel)]

Barry,

The weird thing in this bug is why update-manager uses the synaptic backend while it should use the aptdaemon.
I've removed the try...catch from UpdateManager/backend/__init__.py and the problem is with python-vte and get this error:

Traceback (most recent call last):
  File "/usr/bin/update-manager", line 104, in <module>
    app = UpdateManager(data_dir, options)
  File "/usr/lib/python2.7/dist-packages/UpdateManager/UpdateManager.py", line 230, in __init__
    self.install_backend = backend.get_backend(self.window_main)
  File "/usr/lib/python2.7/dist-packages/UpdateManager/backend/__init__.py", line 43, in get_backend
    from InstallBackendAptdaemon import InstallBackendAptdaemon
  File "/usr/lib/python2.7/dist-packages/UpdateManager/backend/InstallBackendAptdaemon.py", line 7, in <module>
    from aptdaemon.gtkwidgets import AptProgressDialog
  File "/usr/lib/python2.7/dist-packages/aptdaemon/gtkwidgets.py", line 45, in <module>
    import vte
ImportError: No module named vte

So, it looks like we need to rebuild python-vte for python2.7

I'll file a new report to track this issue.