"Install" button sometimes doesn't do anything

[Chris Coulson]

Binary package hint: update-manager

TEST CASE:
- the bug itself is difficult to trigger, its a race
- a regression test is sufficient, if u-m can still install after clicking on the install button

I've noticed a few times on my Lucid machine that pressing the "Install" button in update-manager doesn't seem to do anything. This happened to me again today in KVM, and I was able to get this traceback:

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/UpdateManager/UpdateManager.py", line 586, in on_button_install_clicked
    self.cache.checkFreeSpace()
  File "/usr/lib/python2.6/dist-packages/DistUpgrade/DistUpgradeCache.py", line 1104, in checkFreeSpace
    for (dir, size) in [(archivedir, self.requiredDownload),
  File "/usr/lib/python2.6/dist-packages/UpdateManager/Core/MyCache.py", line 88, in requiredDownload
    pm.GetArchives(fetcher, self._list, self._records)
SystemError: E:I wasn't able to locate file for the gzip package. This might mean you need to manually fix this package.
This commit fixes this: http://bazaar.launchpad.net/~ubuntu-core-dev/update-manager/main/revision/1931

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:0.142.20

---------------
update-manager (1:0.142.20) maverick-proposed; urgency=low

  [ Michael Vogt ]
  * UpdateManager/UpdateManager.py:
    - do not crash if the free space check fails (LP: #656881)
  * DistUpgrade/DistUpgrade.cfg:
    - add blcr-dkms to the "BadVersions" variable. The current blcr-dkms
      source will not build with 2.6.35. Adding it here will cause the
      upgrade to abort with a message if it is installed.
      It also means that if support for 2.6.35 is added to blcr-dkms via
      a SRU that will automatically unblock the upgrade (LP: #555729)
  * DistUpgrade/DistUpgradeViewGtk.py,
    DistUpgrade/DistUpgradeViewKDE.py,:
    - workaround dpkg not sending the correct filename on conffile
      prompts over the status-fd (LP: #656912)

  [ Jonathan Riddell ]
  * DistUpgrade/DistUpgradeViewKDE.py:
    - disable confDialogue.show_difference_button, workaround for
      "distupgrade crashed during conf file change review" (LP: #656876)
      requires release note that user needs to view changes manually on command line
 -- Jonathan Riddell <email address hidden> Sat, 09 Oct 2010 19:08:23 +0100

[Martin Pitt (pitti)]

Accepted update-manager into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Jean-Baptiste Lallement (jibel)]

SRU verification for Lucid:
I have not been able to reproduced the problem with update-manager 1:0.134.10 in lucid-updates and but I have verified that I could update many packages without problem with the version of update-manager 1:0.134.11 in -proposed.

Marking as verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:0.134.11

---------------
update-manager (1:0.134.11) lucid-proposed; urgency=low

  * UpdateManager/UpdateManager.py:
    - do not crash if the free space check fails (LP: #656881)
 -- Michael Vogt <email address hidden> Wed, 13 Oct 2010 09:18:02 +0200