changelog uri has epoch stripped for launchpad.net

Bug #270527 reported by XXXXXXX
0
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Low
Michael Vogt

Bug Description

Binary package hint: update-manager

Update manager always strips the epoch off the srcver for use in the uri of the changelogs at changelogs.ubuntu.com, but if it is unable to get the changelog, it'll provide a link to it on launchpad. The problem is the launchpad uri's do not have the epoch stripped, resulting in the uri being incorrect for some packages.

Example for update-manger package.

Changelog uri provided: https://launchpad.net/ubuntu/+source/update-manager/0.93.14/+changelog

Correct changelog uri: https://launchpad.net/ubuntu/+source/update-manager/1:0.93.14/+changelog

Tags: bitesize
XXXXXXX (yddraiggoch)
description: updated
Changed in update-manager:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Brian Murray (brian-murray) wrote :

I'm having trouble with my bzr branch of update-manager so here is a patch.

Revision history for this message
XXXXXXX (yddraiggoch) wrote :

After applying the patch i get the following Traceback:

Unhandled exception in thread started by <bound method MyCache.get_changelog of <UpdateManager.UpdateManager.MyCache object at 0x923994c>>
Traceback (most recent call last):
  File "/home/richie/apt-sources/update-manager/update-manager-0.93.15/UpdateManager/UpdateManager.py", line 256, in get_changelog
    if srcver_epoch:
UnboundLocalError: local variable 'srcver_epoch' referenced before assignment

Not all packages need the epoch stripping, which meant the srcver_epoch variable wasn't always getting set. Moving 'srcver_epoch = srcver' before the if statement worked fine for me.

Changed in update-manager:
assignee: nobody → mvo
status: Triaged → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the bugreport and the fix! I commited it to my bzr tree and it will be part of the next upload.

Changed in update-manager:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:0.93.16

---------------
update-manager (1:0.93.16) intrepid; urgency=low

  [ Michael Vogt ]
  * DistUpgrade/DistUpgradeController.py:
    - automatically add "relatime" to the mount options
      of ext2/ext3
  * UpdateManager/Core/MetaRelease.py:
    - fix typo (thanks to Daniel Garcia)
  * DistUpgrade/DistUpgradeCache.py:
    - fix the removal of obsolete kernel packages when the
      old kernel abi package gets removed from -update and/or
      -security
  * UpdateManager/UpdateManager.py:
    - be more robust against server errors when fetching the
      changelogs (LP: #262982)
  * debian/control:
    - update the version dependency for python-apt, we need
      stuff from 0.7.5 (LP: #257781)
  * DistUpgrade/DistUpgradeView.py:#
    - make FuzzyTimeToStr() properly deal with plural forms
      (LP: #267234)

  [ Brian Murray ]
  * UpdateManager/UpdateManager.py:
    - preserve epoch in package version for changelogs at
      launchpad.net (LP: #270527)

 -- Michael Vogt <email address hidden> Tue, 16 Sep 2008 14:15:18 +0200

Changed in update-manager:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers