[SRU] Fix crash caused by updating update-manager from inside itself
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
update-manager (Ubuntu) |
Fix Released
|
High
|
Nathan Teodosio | ||
Xenial |
Fix Released
|
High
|
Nathan Teodosio | ||
Bionic |
Fix Released
|
High
|
Nathan Teodosio | ||
Focal |
Fix Released
|
High
|
Nathan Teodosio | ||
Jammy |
Fix Released
|
High
|
Nathan Teodosio | ||
Mantic |
Won't Fix
|
High
|
Unassigned |
Bug Description
Impact
------
LP:1990450 introduced Ubuntu Pro updates and news to update-manager, but also a bug whereby updating update-manager itself while update-manager is running replaces its UI files with a version incompatible with the already running handle of update-manager, subsequently causing a crash when the latter references an widget existing only in the old UI file.
In other words, update-manager crashes if the user tries installing the new update-manager release from inside itself.
Even though updates would have been installed successfully at that point and subsequent runs of update-manager would not crash, the user is none the wiser and is most likely left worried about his resulting system state.
Test case
---------
1. Have the old version of Update Manager installed and the proposed version available in the Apt database, such that, in Jammy for example, 'apt install --dry-run --verbose-versions' would report
update-manager (1:22.04.9 => 1:22.04.19)
2. Start update-manager from a terminal.
3. Make sure 'Software Updater' is selected in the list. We don't care about any other package for this test.
4. Click 'Install now'.
The installation must complete successfully and the view must be automatically recalculated. Verify that the application didn't crash (no tracebacks in the terminal window) and confirm with 'apt policy update-manager' that the new version was indeed installed.
To note
-------
The recalculated view will not include references to Ubuntu Pro (neither news pane nor Ubuntu Pro updates section), as it is still the old version of the program that is running.
Regression potential
-------
GTK is very finicky about its *.ui files; We must look out for other widgets failing to map or being relocated.
Original report
---------------
The Ubuntu Error Tracker has been receiving reports about a problem regarding update-manager. This problem was most recently seen with package version 1:22.04.17, the problem page at https:/
If you do not have access to the Ubuntu Error Tracker and are a software developer, you can request it at http://
Related branches
- Sebastien Bacher: Approve
-
Diff: 50 lines (+31/-0)2 files modifieddata/gtkbuilder/UpdateManager.ui (+24/-0)
debian/changelog (+7/-0)
- Sebastien Bacher: Approve
-
Diff: 50 lines (+31/-0)2 files modifieddata/gtkbuilder/UpdateManager.ui (+24/-0)
debian/changelog (+7/-0)
- Sebastien Bacher: Approve
-
Diff: 50 lines (+31/-0)2 files modifieddata/gtkbuilder/UpdateManager.ui (+24/-0)
debian/changelog (+7/-0)
- Sebastien Bacher: Approve
-
Diff: 50 lines (+31/-0)2 files modifieddata/gtkbuilder/UpdateManager.ui (+24/-0)
debian/changelog (+7/-0)
- Sebastien Bacher: Approve
-
Diff: 50 lines (+31/-0)2 files modifieddata/gtkbuilder/UpdateManager.ui (+24/-0)
debian/changelog (+7/-0)
Changed in update-manager (Ubuntu): | |
status: | New → Triaged |
description: | updated |
summary: |
- /usr/bin/update- - manager:AttributeError:start_available:_make_available_pane:__init__ + [SRU] Fix crash caused by updating update-manager from inside itself |
Changed in update-manager (Ubuntu Xenial): | |
importance: | Undecided → High |
assignee: | nobody → Nathan Teodosio (nteodosio) |
Changed in update-manager (Ubuntu Bionic): | |
assignee: | nobody → Nathan Teodosio (nteodosio) |
Changed in update-manager (Ubuntu Focal): | |
assignee: | nobody → Nathan Teodosio (nteodosio) |
description: | updated |
Those reports got flagged by the SRU phasing as regression, they seem to represent the same issue and started with the refactoring done to add the news section it seems
https:/ /errors. ubuntu. com/problem/ 7b4facc926a743e 632733dcc290e7c d5623b6eb0 /errors. ubuntu. com/problem/ d7e8e1fa6036362 8b200378f5ca6fd 60ca72d7c7 /errors. ubuntu. com/problem/ de4a79fb91be2d2 39109f623b6eb7c 99ddde6eb9
https:/
https:/