distribution upgrade tool reports "kb/s" but is measuring "kB/s"

[Martin Pool]

http://ubuntuforums.org/showthread.php?p=3512942

Upgrading from Gutsy to Hardy, the distribution upgrade tool reports that it's doing about 2000kb/s, but measurement using iftop, and my expected transfer speed to the nearby mirror it's using for the upgrade tells me it's actually 2000 kB/s (kilobytes rather than kilobits.)

I suspect the string is just wrong, but since it's off by 8 you might want to fix it.

[Olly Betts (ojwb)]

Just to add a confirmation, I just noticed this on a gutsy -> hardy beta upgrade.

[Michael Vogt (mvo)]

The diff is trivial, however we are in the interface freeze so I'm hesitant to change it now:

=== modified file 'DistUpgrade/DistUpgradeViewGtk.py'
--- DistUpgrade/DistUpgradeViewGtk.py 2008-03-31 16:10:31 +0000
+++ DistUpgrade/DistUpgradeViewGtk.py 2008-04-01 12:45:04 +0000
@@ -136,7 +136,7 @@
             currentItem = self.totalItems

         if self.currentCPS > 0:
- self.status.set_text(_("Fetching file %li of %li at %sb/s") % (currentItem, self.totalItems, apt_pkg.SizeToStr(self.currentCPS)))
+ self.status.set_text(_("Fetching file %li of %li at %sB/s") % (currentItem, self.totalItems, apt_pkg.SizeToStr(self.currentCPS)))
             self.progress.set_text(_("About %s remaining") % FuzzyTimeToStr(self.eta))
         else:
             self.status.set_text(_("Fetching file %li of %li") % (currentItem, self.totalItems))

[Olly Betts (ojwb)]

It would be good to get this trivial fix into intrepid though...

[Martin Pool (mbp)]

This does seem to commonly cause confusion and it is a tiny patch so it would be really nice for Intrepid...

[Pablo Castellano (pablocastellano)]

This bug was fixed in the package update-manager - 1:0.93.5

---------------
update-manager (1:0.93.5) intrepid; urgency=low

  [ Michael Vogt ]
  * DistUpgrade/DistUpgradeCache.py:
    - install new recommends on the hardy->intrepid upgrade
      (unless overwriten with the RELEASE_UPGRADE_NO_RECOMMENDS
       environment)
  * AutoUpgradeTester/UpgradeTestBackendQemu.py:
    - run ssh in the auto tester with "-t"
  * UpdateManager/UpdateManager.py:
    - fix plural forms (thanks to Bruce Cowan, LP: #189921)
  * DistUpgrade/DistUpgradeViewGtk.py:
    - show kB/sec (LP: #257778)

  [ Jonathan Riddell ]
  * Add KDE upgrade checking tools for use by Adept

 -- Jonathan Riddell <email address hidden> Wed, 27 Aug 2008 15:19:01 +0100