| 2024-02-01 15:45:49 |
Marc Deslauriers |
bug |
|
|
added bug |
| 2024-02-01 15:45:59 |
Marc Deslauriers |
nominated for series |
|
Ubuntu Focal |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
bug task added |
|
unzip (Ubuntu Focal) |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
nominated for series |
|
Ubuntu Jammy |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
bug task added |
|
unzip (Ubuntu Jammy) |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
nominated for series |
|
Ubuntu Noble |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
bug task added |
|
unzip (Ubuntu Noble) |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
nominated for series |
|
Ubuntu Mantic |
|
| 2024-02-01 15:45:59 |
Marc Deslauriers |
bug task added |
|
unzip (Ubuntu Mantic) |
|
| 2024-02-01 15:46:06 |
Marc Deslauriers |
unzip (Ubuntu Focal): assignee |
|
Marc Deslauriers (mdeslaur) |
|
| 2024-02-01 15:46:07 |
Marc Deslauriers |
unzip (Ubuntu Jammy): assignee |
|
Marc Deslauriers (mdeslaur) |
|
| 2024-02-01 15:46:09 |
Marc Deslauriers |
unzip (Ubuntu Mantic): assignee |
|
Marc Deslauriers (mdeslaur) |
|
| 2024-02-01 15:46:11 |
Marc Deslauriers |
unzip (Ubuntu Noble): assignee |
|
Marc Deslauriers (mdeslaur) |
|
| 2024-02-06 13:23:37 |
Marc Deslauriers |
attachment added |
|
test.zip https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+attachment/5744858/+files/test.zip |
|
| 2024-02-06 13:25:06 |
Marc Deslauriers |
unzip (Ubuntu Noble): status |
New |
Fix Committed |
|
| 2024-02-06 13:28:20 |
Marc Deslauriers |
description |
See the detailed explanation here:
https://www.bitsgalore.org/2020/03/11/does-microsoft-onedrive-export-large-ZIP-files-that-are-corrupt
tl;dr;
Microsoft mishandles the "Total number of disks" field when using the ZIP64 extension. It should start at 1, they use 0, which isn't a valid value. Unzip doesn't properly handle the invalid value. |
[Impact]
unzip rejects Microsoft OneDrive zip files. See the detailed explanation here:
https://www.bitsgalore.org/2020/03/11/does-microsoft-onedrive-export-large-ZIP-files-that-are-corrupt
tl;dr;
Microsoft mishandles the "Total number of disks" field when using the ZIP64 extension. It should start at 1, they use 0, which isn't a valid value. Unzip doesn't properly handle the invalid value.
[Test Plan]
- Download the test zip file from comment #1.
- unzip should extract it without issue (it contains a test.txt text file)
- if unzip fails, it will spew out a weird error message like the following:
$ unzip test.zip
Archive: test.zip
error [test.zip]: missing 4294967098 bytes in zipfile
(attempting to process anyway)
error [test.zip]: start of central directory not found;
zipfile corrupt.
(please check that you have transferred or created the zipfile in the
appropriate BINARY mode and that you have compiled UnZip properly)
[Where problems could occur]
This simple patch just accepts 0 as a valid total number of disks. I suppose if it was wrong it would mishandle multi-disk archives, though multi-disk archives should have a good value in that field. |
|
| 2024-02-06 13:28:45 |
Marc Deslauriers |
attachment added |
|
fix for focal https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+attachment/5744859/+files/unzip_6.0-25ubuntu1.2.debdiff |
|
| 2024-02-06 13:29:15 |
Marc Deslauriers |
attachment added |
|
fix for jammy https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+attachment/5744860/+files/unzip_6.0-26ubuntu3.2.debdiff |
|
| 2024-02-06 13:29:36 |
Marc Deslauriers |
attachment added |
|
fix for mantic https://bugs.launchpad.net/ubuntu/+source/unzip/+bug/2051952/+attachment/5744861/+files/unzip_6.0-28ubuntu1.1.debdiff |
|
| 2024-02-06 13:30:29 |
Marc Deslauriers |
bug |
|
|
added subscriber Ubuntu Sponsors |
| 2024-02-06 13:30:44 |
Marc Deslauriers |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2024-02-06 13:31:48 |
Marc Deslauriers |
unzip (Ubuntu Focal): status |
New |
In Progress |
|
| 2024-02-06 13:31:50 |
Marc Deslauriers |
unzip (Ubuntu Jammy): status |
New |
In Progress |
|
| 2024-02-06 13:31:53 |
Marc Deslauriers |
unzip (Ubuntu Mantic): status |
New |
In Progress |
|
| 2024-02-07 10:01:29 |
Launchpad Janitor |
unzip (Ubuntu Noble): status |
Fix Committed |
Fix Released |
|
| 2024-02-07 14:06:11 |
Graham Inggs |
removed subscriber Ubuntu Sponsors |
|
|
|
| 2024-02-07 17:32:50 |
Robie Basak |
unzip (Ubuntu Mantic): status |
In Progress |
Fix Committed |
|
| 2024-02-07 17:32:52 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2024-02-07 17:32:54 |
Robie Basak |
tags |
|
verification-needed verification-needed-mantic |
|
| 2024-02-07 17:33:04 |
Robie Basak |
unzip (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2024-02-07 17:33:06 |
Robie Basak |
tags |
verification-needed verification-needed-mantic |
verification-needed verification-needed-jammy verification-needed-mantic |
|
| 2024-02-07 17:33:16 |
Robie Basak |
unzip (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2024-02-07 17:33:18 |
Robie Basak |
tags |
verification-needed verification-needed-jammy verification-needed-mantic |
verification-needed verification-needed-focal verification-needed-jammy verification-needed-mantic |
|
| 2024-02-09 18:02:46 |
Marc Deslauriers |
tags |
verification-needed verification-needed-focal verification-needed-jammy verification-needed-mantic |
verification-done verification-done-focal verification-done-jammy verification-done-mantic |
|
| 2024-02-15 13:13:58 |
Launchpad Janitor |
unzip (Ubuntu Mantic): status |
Fix Committed |
Fix Released |
|
| 2024-02-15 13:14:00 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2024-02-15 13:14:21 |
Launchpad Janitor |
unzip (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2024-02-15 13:14:33 |
Launchpad Janitor |
unzip (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
