Wizard can potentially wait forever on a buggy page
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | unity8 (Ubuntu) |
High
|
Michael Terry | ||
Bug Description
If a wizard page never reports that it's ready to answer the question "should I skip this page?", the wizard will wait forever until it gets the answer. Meanwhile, the user is presented with an empty page.
We experienced this in vivid with ofono bug 1419675. libqofono wouldn't report that SIM2 was done initializing. So we'd just keep waiting.
To reduce the severity of future similar bugs, the wizard should have a sensible timeout. So at least the user can continue.
== Original bug ==
After selecting a language, sometimes I'm left with a blank page. I never see the next screen, which lets me pick my password.
When this happened, I was running krillin, on vivid image 122. I had a SIM in slot 2, but none in slot 1. I've NOT been able to reproduce with a SIM in slot 1 instead of slot 2, which seems relevant.
After reproducing many times, it will sometimes stop happening. But after an image flash, it is rather reliable for a while.
I've looked into this a bit on the wizard side. It turns out that libqofono is never replying that the second SIM slot is "ready" which means it has finished initializing it.
Now, the wizard probably should timeout waiting for that to be true. But libqofono should also provide that info.
current build number: 122
device name: krillin
channel: ubuntu-
alias: ubuntu-
last update: 2015-02-25 21:42:40
version version: 122
version ubuntu: 20150225
version device: 20150210-95b6a9f
version custom: 20150225
Related branches
- Daniel d'Andrada (community): Approve on 2015-03-03
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-03-03
-
Diff: 76 lines (+32/-2)2 files modifiedqml/Wizard/Pages.qml (+14/-1)
tests/qmltests/Wizard/tst_Wizard.qml (+18/-1)
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Michael Terry (mterry) |
| Michael Terry (mterry) wrote : | #1 |
| tags: | added: vivid |
| tags: | added: vivid-stab-candidate |
| tags: | added: lt-blocker lt-category-vidible |
| Michael Terry (mterry) wrote : | #2 |
OK, so all the ofono parts of this issue are resolved in bug 1419675. The fix for that bug has landed in vivid, and I can't reproduce this one anymore.
Unity8 should still time out if a wizard page is taking too long, and I'll remake this bug to be about that issue. But there's no longer a user-visible flaw associated with this issue right now in vivid. So I'll also take off the tags marking this bug as a critical issue.
| no longer affects: | libqofono (Ubuntu) |
| no longer affects: | ofono (Ubuntu) |
| summary: |
- Wizard freezes on blank screen after language + Wizard can potentially freeze forever on a buggy page |
| summary: |
- Wizard can potentially freeze forever on a buggy page + Wizard can potentially wait forever on a buggy page |
| Changed in unity8 (Ubuntu): | |
| status: | New → In Progress |
| description: | updated |
| tags: | removed: lt-blocker lt-category-vidible vivid vivid-stab-candidate |
| tags: | added: vivid |
| Changed in unity8 (Ubuntu): | |
| importance: | Undecided → High |
| Launchpad Janitor (janitor) wrote : | #3 |
This bug was fixed in the package unity8 - 8.02+15.
---------------
unity8 (8.02+15.
[ Albert Astals Cid ]
* Add some context to tr calls (LP: #1431497)
* Require binaries and .pc files we call from code
* Test: More stubborn flick to the end
[ Andrea Cimitan ]
* Refactor PreviewOverlay to fix weird zoom out/in animations when
previewing images from the Previews
[ CI Train Bot ]
* Resync trunk.
[ Charles Kerr ]
* Re-enable a rotation lock test now that the bug that broke that test
has been fixed. (LP: #1410915)
[ Daniel d'Andrada ]
* Darkened area behind indicators menu should eat input until it fully
disappears (LP: #1417967)
* DesktopStage - fix focus switch when user taps on window (LP:
#1431325)
* Fix warnings when launching tutorial
* Make MouseTouchAdaptor controllable from within QML
* Make tst_Shell absorb tst_TabletShell
[ Leo Arias ]
* Changed the autopilot dependencies so they do not require qt4. (LP:
#1429158)
* Drop the support for python2 in autopilot tests. (LP: #1429163)
* Stop using the deprecated toolkit emulators namespace in autopilot
tests. (LP: #1341681)
[ Michael Terry ]
* Don't close wizard & edge tutorial when the unity8-dash closes (LP:
#1425484)
* Don't let the wizard sit indefinitely, waiting for a wizard page to
finish preparing itself. (LP: #1425737)
* Fix two broken qmluitest files by waiting for everything to settle
before starting the tests.
* Only call unlockAllModems once the wizard is done. (LP: #1425161)
(LP: #1425161)
* When we are locking the user out from too many login failures,
notice when time passes even if the device is suspended. (LP:
#1396817) (LP: #1396817)
[ Michael Zanetti ]
* Add a mouse area to the indicators panel so we can open them by
clicking. (LP: #1417650)
* fix launcher not reacting to first click when revealed by mouse
hover, add tests
* performance improvements (LP: #1430233, #1425087)
[ Michał Sawicz ]
* Remove the activity indicator from tests
* Use targets instead of custom ld arguments for linking
[ Mirco Müller ]
* Updated the visuals of the SwipeToAct-widget for incoming-call snap-
decision notifications according to new design-spec.
* Updated the visuals of the SwipeToAct-widget for incoming-call snap-
decision notifications according to new design-spec.
-- CI Train Bot <email address hidden> Wed, 18 Mar 2015 10:19:06 +0000
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |


So, I've prepared a branch for unity8 which times out if ofono takes too long to finish initializing. But I still think there's a bug in ofono/libqofono here that's causing a problem.