Cannot drag up/down launcher if right-edge DDA area covers the whole panel
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | unity8 (Ubuntu) |
Undecided
|
Daniel d'Andrada | ||
| | Vivid |
Undecided
|
Unassigned | ||
Bug Description
One way to easily reproduce this is to change the Launcher's DDA to be as wide as the Launcher itself. Then reveal the Launcher and try to drag it up/down. Instead of moving up/down it will hide again.
Related branches
- Michael Zanetti (community): Approve on 2015-04-24
- Albert Astals Cid (community): Approve on 2015-04-17
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2015-04-16
- Michał Sawicz: Pending requested 2015-04-10
-
Diff: 5591 lines (+1769/-1521)49 files modifiedlibs/UbuntuGestures/CMakeLists.txt (+1/-0)
libs/UbuntuGestures/CandidateInactivityTimer.h (+1/-1)
libs/UbuntuGestures/TimeSource.h (+14/-4)
libs/UbuntuGestures/Timer.cpp (+67/-14)
libs/UbuntuGestures/Timer.h (+15/-3)
libs/UbuntuGestures/TouchRegistry.cpp (+12/-14)
libs/UbuntuGestures/TouchRegistry.h (+18/-4)
plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-1)
plugins/Ubuntu/Gestures/Damper.cpp (+24/-0)
plugins/Ubuntu/Gestures/Damper.h (+2/-0)
plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+362/-363)
plugins/Ubuntu/Gestures/DirectionalDragArea.h (+34/-207)
plugins/Ubuntu/Gestures/DirectionalDragArea_p.h (+167/-0)
plugins/Ubuntu/Gestures/TouchDispatcher.cpp (+88/-53)
plugins/Ubuntu/Gestures/TouchDispatcher.h (+16/-9)
plugins/Ubuntu/Gestures/TouchGate.cpp (+87/-63)
plugins/Ubuntu/Gestures/TouchGate.h (+18/-5)
qml/Components/DragHandle.qml (+20/-35)
qml/Components/EdgeDragArea.qml (+0/-46)
qml/Dash/Dash.qml (+5/-12)
qml/Greeter/CoverPage.qml (+3/-2)
qml/Launcher/Launcher.qml (+7/-15)
qml/Panel/IndicatorsMenu.qml (+12/-2)
qml/Stages/PhoneStage.qml (+33/-43)
qml/Stages/TabletStage.qml (+19/-21)
qml/Tutorial/TutorialBottom.qml (+1/-1)
tests/libs/UbuntuGestures/tst_TouchRegistry.cpp (+68/-2)
tests/plugins/Ubuntu/Gestures/CMakeLists.txt (+3/-1)
tests/plugins/Ubuntu/Gestures/DownwardsLauncher.qml (+5/-19)
tests/plugins/Ubuntu/Gestures/GestureTest.cpp (+13/-3)
tests/plugins/Ubuntu/Gestures/GestureTest.h (+4/-0)
tests/plugins/Ubuntu/Gestures/LeftwardsLauncher.qml (+6/-19)
tests/plugins/Ubuntu/Gestures/RightwardsLauncher.qml (+5/-19)
tests/plugins/Ubuntu/Gestures/UpwardsLauncher.qml (+6/-19)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.cpp (+496/-461)
tests/plugins/Ubuntu/Gestures/tst_DirectionalDragArea.qml (+8/-1)
tests/plugins/Ubuntu/Gestures/tst_TouchDispatcher.cpp (+5/-6)
tests/plugins/Ubuntu/Gestures/tst_TouchGate.cpp (+56/-1)
tests/qmltests/Components/CMakeLists.txt (+3/-1)
tests/qmltests/Components/tst_DragHandle.cpp (+15/-13)
tests/qmltests/Components/tst_DragHandle.qml (+7/-0)
tests/qmltests/Components/tst_DragHandle/BidirectionalShowable.qml (+2/-2)
tests/qmltests/Components/tst_DragHandle/HorizontalShowable.qml (+4/-4)
tests/qmltests/Components/tst_DragHandle/VerticalShowable.qml (+4/-4)
tests/qmltests/Stages/tst_PhoneStage.qml (+8/-8)
tests/qmltests/Tutorial/tst_Tutorial.qml (+5/-1)
tests/qmltests/tst_Shell.qml (+14/-10)
tests/qmltests/tst_ShellWithPin.qml (+2/-2)
tests/utils/modules/Unity/Test/UnityTestCase.qml (+3/-7)
| Changed in unity8 (Ubuntu): | |
| status: | New → In Progress |
| summary: |
- A DirectionalDragArea on top of a Flickable breaks the Flickable + Launcher DirectionalDragArea recognizes a vertical drag |
| summary: |
- Launcher DirectionalDragArea recognizes a vertical drag + A rightwards EdgeDragArea recognizes a vertical drag |
| Daniel d'Andrada (dandrader) wrote : | #1 |
| summary: |
- A rightwards EdgeDragArea recognizes a vertical drag + Cannot drag up/down launcher is right-edge DDA area covers the whole + panel |
| summary: |
- Cannot drag up/down launcher is right-edge DDA area covers the whole + Cannot drag up/down launcher if right-edge DDA area covers the whole panel |
| Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package unity8 - 8.02+15.
---------------
unity8 (8.02+15.
[ Albert Astals Cid ]
* Workarounds for concierge mode.
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
unity8 (8.02+15.
[ Albert Astals Cid ]
* Make runtests fake a test error if make fails
* Make the test more stable
* Use dbus-test-runner instead of dbus-launch
[ Daniel d'Andrada ]
* DirectionalDrag
* Fix EdgeDragEvaluator when a drag can happen both ways
(Direction.
[ Josh Arenson ]
* Remove panelHeight property as it is unused.
[ Leo Arias ]
* Initial clean up of the autopilot tests set up. Removed the touch
device from the test case. Moved the restart of unity to a fixture.
Removed the unused DragMixin. Updated the setUpClass to use
process_
fixed. Use the toolkit helper to set the testability environment
variable. Fixed the indicators base class that was restarting unity
twice. (LP: #1238417, #1447206)
* Use the base class from the toolkit in autopilot tests.
[ Michael Zanetti ]
* emit application-stop when we're going down (LP: #1326513)
[ Michał Sawicz ]
* UNITY_SCOPES_LIST is no more
[ handsome_feng<email address hidden> ]
* When click the favorite scope in Dash Manager , it just return to
the corresponding scope page. (LP: #1447056)
unity8 (8.02+15.
[ Albert Astals Cid ]
* Compile with Qt 5.5 (LP: #1437238)
* Different way of top aligning labels when the other one in the row
is multiline (LP: #1442085)
* make pot_file
[ Andrea Cimitan ]
* Set sourceSize for DashBackground.qml Image
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk. added: po/sk.po
[ Daniel d'Andrada ]
* Move handling of command line options to a separate class
* Refactor tst_PhysicalKey
[ Leo Arias ]
* For autopilot tests, use the device simulation scenarios from the
toolkit.
[ Leonardo Arias Fonseca ]
* For autopilot tests, use the device simulation scenarios from the
toolkit.
[ Michael Zanetti ]
* Make sure dnd mode is ended properly when drag gesture is cancelled
(LP: #1444949)
[ Michał Sawicz ]
* Fix flake8 warnings (LP: #1444170)
* Move mock indicator service to unity8-fake-env, as it's a binary-
dependent package.
[ Nick Dedekind ]
* Use asynchronous dbus requests for property updates. (LP: #1436982)
-- CI Train Bot <email address hidden> Mon, 11 May 2015 08:29:58 +0000
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |


This actually has multiple causes:
1 - EdgeDragArea has very lax rules, so a rightwards DDA would recognize even a vertical drag if it's long enough (both in terms of time and of distance)
2 - If the EdgeDragArea inside the Launcher rejects a gesture it will cause Launcher to retract. Ie, bad logic in Launcher.qml