Notification LED stays on when no messages in notification center
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Canonical System Image |
High
|
Thomas Strehl | ||
| | indicator-messages (Ubuntu) |
High
|
Ted Gould | ||
| | qmenumodel (Ubuntu) |
High
|
Nick Dedekind | ||
| | qmenumodel (Ubuntu RTM) |
Undecided
|
Michał Sawicz | ||
| | unity8 (Ubuntu) |
High
|
Nick Dedekind | ||
| | unity8 (Ubuntu RTM) |
High
|
Nick Dedekind | ||
Bug Description
Observed the notification LED staying on even though there were no notifications in the indicators and the notification icon was greyed out.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration) on 2014-12-17
- Albert Astals Cid (community): Approve on 2014-12-17
-
Diff: 2016 lines (+1124/-312)35 files modifieddebian/control (+3/-3)
plugins/Lights/Lights.cpp (+9/-24)
plugins/Unity/Indicators/CMakeLists.txt (+3/-1)
plugins/Unity/Indicators/Indicators.qmltypes (+18/-7)
plugins/Unity/Indicators/actionrootstate.cpp (+97/-0)
plugins/Unity/Indicators/actionrootstate.h (+55/-0)
plugins/Unity/Indicators/modelactionrootstate.cpp (+127/-0)
plugins/Unity/Indicators/modelactionrootstate.h (+61/-0)
plugins/Unity/Indicators/plugin.cpp (+4/-2)
plugins/Unity/Indicators/rootstateparser.cpp (+75/-142)
plugins/Unity/Indicators/rootstateparser.h (+20/-36)
qml/Greeter/Clock.qml (+1/-1)
qml/Panel/IndicatorItem.qml (+0/-8)
qml/Panel/Indicators/IndicatorBase.qml (+1/-1)
qml/Panel/Indicators/IndicatorsLight.qml (+19/-1)
qml/Panel/IndicatorsMenu.qml (+5/-0)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/Lights/CMakeLists.txt (+8/-0)
tests/mocks/Lights/Lights.cpp (+84/-0)
tests/mocks/Lights/Lights.h (+66/-0)
tests/mocks/Lights/Lights.qmltypes (+45/-0)
tests/mocks/Lights/plugin.cpp (+33/-0)
tests/mocks/Lights/plugin.h (+32/-0)
tests/mocks/Lights/qmldir (+3/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+21/-68)
tests/mocks/QMenuModel/actiondata.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+10/-0)
tests/mocks/Unity/Indicators/ActionRootState.qml (+46/-0)
tests/mocks/Unity/Indicators/qmldir (+2/-1)
tests/plugins/Unity/Indicators/rootactionstatetest.cpp (+4/-4)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Panel/Indicators/tst_IndicatorsLight.qml (+129/-0)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+52/-1)
tests/qmltests/Wizard/tst_Wizard.qml (+36/-12)
- Albert Astals Cid (community): Approve on 2014-12-10
- PS Jenkins bot: Approve (continuous-integration) on 2014-11-19
-
Diff: 117 lines (+38/-2)3 files modifieddebian/changelog (+6/-0)
libqmenumodel/src/qdbusactiongroup.cpp (+23/-2)
libqmenumodel/src/qdbusactiongroup.h (+9/-0)
- Michael Zanetti (community): Approve on 2015-01-20
- Michał Sawicz: Needs Fixing on 2015-01-16
-
Diff: 1841 lines (+1038/-301)33 files modifieddebian/control (+3/-3)
plugins/Lights/Lights.cpp (+9/-24)
plugins/Unity/Indicators/CMakeLists.txt (+3/-1)
plugins/Unity/Indicators/actionrootstate.cpp (+97/-0)
plugins/Unity/Indicators/actionrootstate.h (+55/-0)
plugins/Unity/Indicators/modelactionrootstate.cpp (+127/-0)
plugins/Unity/Indicators/modelactionrootstate.h (+61/-0)
plugins/Unity/Indicators/plugin.cpp (+4/-2)
plugins/Unity/Indicators/rootstateparser.cpp (+75/-142)
plugins/Unity/Indicators/rootstateparser.h (+20/-36)
qml/Greeter/Clock.qml (+1/-1)
qml/Panel/IndicatorItem.qml (+0/-8)
qml/Panel/Indicators/IndicatorBase.qml (+1/-1)
qml/Panel/Indicators/IndicatorsLight.qml (+19/-1)
qml/Panel/IndicatorsBar.qml (+29/-20)
qml/Panel/IndicatorsMenu.qml (+5/-0)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/Lights/CMakeLists.txt (+8/-0)
tests/mocks/Lights/Lights.cpp (+84/-0)
tests/mocks/Lights/Lights.h (+66/-0)
tests/mocks/Lights/plugin.cpp (+33/-0)
tests/mocks/Lights/plugin.h (+32/-0)
tests/mocks/Lights/qmldir (+3/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+7/-57)
tests/mocks/QMenuModel/actiondata.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+10/-0)
tests/mocks/Unity/Indicators/ActionRootState.qml (+46/-0)
tests/mocks/Unity/Indicators/qmldir (+2/-1)
tests/plugins/Unity/Indicators/rootactionstatetest.cpp (+4/-4)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Panel/Indicators/tst_IndicatorsLight.qml (+129/-0)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+50/-0)
- Lars Karlitski (community): Approve on 2015-02-19
- PS Jenkins bot: Approve (continuous-integration) on 2015-02-19
-
Diff: 123 lines (+46/-15)2 files modifiedsrc/im-application-list.c (+29/-15)
tests/manual (+17/-0)
| summary: |
- if u8 crashes while you had a notification and the screen was off, then - the led can stay on. + Notification LED stays on when no messages in notification center |
| description: | updated |
| Nick Dedekind (nick-dedekind) wrote : | #1 |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Changed in unity8 (Ubuntu): | |
| status: | New → In Progress |
| Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package unity8 - 8.02+15.
---------------
unity8 (8.02+15.
[ Michał Sawicz ]
* We don't need the SIGSTOP in main() any more.
* Add a test to make sure the shell always starts disabled until it is
enabled by a complete PAM interaction.
[ Leo Arias ]
* Added an autopilot test for the edges demo.
[ Nick Dedekind ]
* Unhook Lights interface from indicator widgets (LP: #1385331)
[ Albert Astals ]
* Fix going to scopes when the Manage Dash is open (LP: #1403464)
* QSortFilterProx
* Clip the Scopes List header
* Fix ScopesList not being under finger
* Make waitForRendering with no item fail instead of crash
* Disable Dash horizontal scroll while Navigation InverseMouseArea is
pressed (LP: #1403048)
* Test: Make sure the mouse area is enabled before clicking into it
* Test: We actually need to click on the customBackButton and not on
backButton
* Test: By default mouseX act on the middle
[ Michael Terry ]
* Don't block handling power events on loading the greeter's qml and
the background image.
* Show OSK above the wizard. (LP: #1401213)
* Unify the name of the Greeter DBus test, make it use our standard
binary test macro (which also nicely exports xml results), and make
the test a little more robust against timing issues.
* Add a test to make sure the shell always starts disabled until it is
enabled by a complete PAM interaction.
[ Martin Pitt ]
* tests: Fix Notify.
with unpatched libnotify API. (LP: #1223401)
[ Rodney Dawes ]
* Depend on :native version of g++ to allow cross-compiling to work.
(LP: #1353855)
-- Ubuntu daily release <email address hidden> Fri, 09 Jan 2015 10:43:06 +0000
| Changed in unity8 (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| milestone: | none → ww03-2015 |
| status: | New → Confirmed |
| Changed in unity8 (Ubuntu RTM): | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| milestone: | none → 14.09-ota-2 |
| importance: | Critical → High |
| Changed in unity8 (Ubuntu): | |
| importance: | Undecided → High |
| Changed in unity8 (Ubuntu RTM): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Michał Sawicz (saviq) |
| Changed in qmenumodel (Ubuntu): | |
| status: | New → Fix Released |
| importance: | Undecided → High |
| assignee: | nobody → Nick Dedekind (nick-dedekind) |
| Changed in qmenumodel (Ubuntu RTM): | |
| status: | New → In Progress |
| assignee: | nobody → Michał Sawicz (saviq) |
| milestone: | none → 14.09-ota-2 |
| Changed in unity8 (Ubuntu RTM): | |
| status: | In Progress → Triaged |
| Changed in qmenumodel (Ubuntu RTM): | |
| status: | In Progress → Triaged |
| assignee: | Michał Sawicz (saviq) → Nick Dedekind (nick-dedekind) |
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | Michał Sawicz (saviq) → Nick Dedekind (nick-dedekind) |
| Changed in qmenumodel (Ubuntu RTM): | |
| assignee: | Nick Dedekind (nick-dedekind) → Michał Sawicz (saviq) |
| status: | Triaged → In Progress |
| Changed in unity8 (Ubuntu RTM): | |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| milestone: | ww03-2015 → ww05-2015 |
| Changed in unity8 (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Released → Confirmed |
| status: | Confirmed → In Progress |
| Ken VanDine (ken-vandine) wrote : | #3 |
This is marked as fixed for vivid, but I'm still seeing this on vivid-proposed image 77 mako.
| Michał Sawicz (saviq) wrote : | #4 |
Ken, can you post steps to reproduce if you find them? Potentially as a different bug?
| Ken VanDine (ken-vandine) wrote : | #5 |
Not sure really, with the screen off and no notifications in the indicator the light blinks.
| Ken VanDine (ken-vandine) wrote : | #6 |
An observation, what I'm seeing on vivid isn't just the LED, the messaging indicator icon actually isn't being changed after clearing the notifications. This is what's keeping the LED lit, it just follows the status of the icon. So the bug I'm seeing is actually the notification icon not changing when the indicator is cleared.
| Changed in canonical-devices-system-image: | |
| milestone: | ww05-2015 → ww07-2015 |
| Michał Sawicz (saviq) wrote : | #7 |
That would be the messaging indicator then. Or! If you wait for a second or two, I've seen the items coming back into view after all, maybe you're seeing the same?
| Niklas Wenzel (nikwen) wrote : | #8 |
Ken, I guess you're talking about the following bug: https:/
Would be nice if you confirm it. :)
| Michał Sawicz (saviq) wrote : | #9 |
This is now on the indicator-messages side, IIUC it should hide from the panel if there are no unread messages? Whether it should change the icon (grey vs. white-ish, on which the LED state is based on) I'm not sure?
| Changed in qmenumodel (Ubuntu RTM): | |
| status: | In Progress → Fix Released |
| Niklas Wenzel (nikwen) wrote : | #10 |
@saviq: It currently doesn't seem to recognize when messages are cleared. Therefore, the icon stays white (=> unread messages) and the LED stays on.
That's what https:/
| Launchpad Janitor (janitor) wrote : | #11 |
Status changed to 'Confirmed' because the bug affects multiple users.
| Changed in indicator-messages (Ubuntu): | |
| status: | New → Confirmed |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Thomas Strehl (strehl-t) |
| milestone: | ww07-2015 → ww09-2015 |
| Ted Gould (ted) wrote : | #12 |
Seems to be related to the push-client, were I think this might be an i-messages bug is that we're not showing the offending tweet (in this case). The push-client doesn't seem to be responding to the clearing if items.
== Two messages show, blue icon ==
$ gdbus call --session --dest com.canonical.
({'remove-all': (true, signature '', @av []), 'status': (true, 's', [<'offline'>]), 'messages': (true, '', [<{'icon': <('themed', <['indicator-
== Clear All, blue icon ==
$ gdbus call --session --dest com.canonical.
({'remove-all': (true, signature '', @av []), 'status': (true, 's', [<'offline'>]), 'messages': (true, '', [<{'icon': <('themed', <['indicator-
== Restart Push Client, icon is removed ==
$ restart ubuntu-push-client
ubuntu-push-client start/running, process 24811
$ gdbus call --session --dest com.canonical.
| Niklas Wenzel (nikwen) wrote : | #13 |
I also noticed SMS notifications are cleared fine, with the LED turning off.
| Ted Gould (ted) wrote : | #14 |
Okay, to recreate. Start up the device. Send this from ADB shell:
gdbus call --session --dest com.ubuntu.Postal --object-path /com/ubuntu/
Then on the messaging menu select "Clear All". Notice the tweet is removed from the list but the envelope remains signaling new messages.
| Changed in indicator-messages (Ubuntu): | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Ted Gould (ted) |
| importance: | Undecided → High |
| Launchpad Janitor (janitor) wrote : | #15 |
This bug was fixed in the package indicator-messages - 13.10.1+
---------------
indicator-messages (13.10.
[ Ted Gould ]
* Provide functions that allow for action names directly (LP:
#1385331)
-- CI Train Bot <email address hidden> Thu, 19 Feb 2015 15:55:54 +0000
| Changed in indicator-messages (Ubuntu): | |
| status: | In Progress → Fix Released |
| Niklas Wenzel (nikwen) wrote : | #16 |
Thank you for the fix. :)
| Changed in canonical-devices-system-image: | |
| milestone: | ww09-2015 → ww11-2015 |
| status: | In Progress → Fix Released |


There is a possibility that if unity8 crashes while the light state is set, then it can keep that state if u8 comes back up with no notifications.
We need to decouple the usage from the lights plugin from the messaging indicator widget so that it will keep the lights state up to date.