Indicator sound menu always showing media player in "running" state
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Fix Released
|
Medium
|
Nick Dedekind |
Bug Description
Even if nothing is playing or loaded into a music player, the player still shows in running state.
Unity8 should be using the state in conjunction with the running flag to determine if it should display track info.
Partial output of actions shows "running=true"
dbus-send --print-reply --session --dest=
dict entry(
string "mediaplayer-
struct {
boolean false
array [
]
]
}
)
Related branches
- Andrea Cimitan (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Michał Sawicz: Abstain
- Albert Astals Cid (community): Abstain
-
Diff: 2632 lines (+1031/-735)28 files modifieddebian/control (+2/-2)
plugins/Unity/Indicators/CMakeLists.txt (+0/-9)
plugins/Unity/Indicators/plugin.cpp (+0/-2)
plugins/Unity/Indicators/resources/artwork/messaging/default_app.svg (+0/-42)
plugins/Unity/Indicators/resources/indicators.qrc (+0/-6)
plugins/Utils/CMakeLists.txt (+1/-0)
plugins/Utils/plugin.cpp (+2/-0)
plugins/Utils/relativetimeformatter.cpp (+268/-0)
plugins/Utils/relativetimeformatter.h (+34/-0)
plugins/Utils/timeformatter.cpp (+6/-1)
plugins/Utils/timeformatter.h (+3/-1)
po/unity8.pot (+29/-25)
qml/Components/Header.qml (+27/-0)
qml/Panel/Indicators.qml (+2/-13)
qml/Panel/Indicators/DefaultIndicatorPage.qml (+8/-49)
qml/Panel/Indicators/IndicatorDelegate.qml (+2/-10)
qml/Panel/Indicators/MenuItemFactory.qml (+163/-52)
qml/Panel/Indicators/MessageMenuItemFactory.qml (+166/-181)
qml/Panel/Indicators/RemoveBackground.qml (+0/-55)
qml/Panel/Indicators/client/IndicatorsClient.qml (+4/-0)
qml/Panel/MenuContent.qml (+102/-126)
tests/mocks/Unity/Indicators/FakeMenuPage.qml (+0/-10)
tests/plugins/Utils/CMakeLists.txt (+2/-2)
tests/plugins/Utils/timeformattertest.cpp (+104/-7)
tests/qmltests/Panel/Indicators/tst_MenuItemFactory.qml (+32/-16)
tests/qmltests/Panel/Indicators/tst_MessageMenuItemFactory.qml (+43/-53)
tests/qmltests/Panel/tst_Indicators.qml (+10/-10)
tests/qmltests/Panel/tst_MenuContent.qml (+21/-63)
- Andrea Cimitan (community): Approve
- Albert Astals Cid (community): Needs Fixing
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Michael Zanetti (community): Needs Fixing
-
Diff: 4066 lines (+1369/-1495)58 files modifiedCMakeLists.txt (+1/-0)
Ubuntu/Settings/Components/ActionTextField.qml (+35/-33)
Ubuntu/Settings/Components/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Components/Calendar.qml (+2/-2)
Ubuntu/Settings/Components/IconVisual.qml (+0/-71)
Ubuntu/Settings/Components/MessageHeader.qml (+104/-134)
Ubuntu/Settings/Components/QuickReply.qml (+4/-4)
Ubuntu/Settings/Components/UbuntuShapeForItem.qml (+43/-0)
Ubuntu/Settings/Components/artwork/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Components/qmldir (+2/-2)
Ubuntu/Settings/Menus/AccessPointMenu.qml (+14/-76)
Ubuntu/Settings/Menus/ButtonMenu.qml (+15/-13)
Ubuntu/Settings/Menus/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Menus/CalendarMenu.qml (+3/-4)
Ubuntu/Settings/Menus/CheckableMenu.qml (+5/-13)
Ubuntu/Settings/Menus/EventMenu.qml (+9/-9)
Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+28/-32)
Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+39/-29)
Ubuntu/Settings/Menus/PlaybackItemMenu.qml (+53/-44)
Ubuntu/Settings/Menus/ProgressBarMenu.qml (+20/-12)
Ubuntu/Settings/Menus/ProgressValueMenu.qml (+9/-8)
Ubuntu/Settings/Menus/SectionMenu.qml (+2/-2)
Ubuntu/Settings/Menus/SeparatorMenu.qml (+3/-7)
Ubuntu/Settings/Menus/SimpleMessageMenu.qml (+66/-49)
Ubuntu/Settings/Menus/SimpleTextMessageMenu.qml (+0/-99)
Ubuntu/Settings/Menus/SliderMenu.qml (+6/-7)
Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+64/-126)
Ubuntu/Settings/Menus/StandardMenu.qml (+24/-8)
Ubuntu/Settings/Menus/SwitchMenu.qml (+38/-37)
Ubuntu/Settings/Menus/TextMessageMenu.qml (+3/-4)
Ubuntu/Settings/Menus/TimeZoneMenu.qml (+10/-7)
Ubuntu/Settings/Menus/TransferMenu.qml (+24/-18)
Ubuntu/Settings/Menus/UserSessionMenu.qml (+28/-19)
Ubuntu/Settings/Menus/artwork/CMakeLists.txt (+0/-2)
Ubuntu/Settings/Menus/artwork/default_app.svg (+0/-42)
Ubuntu/Settings/Menus/artwork/secure.svg (+0/-71)
Ubuntu/Settings/Menus/qmldir (+1/-3)
debian/changelog (+8/-0)
debian/control (+2/-2)
examples/CMakeLists.txt (+2/-0)
examples/MessageComponents.qml (+119/-0)
examples/OtherComponents.qml (+237/-0)
examples/SettingsComponents.qml (+29/-254)
examples/TransferComponents.qml (+84/-0)
runtests.sh (+2/-2)
tests/qmltests/CMakeLists.txt (+3/-2)
tests/qmltests/Menus/tst_AccessPointMenu.qml (+3/-21)
tests/qmltests/Menus/tst_ButtonMenu.qml (+1/-1)
tests/qmltests/Menus/tst_CheckableMenu.qml (+2/-2)
tests/qmltests/Menus/tst_EventMenu.qml (+1/-1)
tests/qmltests/Menus/tst_GroupedMessageMenu.qml (+1/-1)
tests/qmltests/Menus/tst_MediaPlayerMenu.qml (+10/-10)
tests/qmltests/Menus/tst_PlaybackItemMenu.qml (+1/-1)
tests/qmltests/Menus/tst_SimpleMessageMenu.qml (+57/-50)
tests/qmltests/Menus/tst_SnapDecisionMenu.qml (+82/-95)
tests/qmltests/Menus/tst_SwitchMenu.qml (+2/-2)
tests/qmltests/Menus/tst_TextMessageMenu.qml (+67/-57)
tests/utils/modules/Ubuntu/Test/UbuntuTestCase.qml (+1/-1)
summary: |
- "running" flag in sound menu action state is always set to true + "running" flag in indicator sound menu action state is always set to + true |
summary: |
- "running" flag in indicator sound menu action state is always set to - true + Indicator sound menu always showing media player in "running" state |
description: | updated |
Changed in unity8 (Ubuntu): | |
status: | In Progress → Fix Released |
no longer affects: | media-hub |
"running" means that the application process is running and exposing the MPRIS interface. It has nothing to do with the play status (that's "state") or whether something's loaded into the player (that's "title" / "artist" / "album").