[Dash] Activating a preview with a scope URI for the current scope doesn't send you back to the results view
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | unity-scopes-shell (Ubuntu) |
Medium
|
Paweł Stołowski | ||
| | unity8 (Ubuntu) |
Medium
|
Albert Astals Cid | ||
| | unity8 (Ubuntu RTM) |
Medium
|
Unassigned | ||
Bug Description
You'll have to compile (prototype) the Youtube scope from source (https:/
Basically the workflow is:
1) Search for something that has a result with a scope URI for the current scope. In the case of Youtube, search for "queenofficial" to get Queen's music channel.
2) Preview the first item (the channel itself), and click the search button.
3) This runs a new query for the current scope, but doesn't switch away from the preview view).
4) You will see a preview of the first video in the new results list.
Like when searching other scopes, the view should be returned to the results list, instead of saying in the preview "view".
Related branches
- Marcus Tomlinson (community): Approve on 2015-04-28
- PS Jenkins bot: Approve (continuous-integration) on 2015-04-27
- Pete Woods (community): Approve on 2015-04-27
-
Diff: 286 lines (+114/-3)10 files modifiedpo/unity-plugin-scopes.pot (+1/-1)
src/Unity/previewstack.cpp (+5/-0)
src/Unity/previewstack.h (+1/-0)
src/Unity/scope.cpp (+2/-0)
src/scope-harness/internal/preview-widget-arguments.h (+3/-0)
src/scope-harness/preview/preview-widget.cpp (+39/-1)
src/scope-harness/view/preview-view.cpp (+1/-1)
src/scope-harness/view/results-view.h (+2/-0)
tests/data/mock-scope/mock-scope.cpp (+34/-0)
tests/previewtest.cpp (+26/-0)
| description: | updated |
| description: | updated |
| Michał Sawicz (saviq) wrote : | #1 |
| Michał Sawicz (saviq) wrote : | #2 |
Or whatever calls showDash()? ;)
| Changed in unity-scopes-shell: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| Paweł Stołowski (stolowski) wrote : | #3 |
This is also appears to be broken for actions which have "uri" attribute set to a canned query, except for Scopes scope previews (works for favorited scopes?)
| tags: | added: rtm14 |
| no longer affects: | unity8 |
| Changed in unity8 (Ubuntu): | |
| importance: | Undecided → Medium |
| tags: | added: ota-1 |
| tags: | added: touch-2014-10-09 |
| Changed in unity-scopes-shell: | |
| importance: | High → Medium |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| no longer affects: | unity-scopes-shell |
| Paweł Stołowski (stolowski) wrote : | #4 |
It seems that openScope() signal of Scope object that's emitted in such cases doesn't cause change active scope when in the preview.
| tags: |
added: touch-2014-11-13 removed: touch-2014-10-09 |
| kevin gunn (kgunn72) wrote : | #5 |
@saviq - so it doesn't get lost, but this feels like it might be addressed through bug 1368670
| tags: | removed: touch-2014-11-13 |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Michał Sawicz (saviq) |
| Robert Schroll (rschroll) wrote : | #6 |
I have a simple scope that seems to exhibit the same problem: https:/
| Riccardo Padovani (rpadovani) wrote : | #7 |
I have the same problem here: https:/
Do a search for "countries in Europe", click on the first result, click on "Tell me more" - a new search is done, but the preview isn't closed
| Launchpad Janitor (janitor) wrote : | #8 |
Status changed to 'Confirmed' because the bug affects multiple users.
| Changed in unity8 (Ubuntu): | |
| status: | New → Confirmed |
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | nobody → Michał Sawicz (saviq) |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Paweł Stołowski (stolowski) wrote : | #9 |
I've just checked vivid and it's still the case. Note, the original steps to reproduce no longer apply because youtube scope doesn't seem to be producing previews for channels with 'Search' button. I'm not sure which of the existing scopes exhibit it offhand.
I've reproduced it again with slightly modifed mediascanner-video scope (added a 'Search' button to its preview). After some more tests I can conclude the following about preview buttons which have uris set to canned queries (should execute search):
* it works, when it points to a different scope than the one displaying the preview.
* it doesn't work when it points to the same scope. In such case the search is executed in the background, but preview is not dismissed. After exiting the preview manually one can see new search results proving the query was in fact executed.
Here is the change I applied to mediascanner scope for reproducing; change uri to "scope:
=== modified file 'src/myvideos/
--- src/myvideos/
+++ src/myvideos/
@@ -281,6 +281,12 @@
});
+ builder.add_tuple({
+ {"id", Variant("sr")},
+ {"uri", Variant(
+ {"label", Variant(
+ });
+
}
| Changed in unity8 (Ubuntu): | |
| status: | Confirmed → Triaged |
| Michał Sawicz (saviq) wrote : | #10 |
Assuming we get notice from the Scopes object, it would be a relatively easy fix on our side.
| Changed in unity8 (Ubuntu): | |
| assignee: | Michał Sawicz (saviq) → Albert Astals Cid (aacid) |
| Changed in unity8 (Ubuntu RTM): | |
| assignee: | Michał Sawicz (saviq) → nobody |
| Albert Astals Cid (aacid) wrote : | #11 |
After a quick chat with Pawel we don't need any change from the unity8 side
| Changed in unity8 (Ubuntu): | |
| status: | Triaged → Invalid |
| Changed in unity8 (Ubuntu RTM): | |
| status: | Confirmed → Invalid |
| Changed in unity-scopes-shell (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | Confirmed → In Progress |
| Launchpad Janitor (janitor) wrote : | #12 |
This bug was fixed in the package unity-scopes-shell - 0.5.4+15.
---------------
unity-scopes-shell (0.5.4+
[ CI Train Bot ]
* New rebuild forced.
[ Pawel Stolowski ]
* Emit showDash() signal if canned query is executed for current
scope. (LP: #1335761)
* Reset user data set with previously executed canned query when shell
calls setSearchQuery() (i.e.user typed a new search). (LP: #1449928)
-- CI Train Bot <email address hidden> Wed, 29 Apr 2015 11:44:18 +0000
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | In Progress → Fix Released |


Are you sending HIDE_PREVIEW activation result?