Support providing fallback images
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Alejandro J. Cura | ||
thumbnailer (Ubuntu) |
Fix Released
|
High
|
James Henstridge | ||
unity-scopes-api (Ubuntu) |
Fix Released
|
Undecided
|
Michi Henning | ||
unity-scopes-shell (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Albert Astals Cid |
Bug Description
If the URI for a scope result icon can not be loaded, the scope result is not easily visible.
To counter this, the shell should replace the result image with a fallback image if the Image QML component changes to the Error state. At a minimum a single standard fallback image would be sufficient, but letting the scope pick a custom fallback via the category renderer template would be better.
One reason I'd like to see this is so we can switch the album art image provider to stop returning a fallback image. This has been requested by the music-app guys, and seems sensible since we might want different fallbacks in different contexts:
https:/
It might also be useful for remote scopes using http: URIs for result icons.
Related branches
- Paweł Stołowski (community): Approve
- Michał Sawicz: Approve
- Facundo Batista (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 201 lines (+57/-15)6 files modifiedCMakeLists.txt (+1/-1)
RELEASE_NOTES.md (+12/-0)
debian/changelog (+14/-0)
include/unity/scopes/PreviewWidget.h (+4/-2)
src/scopes/CategoryRenderer.cpp (+17/-9)
src/scopes/PreviewWidget.cpp (+9/-3)
- Andrea Cimitan (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Michi Henning (community): Approve
-
Diff: 360 lines (+151/-8)9 files modifiedplugins/Dash/CardCreator.js (+8/-0)
qml/Components/ZoomableImage.qml (+1/-0)
qml/Dash/Previews/PreviewHeader.qml (+6/-0)
qml/Dash/Previews/PreviewImageGallery.qml (+14/-0)
qml/Dash/Previews/PreviewZoomableImage.qml (+13/-0)
tests/qmltests/Dash/Previews/tst_PreviewHeader.qml (+30/-0)
tests/qmltests/Dash/Previews/tst_PreviewImageGallery.qml (+22/-2)
tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml (+27/-6)
tests/qmltests/Dash/tst_Card.qml (+30/-0)
- Michi Henning (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 606 lines (+152/-134)19 files modifieddata/CMakeLists.txt (+0/-8)
data/thumbnailer.in (+1/-6)
debian/control (+2/-11)
debian/thumbnailer-common.install (+0/-2)
debian/thumbnailer-service.install (+1/-0)
plugins/Ubuntu/Thumbnailer.0.1/albumartgenerator.cpp (+3/-11)
plugins/Ubuntu/Thumbnailer.0.1/artistartgenerator.cpp (+3/-11)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+13/-19)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.h (+4/-10)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailgenerator.cpp (+2/-29)
tests/image-provider/image-provider_test.cpp (+82/-0)
tests/qml/CMakeLists.txt (+4/-0)
tests/qml/Fixture.qml (+8/-10)
tests/qml/tst_albumart.qml (+13/-14)
tests/qml/tst_photo.qml (+1/-1)
tests/testsetup.h.in (+0/-1)
tests/utils/artserver.cpp (+0/-1)
tests/utils/testutils.cpp (+11/-0)
tests/utils/testutils.h (+4/-0)
- Michi Henning (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- James Henstridge: Pending requested
-
Diff: 606 lines (+152/-134)19 files modifieddata/CMakeLists.txt (+0/-8)
data/thumbnailer.in (+1/-6)
debian/control (+2/-11)
debian/thumbnailer-common.install (+0/-2)
debian/thumbnailer-service.install (+1/-0)
plugins/Ubuntu/Thumbnailer.0.1/albumartgenerator.cpp (+3/-11)
plugins/Ubuntu/Thumbnailer.0.1/artistartgenerator.cpp (+3/-11)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+13/-19)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.h (+4/-10)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailgenerator.cpp (+2/-29)
tests/image-provider/image-provider_test.cpp (+82/-0)
tests/qml/CMakeLists.txt (+4/-0)
tests/qml/Fixture.qml (+8/-10)
tests/qml/tst_albumart.qml (+13/-14)
tests/qml/tst_photo.qml (+1/-1)
tests/testsetup.h.in (+0/-1)
tests/utils/artserver.cpp (+0/-1)
tests/utils/testutils.cpp (+11/-0)
tests/utils/testutils.h (+4/-0)
Changed in unity8: | |
status: | New → Triaged |
importance: | Undecided → High |
summary: |
- Shell should use a fallback icon if the icon specified for a scope - result could not be loaded + Support providing fallback images |
Changed in unity8: | |
assignee: | nobody → Unity UI Team (unity-ui-team) |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Unity UI Team (unity-ui-team) |
importance: | Undecided → High |
status: | New → Triaged |
no longer affects: | unity8 |
affects: | unity-scopes-api → unity-scopes-api (Ubuntu) |
Changed in unity8 (Ubuntu): | |
assignee: | Unity UI Team (unity-ui-team) → nobody |
no longer affects: | unity-scopes-shell |
Changed in unity-scopes-api (Ubuntu): | |
assignee: | nobody → Michi Henning (michihenning) |
status: | New → In Progress |
Changed in unity-scopes-api (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity-scopes-api (Ubuntu): | |
status: | Fix Committed → Fix Released |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Albert Astals Cid (aacid) |
Changed in unity8 (Ubuntu): | |
status: | Triaged → In Progress |
Changed in thumbnailer: | |
importance: | Undecided → High |
Changed in thumbnailer (Ubuntu): | |
importance: | Undecided → High |
status: | New → In Progress |
no longer affects: | thumbnailer |
Changed in thumbnailer (Ubuntu): | |
assignee: | nobody → James Henstridge (jamesh) |
Changed in unity-scopes-shell (Ubuntu): | |
status: | Confirmed → Invalid |
Changed in thumbnailer (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
milestone: | none → ww08-2016 |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Alejandro J. Cura (alecu) |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
When this is fixed, we'll need to remove the fixed fallback in the artist art image provider too.