Screen unlock helpers needs to be simpler for developers
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Triaged
|
Medium
|
Omer Akram |
Bug Description
Right now the screen unlocking helper in process_helpers.py provides two functions. One to unlock the screen and the other to start unity in testability but they are not called from within each other.
What would make more sense and also make the life of developers easy is that unlock_unity() should itself check if unity is running in testability and if not start it in testability and unlock the screen. Also if the screen is already unlocked it should just do nothing instead of raising an exception.
With the above suggestion I think it makes more sense to rename that function to ensure_
Currently I am using something like this and calling it in setUp():
def ensure_
unity_pid = process_
try:
if get_proxy_
except RuntimeError:
ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: unity8 7.83+14.
ProcVersionSign
Uname: Linux 3.12.0-2-generic i686
NonfreeKernelMo
ApportVersion: 2.12.6-0ubuntu1
Architecture: i386
Date: Tue Nov 12 17:47:38 2013
InstallationDate: Installed on 2013-11-07 (4 days ago)
InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Alpha i386 (20131107)
MarkForUpload: True
SourcePackage: unity8
UpgradeStatus: No upgrade log present (probably fresh install)
no longer affects: | unity8 |
I can work on it if we have an agreement.