Ubuntu
unity8 package

[SIDESTAGE] can't dismiss the sidestage through grab when only sidestage app is running

Bug #1129290 reported by Oren Horev
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Released
Critical
Oren Horev
unity8 (Ubuntu)
Fix Released
Medium
Michael Zanetti

Bug Description

When only sidestage is running (over the dash). The user should be able to use the grab handle to dismiss the sidestage. This should refocus the dash on the app lens (equivalent of a long left edge swipe).

Tags: unity-public

Related branches

lp:~aacid/unity8/new-scopes-show-dash-app-running
Unity Team: Pending requested
Diff: 285 lines (+119/-66)
2 files modified
qml/Components/Showable.qml (+8/-0)
qml/Shell.qml (+111/-66)
lp:~unity-team/unity8/right-edge-2
Michał Sawicz: Approve
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Leo Arias (community): Needs Information (autopilot code review)
Mirco Müller: Pending requested
Gerry Boland: Pending requested
Albert Astals Cid: Pending requested
Ubuntu Unity PS integration team: Pending (packaging) requested
Vesa Rautiainen: Pending requested
Diff: 4314 lines (+2423/-902)
42 files modified
debian/changelog (+7/-0)
debian/control (+7/-4)
debian/unity8.install (+1/-1)
plugins/Utils/CMakeLists.txt (+2/-1)
plugins/Utils/easingcurve.cpp (+67/-0)
plugins/Utils/easingcurve.h (+70/-0)
plugins/Utils/plugin.cpp (+2/-0)
qml/CMakeLists.txt (+1/-1)
qml/Components/ApplicationManagerWrapper.qml (+0/-169)
qml/Components/ApplicationScreenshot.qml (+0/-61)
qml/Components/ApplicationsModelStageFiltered.qml (+0/-49)
qml/Components/ResponsiveFlowView.qml (+3/-10)
qml/Dash/Apps/RunningApplicationTile.qml (+15/-25)
qml/Dash/Apps/RunningApplicationsGrid.qml (+5/-20)
qml/Dash/DashApps.qml (+4/-5)
qml/Dash/GenericScopeView.qml (+2/-2)
qml/Launcher/Launcher.qml (+2/-1)
qml/Panel/Panel.qml (+1/-1)
qml/Shell.qml (+231/-333)
qml/SideStage/SideStage.qml (+0/-73)
qml/Stages/PhoneStage.qml (+499/-0)
qml/Stages/SpreadDelegate.qml (+55/-0)
qml/Stages/StageWithSideStage.qml (+407/-0)
qml/Stages/SwitchingApplicationImage.qml (+81/-0)
qml/Stages/TransformedSpreadDelegate.qml (+327/-0)
tests/autopilot/unity8/shell/emulators/dash.py (+1/-4)
tests/autopilot/unity8/shell/emulators/main_window.py (+1/-1)
tests/mocks/Unity/Application/ApplicationInfo.cpp (+9/-0)
tests/mocks/Unity/Application/ApplicationInfo.h (+2/-0)
tests/mocks/Unity/Application/ApplicationManager.cpp (+109/-3)
tests/mocks/Unity/Application/ApplicationManager.h (+16/-0)
tests/mocks/Unity/Application/ApplicationScreenshotProvider.cpp (+74/-0)
tests/mocks/Unity/Application/ApplicationScreenshotProvider.h (+34/-0)
tests/mocks/Unity/Application/CMakeLists.txt (+1/-0)
tests/mocks/Unity/Application/plugin.cpp (+18/-3)
tests/mocks/Unity/Application/plugin.h (+1/-0)
tests/plugins/Unity/Launcher/launchermodeltest.cpp (+5/-0)
tests/qmltests/CMakeLists.txt (+1/-1)
tests/qmltests/Components/tst_ResponsiveFlowView.qml (+1/-2)
tests/qmltests/Dash/Apps/tst_RunningApplicationsGrid.qml (+57/-124)
tests/qmltests/Stages/tst_PhoneStage.qml (+288/-0)
tests/qmltests/tst_Shell.qml (+16/-8)
Florian Boucault (fboucault)
Changed in manhattan:
importance: Critical → High
status: New → Confirmed
Andrea Cimitan (cimi)
tags: added: unity-public
Alan Pope 🍺🐧🐱 🦄 (popey)
information type: Private → Public
affects: manhattan → unity
Revision history for this message
Michał Sawicz (saviq) wrote :

Added ubuntu-ux for design guidance.

no longer affects: unity/phablet
Changed in unity:
assignee: Florian Boucault (fboucault) → nobody
status: Confirmed → Invalid
importance: High → Medium
importance: Medium → Undecided
Michał Sawicz (saviq)
affects: unity → unity8
Changed in unity8:
status: Invalid → Incomplete
no longer affects: unity/8.0
Michał Sawicz (saviq)
Changed in unity8:
status: Incomplete → Triaged
importance: Undecided → Medium
assignee: nobody → Unity UI Team (unity-ui-team)
no longer affects: ubuntu-ux
Oren Horev (oreneeshy)
Changed in ubuntu-ux:
assignee: nobody → Oren Horev (oreneeshy)
status: New → Fix Committed
Oren Horev (oreneeshy)
Changed in ubuntu-ux:
importance: Undecided → Critical
Nicolas d'Offay (nicolas-doffay)
Changed in unity8:
assignee: Unity UI Team (unity-ui-team) → Nicolas d'Offay (nicolas-doffay)
assignee: Nicolas d'Offay (nicolas-doffay) → nobody
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu):
status: New → Triaged
Changed in unity8:
assignee: nobody → Loïc Molinari (loic.molinari)
Revision history for this message
kevin gunn (kgunn72) wrote :

per design feedback - still valid

Revision history for this message
John McAleely (john.mcaleely) wrote :

tagging as mwcdemo2014 - this seems to be very easu to tumble over in the tablet demo script.

tags: added: mwcdemo2014
Revision history for this message
John McAleely (john.mcaleely) wrote :

triaged as 'high' here: https://docs.google.com/a/canonical.com/spreadsheet/ccc?key=0AnhaJaYdDD6udHN1V1owS1ZLc2xFZkxZNmhGaFEwTlE#gid=2

Revision history for this message
Alexander Sack (asac) wrote :

needs an owner/priority bump if its critical for mwc. AFAIK, loicm is not working on sidestage, so there might be better owners.

Michał Sawicz (saviq)
Changed in unity8:
assignee: Loïc Molinari (loic.molinari) → nobody
Revision history for this message
Michał Sawicz (saviq) wrote :

Are we sure this is a big issue? Bearing in mind this bug didn't have prio for a year now, and the whole side-stage / right-edge behaviour is being revisited?

Revision history for this message
Alexander Sack (asac) wrote :

I think the reason for this getting prio now is that there is something in the demo script that runs into this issue:

 "tagging as mwcdemo2014 - this seems to be very easu to tumble over in the tablet demo script."

Revision history for this message
John McAleely (john.mcaleely) wrote :

Discussed with saviq in IRC. If we get bug #1281199, we can work around this one without any difficulty:

<Saviq> john-mcaleely, the "can't dismiss side-stage when no main-stage app" issue is somewhat a corner case and I don't see how it's a big issue, could you explain a use case?
* cwayne (<email address hidden>) has joined #phablet
<john-mcaleely> Saviq, ok - just checked with victorp and I agree with you. it ties with LP#1281629
<_mup_> Bug #1281629: Launching sidestage apps from launcher prevents launcher from opening <mwcdemo2014> <unity8 (Ubuntu):New> <https://launchpad.net/bugs/1281629>
<john-mcaleely> so if we fix 1281629, & 1281199
<john-mcaleely> then 1129290 is fine to live with. And I'll get victor to change the spreadsheet
<Saviq> john-mcaleely, yeah, I thought so - once we're able to use the launcher (and so dismiss the app by swiping from left edge), we're good
<Saviq> john-mcaleely, ok thanks

NB, bug #1281629 is a dupe of #1281199

Michał Sawicz (saviq)
tags: removed: mwcdemo2014
Albert Astals Cid (aacid)
Changed in unity8:
assignee: nobody → Albert Astals Cid (aacid)
status: Triaged → In Progress
Michael Zanetti (mzanetti)
Changed in unity8:
assignee: Albert Astals Cid (aacid) → Michael Zanetti (mzanetti)
status: In Progress → Fix Released
kevin gunn (kgunn72)
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
Changed in unity8 (Ubuntu):
status: Triaged → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: nobody → Michael Zanetti (mzanetti)
importance: Undecided → Medium
no longer affects: unity8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.