BGHash: Check for 'picture-option', not only 'picture-uri'

[Hernando Torque]

In BGHash.cpp, the decision whether to use the background image or the solid color(s) do determine the tint color is based on the existence of the background filename:

    const gchar *filename = gnome_bg_get_filename (bg);
    if (filename == NULL)
    {
      // we might have a gradient instead

However, it also depends on the value of 'picture-options'. It's possible* to have a valid background filename and 'picture-options' set to 'none', causing a solid background/gradient to show. In Unity 5.6, it then would tint launcher & co. with the color from the background image.

To reproduce, run the following in a terminal:

gsettings set org.gnome.desktop.background color-shading-type "solid"
gsettings set org.gnome.desktop.background primary-color "#ffffff"
gsettings set org.gnome.desktop.background picture-uri "file:///usr/share/backgrounds/warty-final-ubuntu.png"
gsettings set org.gnome.desktop.background picture-options "none"

→ you'll see a white solid background with a launcher tinted with the color from the default wallpaper.

*) You have to manually set this, but it works. I'd understand if you decide to close this report as 'Opinion'.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: unity 5.6.0-0ubuntu3
ProcVersionSignature: Ubuntu 3.2.0-18.29-generic 3.2.9
Uname: Linux 3.2.0-18-generic x86_64
ApportVersion: 1.94.1-0ubuntu2
Architecture: amd64
CompizPlugins: [core,composite,opengl,decor,mousepoll,vpswitch,regex,animation,snap,expo,move,compiztoolbox,place,grid,imgpng,gnomecompat,wall,ezoom,workarounds,resize,fade,unitymtgrabhandles,scale,session,unityshell]
Date: Wed Mar 14 02:16:12 2012
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta amd64 (20110901)
SourcePackage: unity
UpgradeStatus: No upgrade log present (probably fresh install)

[Andrea Azzarone (azzar1)]

BGHash now uses _GNOME_BACKGROUND_REPRESENTATIVE_COLORS atom. Marking as invalid.