SetEnterFocusInputArea should be removed/deprecated as it is not used

Bug #776496 reported by Alejandro Piñeiro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nux
Triaged
Undecided
Unassigned
Unity
Triaged
Low
Unassigned
nux (Ubuntu)
Triaged
Undecided
Unassigned
unity (Ubuntu)
Triaged
Low
Unassigned

Bug Description

BACKGROUND

Some months ago, while implementing the accessibility support for the Launcher I realized that the Launcher didn't emit properly the signals InputArea::OnStartFocus and InputArea::OnEndFocus, as was the parent the one emitting it.

So Jay included the concept of the _enter_focus_input_area, the InputArea inside the BaseWindow that effectively would receive the keyboard focus, and Unity started to use it.

CURRENT STATE

But right now SetEnterFocusInputArea is not used at all on Nux, and although it is used on Unity (PlacesController and unityshell), the field that it sets "_enter_focus_input_area" is not used at all.

In the specific case of the Launcher, it seems that gets/free the keyboard focus using GrabKeyboard/UnGrabKeyboard, and after a quick smoke test, it seems that removing that call doesn't have any effect.

So I would suggest to remove that method, and update accordingly Unity, as it seems that is useless.

Changed in nux:
status: New → Opinion
Changed in unity:
status: New → Opinion
Changed in nux (Ubuntu):
status: New → Opinion
Changed in nux:
status: Opinion → New
Changed in nux (Ubuntu):
status: Opinion → New
Changed in unity:
status: Opinion → New
Omer Akram (om26er)
Changed in unity:
status: New → Invalid
Jay Taoko (jaytaoko)
Changed in nux:
status: New → Triaged
Changed in unity:
status: Invalid → Triaged
Changed in nux:
assignee: nobody → Jay Taoko (jaytaoko)
Changed in unity:
assignee: nobody → Jay Taoko (jaytaoko)
Changed in nux (Ubuntu):
status: New → Triaged
Changed in unity (Ubuntu):
status: New → Confirmed
Changed in unity (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Low
Changed in unity:
importance: Undecided → Low
Changed in nux:
assignee: Jay Taoko (jaytaoko) → nobody
Changed in unity:
assignee: Jay Taoko (jaytaoko) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.