expression is always false because of matching previous condition

Bug #1500535 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
New
Undecided
Unassigned
unity (Ubuntu)
New
Medium
Unassigned

Bug Description

UnityCore/Preview.cpp, line 53 onwards:

  if (renderer_name == "preview-generic")
  {
    return std::make_shared<GenericPreview>(proto_obj);
  }
  else if (renderer_name == "preview-payment")
  {
    return std::make_shared<PaymentPreview>(proto_obj);
  }
  else if (renderer_name == "preview-payment")
  {
    return std::make_shared<PaymentPreview>(proto_obj);
  }

there are two "preview-payment" comparisons, the 2nd is redundant and should be removed. Looks like a cut-n-paste bug.

Changed in unity (Ubuntu):
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.