compiz crashed with signal 5 in _XReply() from unity::decoration::ForceQuitDialog::ForceQuitDialog

Bug #1374942 reported by Michael Blennerhassett on 2014-09-28
36
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
Marco Trevisan (Treviño)
7.2
Fix Released
Medium
Marco Trevisan (Treviño)
unity (Ubuntu)
Medium
Marco Trevisan (Treviño)
Nominated for Trusty by Stephen M. Webb
Trusty
Medium
Stephen M. Webb

Bug Description

[Impact]

An invalid line of code would occasionally cause Unity to crash.

[Test Case]

(1) Download and run the attached Python script test-1374942 to create a candidate application.
(2) Press the close button and wait for the Force Quit dialog to come up.
(3) Choose the "Force Quit" button.

The desktop shell should not crash.

[Regression Potential]

The fix for this bug involves converting an integer into a string and appending it to an error message instead of adding the integer value to the address of the error message. There is unlikely to be a regression from this.

[Other Info]

The fix for Ubuntu 14.04 LTS was cherry picked from the Ubuntu "Vivid Vervet" dev release where it has been under daily use for some time without apparent regressioon.

Related branches

information type: Private → Public

StacktraceTop:
 XGetWindowProperty (dpy=0x21dbf20, w=65013809, property=property@entry=67, offset=offset@entry=0, length=length@entry=8192, delete=delete@entry=0, req_type=31, actual_type=0x7fff49c922f0, actual_format=0x7fff49c922ec, nitems=0x7fff49c922f8, bytesafter=0x7fff49c92300, prop=0x7fff49c92308) at ../../src/GetProp.c:69
 XGetClassHint (dpy=<optimized out>, w=<optimized out>, classhint=0x7fff49c925b0) at ../../src/GetHints.c:311
 ?? () from /tmp/apport_sandbox_VLSQqv/usr/lib/compiz/libunityshell.so
 unity::decoration::ForceQuitDialog::ForceQuitDialog(CompWindow*, unsigned long) () from /tmp/apport_sandbox_VLSQqv/usr/lib/compiz/libunityshell.so
 unity::decoration::Window::Impl::ShowForceQuitDialog(bool, unsigned long) () from /tmp/apport_sandbox_VLSQqv/usr/lib/compiz/libunityshell.so

Changed in unity (Ubuntu):
importance: Undecided → Medium
tags: removed: need-amd64-retrace
Changed in unity:
importance: Undecided → Medium

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity (Ubuntu):
status: New → Confirmed
Andrea Azzarone (azzar1) on 2014-12-09
Changed in unity:
status: New → Confirmed
summary: - compiz crashed with signal 5 in _XReply()
+ compiz crashed with signal 5 in _XReply() from
+ unity::decoration::ForceQuitDialog::ForceQuitDialog
Andrea Azzarone (azzar1) on 2014-12-09
Changed in unity:
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: Confirmed → In Progress
Changed in unity:
status: Confirmed → In Progress
Changed in unity (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
milestone: none → 7.3.1
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.3.1+15.04.20150115-0ubuntu1

---------------
unity (7.3.1+15.04.20150115-0ubuntu1) vivid; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Andrea Azzarone ]
  * Disable Pointer Barriers during lockscreen. (LP: #1401911)
  * Use std::weak_ptr to avoid referencing an invalid barrier. (LP:
    #1238063)
  * Enable dash and hud if there is a fullscreen window. (LP: #1159249,
    #860970)
  * Show session dialog over fullscreen windows. (LP: #1404486)
  * Avoid running pontentially dangerous code paths when the screen is
    locked. (LP: #1410582)

  [ Marco Trevisan (Treviño) ]
  * MenuManager: make sure menus are always shown when mouse is over
    them or when the always-show-menus option is on (LP: #955193,
    #1390562, #1374942, #1312137)
 -- Ubuntu daily release <email address hidden> Thu, 15 Jan 2015 15:03:31 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Stephen M. Webb (bregma) on 2015-02-11
Changed in unity:
status: In Progress → Fix Released
Stephen M. Webb (bregma) on 2015-03-18
Changed in unity (Ubuntu Trusty):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Stephen M. Webb (bregma)
Stephen M. Webb (bregma) wrote :

Attaching the test script to use to reproduce the problem or test the solution.

description: updated

Hello Michael, or anyone else affected,

Accepted unity into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unity/7.2.4+14.04.20150316-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed

* enable proposed repository & install unity package.

$ LANG=C apt-cache policy unity libunity-core-6.0-9 unity-services
unity:
  Installed: 7.2.4+14.04.20150316-0ubuntu1
  Candidate: 7.2.4+14.04.20150316-0ubuntu1
  Version table:
 *** 7.2.4+14.04.20150316-0ubuntu1 0
        400 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     7.2.4+14.04.20141217-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-updates/main i386 Packages
     7.2.2+14.04.20140714-0ubuntu1.1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-security/main i386 Packages
     7.2.0+14.04.20140416-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty/main i386 Packages

libunity-core-6.0-9:
  Installed: 7.2.4+14.04.20150316-0ubuntu1
  Candidate: 7.2.4+14.04.20150316-0ubuntu1
  Version table:
 *** 7.2.4+14.04.20150316-0ubuntu1 0
        400 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     7.2.4+14.04.20141217-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-updates/main i386 Packages
     7.2.2+14.04.20140714-0ubuntu1.1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-security/main i386 Packages
     7.2.0+14.04.20140416-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty/main i386 Packages

unity-services:
  Installed: 7.2.4+14.04.20150316-0ubuntu1
  Candidate: 7.2.4+14.04.20150316-0ubuntu1
  Version table:
 *** 7.2.4+14.04.20150316-0ubuntu1 0
        400 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     7.2.4+14.04.20141217-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-updates/main i386 Packages
     7.2.2+14.04.20140714-0ubuntu1.1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty-security/main i386 Packages
     7.2.0+14.04.20140416-0ubuntu1 0
        500 http://ftp.jaist.ac.jp/pub/Linux/ubuntu/ trusty/main i386 Packages

[CHECK: TEST CASE]
(1) Download and run the attached Python script test-1374942 to create a candidate application.
(2) Press the close button and wait for the Force Quit dialog to come up.
(3) Choose the "Force Quit" button.

$ python test-1374942 & operate (2),(3).
---> Desktop shell does not crash.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.2.4+14.04.20150316-0ubuntu1

---------------
unity (7.2.4+14.04.20150316-0ubuntu1) trusty; urgency=medium

  [ Andrea Azzarone ]
  * Avoid running potentially dangerous code paths when the screen is
    locked. (LP: #1410582)
  * Ungrab the shoutdown dialog as soon as possible. (LP: #1398287)
  * Use COMPIZ_METAKEY where needed. (LP: #1363534)
  * disabled Pointer Barriers during lockscreen (LP: #1401911)
  * disabled markup for VolumeLauncherIcon quicklist menu items (LP:
    #1413411)
  * enable Dash, Hud, and session dialogs over full screen window (LP:
    #1159249, #860970, #1413773, #1404486)
  * made unity unlockable if user is in nopsswdlogin group (LP:
    #1413790)
  * skipped the animation of BGHash on startup to prevent unwanted fade-
    in (LP: #1241757)

  [ Luke Yelavich ]
  * extended accessible exploration of the Dash dynamic content (LP:
    #1066157)

  [ Marco Trevisan (Treviño) ]
  * MenuManager: make sure menus are always shown when mouse is over
    them or when the always-show-menus option is on (LP: #955193,
    #1390562, #1374942, #1312137)
  * PanelService: use gdbus to notfy upstart of service start/stop (LP:
    #1302955)
 -- CI Train Bot <email address hidden> Mon, 16 Mar 2015 17:30:35 +0000

Changed in unity (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers