compiz crashed with signal 5 in _XReply() from unity::decoration::ForceQuitDialog::ForceQuitDialog
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
7.2 |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Marco Trevisan (Treviño) | ||
Trusty |
Fix Released
|
Medium
|
Stephen M. Webb |
Bug Description
[Impact]
An invalid line of code would occasionally cause Unity to crash.
[Test Case]
(1) Download and run the attached Python script test-1374942 to create a candidate application.
(2) Press the close button and wait for the Force Quit dialog to come up.
(3) Choose the "Force Quit" button.
The desktop shell should not crash.
[Regression Potential]
The fix for this bug involves converting an integer into a string and appending it to an error message instead of adding the integer value to the address of the error message. There is unlikely to be a regression from this.
[Other Info]
The fix for Ubuntu 14.04 LTS was cherry picked from the Ubuntu "Vivid Vervet" dev release where it has been under daily use for some time without apparent regressioon.
Related branches
- Christopher Townsend (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Stephen M. Webb (community): Approve
-
Diff: 845 lines (+217/-96)17 files modifiedUnityCore/AppmenuIndicator.cpp (+24/-0)
UnityCore/AppmenuIndicator.h (+8/-0)
com.canonical.Unity.gschema.xml (+8/-0)
decorations/DecoratedWindow.cpp (+24/-14)
decorations/DecorationsForceQuitDialog.cpp (+24/-18)
decorations/DecorationsManager.cpp (+10/-3)
decorations/DecorationsSlidingLayout.cpp (+14/-8)
decorations/DecorationsSlidingLayout.h (+2/-0)
panel/PanelMenuView.cpp (+63/-32)
panel/PanelMenuView.h (+4/-1)
plugins/unityshell/src/unityshell.cpp (+1/-1)
unity-shared/DecorationStyle.cpp (+0/-1)
unity-shared/DecorationStyle.h (+0/-1)
unity-shared/MenuManager.cpp (+27/-4)
unity-shared/MenuManager.h (+5/-1)
unity-shared/UScreen.cpp (+3/-6)
unity-shared/UnitySettings.cpp (+0/-6)
- Christopher Townsend (community): Approve
-
Diff: 845 lines (+217/-96)17 files modifiedUnityCore/AppmenuIndicator.cpp (+24/-0)
UnityCore/AppmenuIndicator.h (+8/-0)
com.canonical.Unity.gschema.xml (+8/-0)
decorations/DecoratedWindow.cpp (+24/-14)
decorations/DecorationsForceQuitDialog.cpp (+24/-18)
decorations/DecorationsManager.cpp (+10/-3)
decorations/DecorationsSlidingLayout.cpp (+14/-8)
decorations/DecorationsSlidingLayout.h (+2/-0)
panel/PanelMenuView.cpp (+63/-32)
panel/PanelMenuView.h (+4/-1)
plugins/unityshell/src/unityshell.cpp (+1/-1)
unity-shared/DecorationStyle.cpp (+0/-1)
unity-shared/DecorationStyle.h (+0/-1)
unity-shared/MenuManager.cpp (+27/-4)
unity-shared/MenuManager.h (+5/-1)
unity-shared/UScreen.cpp (+3/-6)
unity-shared/UnitySettings.cpp (+0/-6)
Changed in unity: | |
importance: | Undecided → Medium |
Changed in unity: | |
status: | New → Confirmed |
summary: |
- compiz crashed with signal 5 in _XReply() + compiz crashed with signal 5 in _XReply() from + unity::decoration::ForceQuitDialog::ForceQuitDialog |
Changed in unity: | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity: | |
milestone: | none → 7.3.1 |
Changed in unity: | |
status: | In Progress → Fix Released |
Changed in unity (Ubuntu Trusty): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Stephen M. Webb (bregma) |
tags: |
added: verification-done removed: verification-needed |
StacktraceTop: property@ entry=67, offset= offset@ entry=0, length= length@ entry=8192, delete= delete@ entry=0, req_type=31, actual_ type=0x7fff49c9 22f0, actual_ format= 0x7fff49c922ec, nitems= 0x7fff49c922f8, bytesafter= 0x7fff49c92300, prop=0x7fff49c9 2308) at ../../src/ GetProp. c:69 0x7fff49c925b0) at ../../src/ GetHints. c:311 sandbox_ VLSQqv/ usr/lib/ compiz/ libunityshell. so :decoration: :ForceQuitDialo g::ForceQuitDia log(CompWindow* , unsigned long) () from /tmp/apport_ sandbox_ VLSQqv/ usr/lib/ compiz/ libunityshell. so :decoration: :Window: :Impl:: ShowForceQuitDi alog(bool, unsigned long) () from /tmp/apport_ sandbox_ VLSQqv/ usr/lib/ compiz/ libunityshell. so
XGetWindowProperty (dpy=0x21dbf20, w=65013809, property=
XGetClassHint (dpy=<optimized out>, w=<optimized out>, classhint=
?? () from /tmp/apport_
unity:
unity: