Gnome screensaver should not run automatically in an unity session

Bug #1303712 reported by Marco Trevisan (Treviño)
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
High
Iain Lane
gnome-screensaver (Ubuntu)
Fix Released
Undecided
Marco Trevisan (Treviño)
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Unity is now handling the gnome screensaver dbus API completely, so we don't need anymore to run GS in an unity session.

Tags: lockscreen

Related branches

summary: - [FFe] Remove gnome screensaver from unity installation
+ [FFe] Remove gnome screensaver with unity installation
Changed in unity:
assignee: nobody → Andrea Azzarone (andyrock)
Revision history for this message
Sebastien Bacher (seb128) wrote : Re: [FFe] Remove gnome screensaver with unity installation

Thanks for the work, some thoughts on the changes:

First, having Unity doing the handling rather than relying on g-s makes sense, good work in that direction ;-)

Some issues/things to consider though

- it's late in the cycle, gnome-screensaver interfaces with other components for e.g idle count. We need to make sure we don't regress anything if we change that

- it's possible to install several desktops on the same machine, we can't really make Unity to uninstall gnome-screensaver when it's still used in e.g gnome-panel sessions

- Luke did that change https://launchpad.net/ubuntu/+source/gnome-screensaver/3.6.1-0ubuntu11

it seems like he didn't open a bug/give specifics on the issues with the screenreader (Marco said it should be working). Luke could you open a bug about the issues you had and provide details?

Revision history for this message
Luke Yelavich (themuso) wrote : Re: [Bug 1303712] Re: [FFe] Remove gnome screensaver with unity installation

Bug #1304111 is for what is needed for the unity lock screen. accessibility wise. I initially looked at this, and decided post feature freeze that introducing so much new code was too risky and could introduce more bugs, hense patching gnome-screensaver to use the original lock screen when the screen reader is in use.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote : Re: [FFe] Remove gnome screensaver with unity installation

I think that could have been done by trying to fix unity first, by the way in terms of screen readers the unity lockscreen seems to tell more here than gs.

As per this workaround, it can be done also unity side: by falling back to GS if a11y options are on, and this is what lp:~3v1n0/unity/lockscreen-disable-with-osk does. So, we can still have both things, but making unity to control what's best to do.

summary: - [FFe] Remove gnome screensaver with unity installation
+ Gnome screensaver should not run automatically in an unity session
description: updated
Changed in gnome-screensaver (Ubuntu):
status: New → In Progress
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: New → In Progress
Changed in unity:
status: New → In Progress
milestone: none → 7.2.1
Changed in unity:
assignee: Andrea Azzarone (andyrock) → Iain Lane (laney)
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.2.0+14.04.20140410-0ubuntu1

---------------
unity (7.2.0+14.04.20140410-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * GnomeSessionManager: impelement gnome session dbus interface and a
    fader to blank the screen (LP: #1291088)
  * ScreenSaverDBusManager: start/stop gnome-screensaver if we don't/do
    handle the locking This allows to just use the fallback gnome-
    screensaver lockscreen if we need to use it. (LP: #1303712)
  * Session: Don't lock the screen if screen locking is disabled by
    org.gnome.desktop.lockdown disable-lock-screen. (LP: #1292154)

  [ Andrea Azzarone ]
  * LockScreen: add ability to show without fading in on some system
    calls Also, if locking is not enabled, calling Lock causes the
    screensaver to be initiated. Many cleanups and misc fixes. (LP:
    #1292575)

  [ Marco Trevisan (Treviño) ]
  * LockScreen: add ability to show without fading in on some system
    calls Also, if locking is not enabled, calling Lock causes the
    screensaver to be initiated. Many cleanups and misc fixes. (LP:
    #1292575)
 -- Ubuntu daily release <email address hidden> Thu, 10 Apr 2014 12:45:15 +0000

Changed in unity (Ubuntu):
status: In Progress → Fix Released
Changed in gnome-screensaver (Ubuntu):
status: In Progress → Fix Released
Changed in unity:
status: In Progress → Fix Committed
tags: added: lockscreen
Stephen M. Webb (bregma)
Changed in unity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.