Gnome screensaver should not run automatically in an unity session
Bug #1303712 reported by
Marco Trevisan (Treviño)
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
High
|
Iain Lane | ||
gnome-screensaver (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Unity is now handling the gnome screensaver dbus API completely, so we don't need anymore to run GS in an unity session.
Related branches
lp:~3v1n0/gnome-screensaver/not-autostart-in-unity
- Sebastien Bacher: Approve
-
Diff: 2397 lines (+24/-2172)11 files modified.pc/33_unity_lockscreen_on_lock.patch/src/gs-manager.c (+0/-1365)
.pc/33_unity_lockscreen_on_lock.patch/src/gs-manager.h (+0/-99)
.pc/33_unity_lockscreen_on_lock.patch/src/gs-monitor.c (+0/-506)
.pc/applied-patches (+1/-2)
debian/patches/19_not_autostart_in_unity.patch (+15/-17)
debian/patches/series (+2/-2)
src/gnome-screensaver.desktop.in (+2/-1)
src/gnome-screensaver.desktop.in.in (+2/-1)
src/gs-manager.c (+2/-24)
src/gs-manager.h (+0/-1)
src/gs-monitor.c (+0/-154)
lp:~3v1n0/unity/lockscreen-disable-with-osk
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 322 lines (+93/-16)11 files modifiedUnityCore/GLibDBusServer.cpp (+4/-4)
UnityCore/GLibDBusServer.h (+1/-1)
debian/rules (+2/-0)
lockscreen/LockScreenController.cpp (+18/-5)
lockscreen/LockScreenController.h (+2/-1)
lockscreen/LockScreenSettings.cpp (+17/-0)
lockscreen/LockScreenSettings.h (+1/-0)
lockscreen/ScreenSaverDBusManager.cpp (+27/-3)
lockscreen/ScreenSaverDBusManager.h (+3/-2)
plugins/unityshell/src/unityshell.cpp (+3/-0)
tests/data/external.gschema.xml (+15/-0)
summary: |
- [FFe] Remove gnome screensaver from unity installation + [FFe] Remove gnome screensaver with unity installation |
Changed in unity: | |
assignee: | nobody → Andrea Azzarone (andyrock) |
summary: |
- [FFe] Remove gnome screensaver with unity installation + Gnome screensaver should not run automatically in an unity session |
description: | updated |
Changed in gnome-screensaver (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Marco Trevisan (Treviño) (3v1n0) |
Changed in unity (Ubuntu): | |
status: | New → In Progress |
Changed in unity: | |
status: | New → In Progress |
milestone: | none → 7.2.1 |
Changed in unity: | |
assignee: | Andrea Azzarone (andyrock) → Iain Lane (laney) |
importance: | Undecided → High |
Changed in gnome-screensaver (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in unity: | |
status: | In Progress → Fix Committed |
tags: | added: lockscreen |
Changed in unity: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for the work, some thoughts on the changes:
First, having Unity doing the handling rather than relying on g-s makes sense, good work in that direction ;-)
Some issues/things to consider though
- it's late in the cycle, gnome-screensaver interfaces with other components for e.g idle count. We need to make sure we don't regress anything if we change that
- it's possible to install several desktops on the same machine, we can't really make Unity to uninstall gnome-screensaver when it's still used in e.g gnome-panel sessions
- Luke did that change https:/ /launchpad. net/ubuntu/ +source/ gnome-screensav er/3.6. 1-0ubuntu11
it seems like he didn't open a bug/give specifics on the issues with the screenreader (Marco said it should be working). Luke could you open a bug about the issues you had and provide details?