[MIR] Unity 100-scopes and dependencies

[Łukasz Zemczak]

[Rationale]

Recently Unity had the 100-scopes functionality merged into trunk. This functionality implies additional dependencies for new packages - all the scopes that have been written for this purpose. Without these packages, the functionality makes no sense and cannot work properly. As unity is a package in main, we also need all the default scopes to be included in main - as well as on the iso.

[Quality Assurance and Maintainance]

All the scopes are maintained by Canonical, along with unity.

[Other]

Normally a single MIR should be filled in for a single package. In this case, since there are many packages involved, we have decided that a single bug report with all the scopes mentioned could be sufficient enough.

List of new packages to include to main:
lp:unity-scope-audacious
lp:unity-scope-chromiumbookmarks
lp:unity-scope-calculator
lp:unity-scope-clementine
lp:unity-scope-colourlovers
lp:unity-scope-devhelp
lp:unity-scope-deviantart
lp:unity-scope-firefoxbookmarks
lp:unity-scope-gallica
lp:unity-scope-gdrive
lp:unity-scope-github
lp:unity-scope-gmusicbrowser
lp:unity-scope-googlenews
lp:unity-scope-gourmet
lp:unity-scope-guayadeque
lp:unity-scope-home
lp:unity-scope-manpages
lp:unity-scope-musique
lp:unity-scope-openclipart
lp:unity-scope-openweathermap
lp:unity-scope-soundcloud
lp:unity-scope-texdoc
lp:unity-scope-tomboy
lp:unity-scope-virtualbox
lp:unity-scope-yahoostock
lp:unity-scope-yelp
lp:unity-scope-zotero

lp:python-dbusmock

Useful bug reports:
https://bugs.launchpad.net/bugs/1154229
https://bugs.launchpad.net/ubuntu/+bug/1184656

[Michael Terry (mterry)]

Most of these are OK (list of approved ones at the bottom). Here are some problems with specific scopes:

* python3-feedparser will need to be promoted to main, but the source is already promoted, so that's fine.

* Relatedly, python3-dbusmock needs to be added to this MIR. This is used in the tomboy scope.

* launchpad and sshsearch are python2-based. We shouldn't add more python2 packages to the desktop image, if we can help it. I understand that they are both only python2 because of dependencies. If the Desktop team really wants them in, I defer to them.

* musique has one oddity in its get_album_art() function: it returns "audacious" as the icon name in a few error cases. Is that intentional?

* guayadeque has a test method (test_guayadeque_failing_search) that has a typo. It references the file mock_clementine_fail, when it should be mock_guayadeque_fail. This test should be written better to make sure it is actually loading the mock and testing what it thinks it is. This is a general problem with these scope test suites. Many have failure test cases, but they aren't very narrowly targeted. The general problem isn't a blocker, but guayadeque at least should fix the typo.

Here are the approved without comment ones:

unity-scope-audacious
unity-scope-chromiumbookmarks
unity-scope-calculator
unity-scope-clementine
unity-scope-colourlovers
unity-scope-devhelp
unity-scope-deviantart
unity-scope-evolution
unity-scope-firefoxbookmarks
unity-scope-gallica
unity-scope-gdrive
unity-scope-github
unity-scope-gmusicbrowser
unity-scope-googlenews
unity-scope-gourmet
unity-scope-home
unity-scope-manpages
unity-scope-openclipart
unity-scope-openweathermap
unity-scope-soundcloud
unity-scope-texdoc
unity-scope-tomboy
unity-scope-virtualbox
unity-scope-yahoostock
unity-scope-yelp
unity-scope-zotero

[Łukasz Zemczak (sil2100)]

Hi Michael!

Thanks for the review! I have added python3-dbusmock to this MIR and changed the title of the bug for better understanding.
As for the other issues, I will contact upstream about those. Maybe we could somehow make the two scopes python3 in 'some' way, if not, I'll push it to the Desktop team.
Same for musique and guayadeque - once I know something, I'll get back to you.

[David Callé (davidc3)]

Hi Michael and Lukasz!
First, thanks to both for creating the bug and taking the time to do this lenghty review.

* "launchpad and sshsearch are python2-based. We shouldn't add more python2 packages to the desktop image, if we can help it. I understand that they are both only python2 because of dependencies. If the Desktop team really wants them in, I defer to them."

The Launchpad scope could maybe leave the client side to move on the smart scopes server, but that would kill the possibility of having any desktop integration with it in the future. I do agree with the rationale of keeping new python2 out, but I think it would be unfortunate to ship a GitHub scope and not a Launchpad one. The sshsearch one has a dependency on python-paramiko, and the python3 paramiko port is being discussed on their project bugtracker, but not there yet.

* "musique has one oddity in its get_album_art() function: it returns "audacious" as the icon name in a few error cases. Is that intentional?"

That's clearly a bug we missed, Musique not being one of the most used scope of the stack.

* "guayadeque has a test method (test_guayadeque_failing_search) that has a typo. It references the file mock_clementine_fail, when it should be mock_guayadeque_fail. This test should be written better to make sure it is actually loading the mock and testing what it thinks it is. This is a general problem with these scope test suites. Many have failure test cases, but they aren't very narrowly targeted. The general problem isn't a blocker, but guayadeque at least should fix the typo."

The requested fixes will likely land in a few hours in their respective trunks. I will also make sure to review tests for each scope the next time they are updated.

[Michael Terry (mterry)]

Actually, I remember that python-dbusmock is already approved, but not yet promoted in bug 1154126. So dropping from this report.

[Łukasz Zemczak (sil2100)]

@Michael

The fixes for guayadeque and musique seem to have landed in trunk. Could you re-take a look and approve those as well if anything?

Also, would it be possible to accept those launchpad and sshsearch scopes as python2 for now?

Thanks!

[Michael Terry (mterry)]

I'm talking to seb128 and didrocks about the python2 issues. But sure, these two additional music scopes are approved:

unity-scope-guayadeque
unity-scope-musique

[Łukasz Zemczak (sil2100)]

As discussed, I am removing the two python2 scopes from the MIR. Also, the evolution scope seems to have been removed, but oh well.

[Didier Roche-Tolomelli (didrocks)]

all scopes are promoted to main now, apart sshsearch and launchpad in universe.

[Didier Roche-Tolomelli (didrocks)]

$ ./change-override -s saucy -c main python3-feedparser
Override component to main
python3-feedparser 5.1.2-1ubuntu2 in saucy amd64: universe/python/optional -> main
python3-feedparser 5.1.2-1ubuntu2 in saucy armhf: universe/python/optional -> main
python3-feedparser 5.1.2-1ubuntu2 in saucy i386: universe/python/optional -> main
python3-feedparser 5.1.2-1ubuntu2 in saucy powerpc: universe/python/optional -> main