Lag when favoriting/unfavoriting scopes via Manage Dash
Bug #1583067 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Confirmed
|
Undecided
|
Alejandro J. Cura | ||
| unity-scopes-shell (Ubuntu) |
Fix Released
|
Medium
|
Paweł Stołowski | ||
Bug Description
There is a noticable lag (2-3 seconds) when unfavoriting and favoriting scopes via Manage Dash. This is probably caused by the fact, that favorites are first written to gsettings, then read back upon gsettings change signal and only then reflected in the display, so there is some I/O and processing of gsettings change when user taps the star. It would be nice to optimize this.
Related branches
lp:~stolowski/unity-scopes-shell/favoriting-fixes
- Marcus Tomlinson (community): Approve
-
Diff: 626 lines (+309/-126)7 files modifiedsrc/Unity/CMakeLists.txt (+1/-0)
src/Unity/favorites.cpp (+160/-0)
src/Unity/favorites.h (+63/-0)
src/Unity/scope.cpp (+4/-4)
src/Unity/scope.h (+2/-2)
src/Unity/scopes.cpp (+76/-118)
src/Unity/scopes.h (+3/-2)
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| status: | New → Confirmed |
| Changed in unity-scopes-shell (Ubuntu): | |
| assignee: | nobody → Paweł Stołowski (stolowski) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package unity-scopes-shell - 0.5.8+16.
---------------
unity-scopes-shell (0.5.8+
[ Albert Astals Cid ]
* Optimize ResultsModel::data a bit
* Save creating/destroying a QSharedPointer
[ Marcus Tomlinson ]
* Don't make changes to the settings model from a separate thread.
(LP: #1627795)
[ Pawel Stolowski ]
* Optimize scope favoriting. Make sure click scope is favorited back
if reinstalled. (LP: #1583067, #1603186)
-- Marcus Tomlinson <email address hidden> Tue, 04 Oct 2016 09:00:09 +0000