Scope::settings() is too slow
Bug #1567429 reported by
Albert Astals Cid
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity-scopes-shell (Ubuntu) |
Fix Released
|
Undecided
|
Marcus Tomlinson |
Bug Description
Evaluating
settingsEnabled: scopeView.scope && scopeView.
in GenericScopeVie
If this needs heavy calculation this should be either pre-calculated and cached or calculated in a separate thread and then signalled with a signal.
Related branches
lp:~marcustomlinson/unity-scopes-shell/lp-1567429
- Paweł Stołowski (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 275 lines (+65/-16)5 files modifiedsrc/Unity/scope.cpp (+25/-6)
src/Unity/scope.h (+5/-0)
src/Unity/scopes.cpp (+2/-0)
src/Unity/settingsmodel.cpp (+31/-10)
src/Unity/settingsmodel.h (+2/-0)
Changed in unity-scopes-shell (Ubuntu): | |
assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
Changed in unity-scopes-shell (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in unity-scopes-shell (Ubuntu): | |
status: | In Progress → Fix Released |
To post a comment you must log in.
From a quick look the problem is most likely caused by Scope::settings() getter, which calls update_ child_scopes( ) every time settings model is accessed by the getter, and this involves IPC with m_scopeProxy- >child_ scopes( ) call, which is a blocking call.