Result activation on single tap doesn't fully support scopes API capabilities
Bug #1428063 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-shell (Ubuntu) |
Fix Committed
|
Undecided
|
Paweł Stołowski | ||
| unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Albert Astals Cid | ||
Bug Description
Single tap doesn't fully honor intercept activation flag exposed by Scopes API. Activation can only be intercepted by scope if result's uri is "scope://..." (or if scope is "clickscope"). There is some special-casing for that in unity8 dash qml code, we should probably move this down to shell plugin to fix the issue of intercept activation flag.
Related branches
lp:~stolowski/unity-api/activation-iface-change
- Xavi Garcia (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
- Marcus Tomlinson: Pending requested
-
Diff: 102 lines (+16/-8)6 files modifieddebian/changelog (+6/-0)
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ScopeInterface.h (+2/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp (+4/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h (+2/-2)
test/qmltest/unity/shell/scopes/tst_Scopes.qml (+1/-1)
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 99 lines (+16/-8)6 files modifieddebian/changelog (+6/-0)
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ScopeInterface.h (+2/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp (+4/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h (+2/-2)
test/qmltest/unity/shell/scopes/tst_Scopes.qml (+1/-1)
lp:~aacid/unity8/dash_activation_no_special_casing
- Paweł Stołowski (community): Approve
- Andrea Cimitan (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 275 lines (+71/-38)10 files modifieddebian/changelog (+6/-0)
debian/control (+2/-2)
qml/Dash/GenericScopeView.qml (+50/-26)
qml/Dash/PreviewListView.qml (+2/-1)
qml/Dash/ScopesList.qml (+1/-1)
tests/mocks/Unity/CMakeLists.txt (+1/-1)
tests/mocks/Unity/fake_scope.cpp (+5/-3)
tests/mocks/Unity/fake_scope.h (+2/-2)
tests/mocks/Unity/fake_scopesoverview.cpp (+1/-1)
tests/mocks/Unity/fake_scopesoverview.h (+1/-1)
lp:~stolowski/unity-scopes-shell/activation-fix-wily
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 206 lines (+35/-29)8 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+7/-0)
debian/control (+3/-2)
src/Unity/scope.cpp (+13/-4)
src/Unity/scope.h (+2/-2)
src/scope-harness/results/result.cpp (+5/-5)
src/scope-harness/test-utils.cpp (+1/-1)
tests/overviewtest.cpp (+3/-14)
lp:~stolowski/unity-api/activation-iface-change-wily
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 99 lines (+16/-8)6 files modifieddebian/changelog (+6/-0)
include/unity/shell/scopes/CMakeLists.txt (+1/-1)
include/unity/shell/scopes/ScopeInterface.h (+2/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.cpp (+4/-2)
test/qmltest/mocks/plugins/Unity/Scopes/Mocks/MockScope.h (+2/-2)
test/qmltest/unity/shell/scopes/tst_Scopes.qml (+1/-1)
| description: | updated |
Revision history for this message
| Arsenij Krasikov (arseny-krassikov) wrote | #1 |
| Changed in unity-scopes-shell (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| Changed in unity8 (Ubuntu): | |
| assignee: | nobody → Albert Astals Cid (aacid) |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | New → Fix Committed |
| Changed in unity8 (Ubuntu): | |
| status: | New → Fix Committed |
| Changed in unity8 (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Same behaviour noticed, Result has URI without "scope://" , however scope is packed into a click. OS build 21, image 20150410.1