Aggregator can't subsearch the same child twice to get different depts

[Chris Wayne]

As of the latest vivid images, NearBy can no longer subsearch children several times, which is used for example to search the coffee dept, as well as the bars dept for the I'm Thirsty section of nearby. The query string is blank in both instances, with only the dept of the child scope changing

[Michi Henning (michihenning)]

Discussed this with Chris. Problem is real. Basically, the Nearby Scope fires more than one query at a particular child, but with different department, or potentially different query string and/or filter settings. Doing this is quite legit. The loop detection is too stringent right now because it axes off any query that loops around, regardless of whether the query details are the same or not.

We need to change the loop detection to take all of the query state into account. That way, queries that differ in some detail will still be forwarded to children, but queries that loop around unchanged and therefore indicate a real accidental loop are still axed.

[Pat McGowan (pat-mcgowan)]

regression

[Michi Henning (michihenning)]

See the linked branch. The loop detector now triggers only if the query is identical in all respects, that is, query string, department, filter state, user data, and metadata are identical. If any of these differ, the query is forwarded as usual.

[Michi Henning (michihenning)]

Chris, I'm pretty sure that this will fix your problem. If not, can you please re-open?

[Chris Wayne (cwayne)]

I've tried this out and it seems to fix our issue, thanks!