SettingsDb should check file timestamps instead of using inotify watch
Bug #1453041 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api (Ubuntu) |
Fix Released
|
Low
|
Paweł Stołowski | ||
Bug Description
SettingsDb could be greatly simplified by using ctime/mtime of the settings file, rather than a watcher thread and inotify watch. The only place where we care if settings file has changes is settings() getter and this is where we can just check ctime/mtime to detect changes and re-parse.
Related branches
lp:~stolowski/unity-scopes-api/settingsdb-use-timestamp
- Michi Henning (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 474 lines (+113/-230)4 files modifiedinclude/unity/scopes/ScopeBase.h (+2/-0)
include/unity/scopes/internal/SettingsDB.h (+4/-21)
src/scopes/internal/SettingsDB.cpp (+64/-199)
test/gtest/scopes/internal/SettingsDB/SettingsDB_test.cpp (+43/-10)
| Changed in unity-scopes-api (Ubuntu): | |
| importance: | Undecided → High |
| importance: | High → Medium |
| importance: | Medium → Wishlist |
| Changed in unity-scopes-api (Ubuntu): | |
| importance: | Wishlist → Undecided |
| Changed in unity-scopes-api (Ubuntu): | |
| importance: | Undecided → Low |
| Changed in unity-scopes-api (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| status: | New → In Progress |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | In Progress → Fix Committed |
| Changed in unity-scopes-api (Ubuntu): | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
